git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Michael Witten <mfwitten@gmail.com>
Cc: Thomas Rast <trast@student.ethz.ch>, git <git@vger.kernel.org>
Subject: Re: vger doesn't like UTF-8 from send-email
Date: Mon, 14 Jun 2010 13:57:21 +0200	[thread overview]
Message-ID: <AANLkTinH7p6_WV1FK7UTZLg-8OGINZFnYMA1kENb6PkW@mail.gmail.com> (raw)
In-Reply-To: <AANLkTim1QajqLOp4y6-oIMAGp8Tkf7z9uTH6bwIIFYkH@mail.gmail.com>

On Sun, Jun 13, 2010 at 6:15 AM, Michael Witten <mfwitten@gmail.com> wrote:
> On Sat, Jun 12, 2010 at 05:11, Thomas Rast <trast@student.ethz.ch> wrote:
>> AFAICT the original message did not declare an encoding:
>>
>> Subject: [PATCH v2 0/2] bash completion: Support "divergence from upstream" warnings in __git_ps1
>> Date: Sat, 12 Jun 2010 12:02:14 +0200
>> Message-ID: <cover.1276336602.git.trast@student.ethz.ch>
>> X-Mailer: git-send-email 1.7.1.561.g94582
>> In-Reply-To: <20100612000002.GA30196@neumann>
>> References: <20100612000002.GA30196@neumann>
>> MIME-Version: 1.0
>> Content-Type: text/plain
>> Return-Path: trast@student.ethz.ch
>> ...
>> Is this a new vger policy, or am I hitting a send-email bug?
>
> Let's assume the headers themselves are already properly encoded.
>
> According to:
>
>    http://www.faqs.org/rfcs/rfc2045.html
>
> we have:
>
>    The proper Content-Transfer-Encoding
>    label must always be used.
>
> and:
>
>    An encoding type of 7BIT requires that
>    the body is already in a 7bit mail-ready
>    representation.  This is the default value
>    -- that is, "Content-Transfer-Encoding: 7BIT"
>    is assumed if the Content-Transfer-Encoding
>    header field is not present.
>
> Moreover, according to:
>
>    http://www.faqs.org/rfcs/rfc2046.html
>
> we have:
>
>    4.1.2    Charset Parameter
>    ...
>    The default character set, which must be
>    assumed in the absence of a charset parameter,
>    is US-ASCII.
>
> So, your email is indeed incorrect in 2 ways if the body contains
> UTF-8 encoded data.
>
> From what I've skimmed, the mail user agent (MUA)---such as
> send-email---could send your unmodified message body by producing
> these headers:
>
>    MIME-Version: 1.0
>    Content-type: text/plain; charset=utf-8
>    Content-transfer-encoding: 8bit
>
> but only 7bit transfer encodings are guaranteed to make it intact to
> the destination; consequently, it would probably be a good idea for
> the MUA to transform your message into some 7bit encoding, preferably
> a human-readable one such as the 'quoted-printable' encoding; after
> such a transformation, the headers could be:
>
>    MIME-Version: 1.0
>    Content-type: text/plain; charset=utf-8
>    Content-transfer-encoding: quoted-printable
>

QP-encoding is sometimes destructive, and as such not recommended for
patches - in fact, Documentation/SubmittingPatches forbid it. For the
cover-letter the destruction might not be an issue (IIRC it's some
line-feeds that might be added because QP can a line longer than the
maximum line-length), but special casing the encoding for
cover-letters doesn't strike me as The Right Thing To Do(tm).

I think the only real alternative to 8-bit encoding is Base64, and it
sacrifices human-readability. Dunno how bad that is, though.

-- 
Erik "kusma" Faye-Lund

  reply	other threads:[~2010-06-14 11:57 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-06  0:05 [PATCH] bash completion: Support "unpushed commits" warnings in __git_ps1 Andrew Sayers
2010-06-06 18:14 ` Thomas Rast
2010-06-06 20:49   ` Andrew Sayers
2010-06-06 21:07     ` Jakub Narebski
2010-06-06 22:19       ` Andrew Sayers
2010-06-07  7:42     ` Thomas Rast
2010-06-08 21:36       ` [RFC/PATCHv2] bash completion: Support "divergence from upstream" " Andrew Sayers
2010-06-09  8:21         ` Peter Kjellerstedt
2010-06-09  8:45         ` John Tapsell
2010-06-09 21:02           ` Steven Michalske
2010-06-09  9:17         ` Michael J Gruber
2010-06-09 20:48           ` Michael J Gruber
2010-06-09 21:03             ` Michael J Gruber
2010-06-10 11:47         ` [PATCH 0/2] " Thomas Rast
2010-06-10 11:47           ` [PATCH 1/2] rev-list: introduce --count option Thomas Rast
2010-06-10 11:47           ` [PATCH 2/2] bash completion: Support "divergence from upstream" warnings in __git_ps1 Thomas Rast
2010-06-12  0:00             ` SZEDER Gábor
2010-06-12 10:03               ` [PATCH v2 0/2] " Thomas Rast
2010-06-12  9:59                 ` [PATCH v2 1/2] rev-list: introduce --count option Thomas Rast
2010-06-12  9:59                 ` [PATCH v2 2/2] bash completion: Support "divergence from upstream" warnings in __git_ps1 Thomas Rast
2010-06-14  3:13                   ` Junio C Hamano
2010-06-14  7:44                     ` Thomas Rast
2010-06-14 12:36                   ` SZEDER Gábor
2010-06-12 10:11                 ` vger doesn't like UTF-8 from send-email Thomas Rast
2010-06-12 15:06                   ` [PATCH] send-email: ask about and declare 8bit mails Thomas Rast
2010-06-12 16:28                     ` Junio C Hamano
2010-06-13 15:09                       ` Thomas Rast
2010-06-13  4:15                   ` vger doesn't like UTF-8 from send-email Michael Witten
2010-06-14 11:57                     ` Erik Faye-Lund [this message]
2010-06-12 20:50                 ` [PATCH] bash completion: Support "divergence from upstream" messages in __git_ps1 Andrew Sayers
2010-06-14  7:42                   ` Thomas Rast
2010-06-15 21:50                     ` [PATCHv4] " Andrew Sayers
2010-06-16 19:05                       ` Junio C Hamano
2010-06-16 19:11                         ` Thomas Rast
2010-06-17 21:31                         ` [PATCHv5 0/2] " Andrew Sayers
2010-06-18 16:10                           ` Junio C Hamano
2010-06-18 21:02                             ` Andrew Sayers
2010-06-17 21:32                         ` [PATCHv5 1/2] " Andrew Sayers
2010-06-17 21:32                         ` [PATCHv5 2/2] bash-completion: Fix __git_ps1 to work with "set -u" Andrew Sayers
2010-06-10 13:31           ` [PATCH 0/2] bash completion: Support "divergence from upstream" warnings in __git_ps1 Michael J Gruber
2010-06-10 12:03         ` [RFC/PATCHv2] " Thomas Rast
2010-06-06 20:12 ` [PATCH] bash completion: Support "unpushed commits" " Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinH7p6_WV1FK7UTZLg-8OGINZFnYMA1kENb6PkW@mail.gmail.com \
    --to=kusmabite@googlemail.com \
    --cc=git@vger.kernel.org \
    --cc=kusmabite@gmail.com \
    --cc=mfwitten@gmail.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).