From: Bert Wesarg <bert.wesarg@googlemail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Eli Barzilay <eli@barzilay.org>,
Heiko Voigt <hvoigt@hvoigt.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH/RFC] Hacky version of a glob() driven config include
Date: Fri, 7 May 2010 21:52:07 +0200 [thread overview]
Message-ID: <AANLkTimziTKL13VKIOcaS1TX1F_xvTVjH8Q398Yx36Us@mail.gmail.com> (raw)
In-Reply-To: <AANLkTilG5OGjQcd1Vd1CdyOibFh4Po6jdfvSRNidrRzh@mail.gmail.com>
On Fri, May 7, 2010 at 20:58, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> On Fri, May 7, 2010 at 18:29, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>> On Fri, May 7, 2010 at 18:56, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>>> On Fri, May 7, 2010 at 06:00, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>>>> On Thu, May 6, 2010 at 23:14, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>>>>>
>>>>> Not-signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>>>>
>>>> So you don't agree to the Developer's Certificate of Origin, don't you?
>>>
>>> Signed-off-by is for "if you want your work included in git.git"
>>> (according to Documentation/SubmittingPatches). I don't think this
>>> patch is ready for inclusion as-is, but I wanted to solicit comments
>>> on the general approach.
>>>
>>
>> Can you please quote SubmittingPatches for your argumentation.
>
> I already did, but here's the full paragraph I quoted from, for
> reference:
>
> - if you want your work included in git.git, add a
> "Signed-off-by: Your Name <you@example.com>" line to the
> commit message (or just use the option "-s" when
> committing) to confirm that you agree to the Developer's
> Certificate of Origin
>
But where does the Developer's Certificate of Origin talks about
non-legal aspects of patch submitting? E.g. correctness, quality, ...
I think the part "if you want your work included in git.git" is very
misleading in this paragraph, and I propose to remove it.
> I'm not seeking to include this work as-is in Git, so I added a
> Not-signed-off-by line to make that clear (as if all the bugs didn't
> do that already).
>
> I do agree to the Developer's Certificate of Origin, but just read the
> "Not-signed-off-by" as "you really don't want to apply this in its
> current state". I'm asking for comments so that I can produce an
> appliable patch, that one will have a Signed-off-by line.
>
And thats exactly where you mixed legal and technical aspects of patch
submitting, and others may not (especially me, obviously). The S-o-b
line has nothing to do with the technical aspect, or the quality, of
the patch. Adding "Not-signed-off-by" (or even worse: changing it
later to Signed-off-by) could actually mean that you stole the code
from someone else.
Bert
next prev parent reply other threads:[~2010-05-07 19:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 21:20 Is there interest in reading ~/.gitconfig.d/* and /etc/gitconfig.d/*? Ævar Arnfjörð Bjarmason
2010-04-01 22:03 ` Heiko Voigt
2010-04-04 7:24 ` Peter Krefting
2010-04-04 7:59 ` Eli Barzilay
[not found] ` <19384.17579.205005.86711@winooski.ccs.neu.edu>
2010-04-06 8:15 ` Ævar Arnfjörð Bjarmason
2010-04-06 9:02 ` Jakub Narebski
2010-05-06 21:14 ` [PATCH/RFC] Hacky version of a glob() driven config include Ævar Arnfjörð Bjarmason
2010-05-07 6:00 ` Bert Wesarg
2010-05-07 16:56 ` Ævar Arnfjörð Bjarmason
2010-05-07 18:29 ` Bert Wesarg
2010-05-07 18:58 ` Ævar Arnfjörð Bjarmason
2010-05-07 19:02 ` Jacob Helwig
2010-05-07 19:52 ` Bert Wesarg [this message]
2010-05-07 20:11 ` [PATCH/RFC v2] " Ævar Arnfjörð Bjarmason
2010-05-07 20:46 ` [PATCH/RFC] " Jakub Narebski
2010-05-07 22:15 ` Ævar Arnfjörð Bjarmason
2010-05-07 23:43 ` Jakub Narebski
2010-05-08 2:30 ` Ping Yin
2010-05-08 8:18 ` Jakub Narebski
2010-05-08 9:03 ` Ping Yin
2010-05-08 5:06 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimziTKL13VKIOcaS1TX1F_xvTVjH8Q398Yx36Us@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=avarab@gmail.com \
--cc=eli@barzilay.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).