From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Joshua Jensen <jjensen@workspacewhiz.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/6] Add string comparison functions that respect the ignore_case variable.
Date: Sun, 29 Aug 2010 19:39:34 +0000 [thread overview]
Message-ID: <AANLkTimtmudtWccRS==LrO_JrPmAJ7HzA6CU0ALbDZcV@mail.gmail.com> (raw)
In-Reply-To: <201008182032.40375.j6t@kdbg.org>
On Wed, Aug 18, 2010 at 18:32, Johannes Sixt <j6t@kdbg.org> wrote:
> On Mittwoch, 18. August 2010, Ævar Arnfjörð Bjarmason wrote:
>> According to some further research at least FreeBSD and NetBSD have
>> copied this GNU extension. You may find their versions easier to
>> integrate.
>
> We already have a GNU fnmatch in compat/fnmatch.
Do you have any plan to deal with this? I currently have this
monkeypatch to build on Solaris:
diff --git a/Makefile b/Makefile
index 62d526a..079fae5 100644
--- a/Makefile
+++ b/Makefile
@@ -863,2 +863,4 @@ endif
ifeq ($(uname_S),SunOS)
+ COMPAT_OBJS = compat/fnmatch/fnmatch.o
+ COMPAT_CFLAGS = -Icompat -Icompat/fnmatch
NEEDS_SOCKET = YesPlease
One way to deal with it would be a new NONGNU_FNMATCH=UnfortunatelyYes
flag, or the fnmatch_icase() suggestion above which we could bundle
and always use. But having next build on systems without GNU
extensions would be preferrable.
next prev parent reply other threads:[~2010-08-29 19:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 19:38 [PATCH 0/6] Extensions of core.ignorecase=true support Johannes Sixt
2010-08-16 19:38 ` [PATCH 1/6] Add string comparison functions that respect the ignore_case variable Johannes Sixt
2010-08-18 12:52 ` Ævar Arnfjörð Bjarmason
2010-08-18 12:53 ` Ævar Arnfjörð Bjarmason
2010-08-18 15:52 ` Joshua Jensen
2010-08-18 16:07 ` Ævar Arnfjörð Bjarmason
2010-08-18 18:32 ` Johannes Sixt
2010-08-18 18:58 ` Ævar Arnfjörð Bjarmason
2010-08-29 19:39 ` Ævar Arnfjörð Bjarmason [this message]
2010-08-30 14:42 ` Joshua Jensen
2010-08-30 14:51 ` Ævar Arnfjörð Bjarmason
2010-08-30 15:05 ` Jonathan Nieder
2010-08-30 14:52 ` Jonathan Nieder
2010-08-30 18:40 ` Johannes Sixt
2010-08-30 19:57 ` Ævar Arnfjörð Bjarmason
2010-08-30 20:13 ` Johannes Sixt
2010-08-16 19:38 ` [PATCH 2/6] Case insensitivity support for .gitignore via core.ignorecase Johannes Sixt
2010-08-16 19:38 ` [PATCH 3/6] Add case insensitivity support for directories when using git status Johannes Sixt
2010-08-16 19:38 ` [PATCH 4/6] Add case insensitivity support when using git ls-files Johannes Sixt
2010-08-16 19:38 ` [PATCH 5/6] Support case folding for git add when core.ignorecase=true Johannes Sixt
2010-08-16 19:38 ` [PATCH 6/6] Support case folding in git fast-import " Johannes Sixt
2010-08-17 19:36 ` [PATCH 0/6] Extensions of core.ignorecase=true support Robert Buck
2010-08-17 21:20 ` Johannes Sixt
2010-08-18 2:41 ` Robert Buck
2010-08-18 18:31 ` Johannes Sixt
2010-08-22 7:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimtmudtWccRS==LrO_JrPmAJ7HzA6CU0ALbDZcV@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jjensen@workspacewhiz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).