From: Bo Yang <struggleyb.nku@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff.c: fix a graph output bug
Date: Sun, 11 Jul 2010 14:10:20 +0800 [thread overview]
Message-ID: <AANLkTimfQ3ZBCdz0aeDdpsWvcLrG-AxWoLYGCoa8zLi4@mail.gmail.com> (raw)
In-Reply-To: <7v1vbdo4j5.fsf@alter.siamese.dyndns.org>
Hi Junio,
On Fri, Jul 9, 2010 at 8:57 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Perhaps something like this?
>
> From: Bo Yang <struggleyb.nku@gmail.com>
> Date: Thu, 8 Jul 2010 23:12:34 +0800
> Subject: [PATCH] diff.c: fix a graph output bug
>
> When --graph is in effect, the line-prefix typically has colored graph
> line segments and ends with reset. The color sequence "set" given to
> this function is for showing the metainfo part of the patch text and
> (1) it should not be applied to the graph lines, and (2) it will be
> reset at the end of line_prefix so it won't be effect anyway.
>
> Signed-off-by: Bo Yang <struggleyb.nku@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> diff.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
> ...
>
Hmm, your description is great, thanks a lot! And please apply this
patch, thanks!
--
Regards!
Bo
----------------------------
My blog: http://blog.morebits.org
Why Git: http://www.whygitisbetterthanx.com/
prev parent reply other threads:[~2010-07-11 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 15:12 [PATCH] diff.c: fix a graph output bug struggleyb.nku
2010-07-09 0:15 ` Junio C Hamano
2010-07-09 0:57 ` Junio C Hamano
2010-07-09 1:04 ` Nazri Ramliy
2010-07-09 1:09 ` Junio C Hamano
2010-07-11 6:10 ` Bo Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimfQ3ZBCdz0aeDdpsWvcLrG-AxWoLYGCoa8zLi4@mail.gmail.com \
--to=struggleyb.nku@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).