From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jonathan Niedier <jrnieder@gmail.com>,
Kevin Ballard <kevin@sb.org>, Yann Dirson <dirson@bertin.fr>,
Jeff King <peff@peff.net>, Jakub Narebski <jnareb@gmail.com>,
Thiago Farina <tfransosi@gmail.com>
Subject: Re: [PATCH 1/3] get_sha1_oneline: do not leak or double free
Date: Mon, 13 Dec 2010 13:27:03 +0700 [thread overview]
Message-ID: <AANLkTimMb2ouZQbgOFB_JTuJb99vzC=2CzeUH3TnFU8M@mail.gmail.com> (raw)
In-Reply-To: <7vvd2y5h63.fsf@alter.siamese.dyndns.org>
2010/12/13 Junio C Hamano <gitster@pobox.com>:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> I think the following is easier to read and conveys what the code is
>> trying to do more clearly. No?
>
> This time with a proposed log message...
Much better. Thanks.
--
Duy
next prev parent reply other threads:[~2010-12-13 6:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 3:01 [PATCH 1/3] get_sha1_oneline: do not leak or double free Nguyễn Thái Ngọc Duy
2010-12-13 3:01 ` [PATCH 2/3] get_sha1_oneline: let callers initialize the commit tips for traverse Nguyễn Thái Ngọc Duy
2010-12-13 3:01 ` [PATCH 3/3] get_sha1: support ref^{/regex} syntax Nguyễn Thái Ngọc Duy
2010-12-13 3:10 ` Nguyen Thai Ngoc Duy
2010-12-13 4:40 ` Jonathan Nieder
2010-12-15 0:50 ` Junio C Hamano
2010-12-15 1:58 ` Nguyen Thai Ngoc Duy
2010-12-15 2:56 ` Junio C Hamano
2010-12-15 3:12 ` Nguyen Thai Ngoc Duy
2010-12-15 9:02 ` [PATCH] get_sha1: handle special case $commit^{/} Nguyễn Thái Ngọc Duy
2010-12-15 23:44 ` Junio C Hamano
2010-12-16 0:23 ` Nguyen Thai Ngoc Duy
2010-12-13 6:12 ` [PATCH 1/3] get_sha1_oneline: do not leak or double free Junio C Hamano
2010-12-13 6:19 ` Junio C Hamano
2010-12-13 6:27 ` Nguyen Thai Ngoc Duy [this message]
2010-12-13 6:31 ` Junio C Hamano
2010-12-13 6:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimMb2ouZQbgOFB_JTuJb99vzC=2CzeUH3TnFU8M@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=dirson@bertin.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
--cc=kevin@sb.org \
--cc=peff@peff.net \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).