From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Daniel Johnson <computerdruid@gmail.com>, mikachu <mikachu@gmail.com>
Cc: git <git@vger.kernel.org>, joey <joey@kitenet.net>
Subject: Re: [PATCH 1/3] clone: do not accept --depth on local clones
Date: Fri, 20 Aug 2010 08:15:19 +1000 [thread overview]
Message-ID: <AANLkTimHKc7y7ktAkAUffLzOtMGxqWO0i2nOWWuo4N9J@mail.gmail.com> (raw)
In-Reply-To: <201008191031.40230.ComputerDruid@gmail.com>
On Fri, Aug 20, 2010 at 12:31 AM, Daniel Johnson
<computerdruid@gmail.com> wrote:
> On Thursday 19 August 2010 06:40:35 you wrote:
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>> builtin/clone.c | 7 +++++--
>> 1 files changed, 5 insertions(+), 2 deletions(-)
> Can you make it a little clearer what the rationale is for this change? Why
> wouldn't you be able to do a limited-depth local clone? Seems like this
> would
> break some tests, and even if not, would prevent the writing of them.
It's been like this ever since and it puzzled me, "why 'git clone
--depth=2 ~/foo' did not work? What did I do?" Will do as Mikael
suggested.
--
Duy
next prev parent reply other threads:[~2010-08-19 22:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 0:49 fully deepening a shallow clone Joey Hess
2010-08-18 9:36 ` Nguyen Thai Ngoc Duy
2010-08-18 12:54 ` Daniel Johnson
2010-08-19 10:40 ` [PATCH 1/3] clone: do not accept --depth on local clones Nguyễn Thái Ngọc Duy
2010-08-19 14:31 ` Daniel Johnson
2010-08-19 22:15 ` Nguyen Thai Ngoc Duy [this message]
2010-08-19 20:49 ` Mikael Magnusson
2010-08-19 10:40 ` [PATCH 2/3] fetch-pack: use args.shallow to detect shallow clone instead of args.depth Nguyễn Thái Ngọc Duy
2010-08-19 10:40 ` [PATCH 3/3] {fetch,upload}-pack: allow --depth=0 to deepen into full repo again Nguyễn Thái Ngọc Duy
2010-08-19 21:22 ` Jakub Narebski
2010-08-19 22:11 ` Nguyen Thai Ngoc Duy
2010-08-20 9:22 ` Jakub Narebski
2010-08-20 9:28 ` Ramkumar Ramachandra
2010-08-20 11:55 ` [PATCH] grep -A/-B/-Cinfinity to get full context Jonathan Nieder
2010-08-20 13:32 ` Ramkumar Ramachandra
2010-08-18 15:48 ` fully deepening a shallow clone Joey Hess
-- strict thread matches above, loose matches on Subject: below --
2010-08-20 1:51 [PATCH 1/3] clone: do not accept --depth on local clones Nguyễn Thái Ngọc Duy
2010-08-21 0:27 ` Junio C Hamano
2010-08-22 22:43 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimHKc7y7ktAkAUffLzOtMGxqWO0i2nOWWuo4N9J@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=computerdruid@gmail.com \
--cc=git@vger.kernel.org \
--cc=joey@kitenet.net \
--cc=mikachu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).