From: Jonas Fonseca <fonseca@diku.dk>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Improve parent blame to detect renames by using the previous information
Date: Wed, 9 Jun 2010 12:10:12 -0400 [thread overview]
Message-ID: <AANLkTimGXAXg7fi3zKD3f-pIht0q0qYPp_6ivlt8LgDF@mail.gmail.com> (raw)
In-Reply-To: <20100606223545.GA11424@coredump.intra.peff.net>
On Sun, Jun 6, 2010 at 18:35, Jeff King <peff@peff.net> wrote:
>
> On Sat, Jun 05, 2010 at 03:56:05PM -0400, Jonas Fonseca wrote:
>
> One minor bug:
>
> > @@ -5204,10 +5148,13 @@ blame_request(struct view *view, enum request request, struct line *line)
> > break;
> >
> > case REQ_PARENT:
> > - if (check_blame_commit(blame, TRUE) &&
> > - select_commit_parent(blame->commit->id, opt_ref,
> > - blame->commit->filename)) {
> > - string_copy(opt_file, blame->commit->filename);
> > + if (!check_blame_commit(blame, TRUE))
> > + break;
> > + if (!*blame->commit->parent_id) {
> > + report("The selected commit has no parents");
> > + } else {
> > + string_copy_rev(opt_ref, blame->commit->parent_id);
> > + string_copy_rev(opt_file, blame->commit->parent_filename);
>
> This second string_copy_rev should be a string_ncopy, shouldn't it?
Oh, yes, a regular copy and paste bug. Thanks for noticing. I will
include this and consider tagging another release.
--
Jonas Fonseca
next prev parent reply other threads:[~2010-06-09 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 8:55 [tig PATCH] fix off-by-one on parent selection Jeff King
2010-05-22 17:19 ` Jonas Fonseca
2010-05-23 7:40 ` Jeff King
2010-05-23 7:55 ` Jeff King
2010-06-05 19:56 ` [PATCH] Improve parent blame to detect renames by using the previous information Jonas Fonseca
2010-06-05 19:57 ` [TIG PATCH] " Jonas Fonseca
2010-06-06 22:35 ` [PATCH] " Jeff King
2010-06-09 16:10 ` Jonas Fonseca [this message]
2010-06-10 2:23 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimGXAXg7fi3zKD3f-pIht0q0qYPp_6ivlt8LgDF@mail.gmail.com \
--to=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).