git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Add git format-patch produced patches to .gitignore
Date: Sun, 16 May 2010 13:06:25 +0000	[thread overview]
Message-ID: <AANLkTilsZ1Dzsu6GwWaNh8WvMrzpQtj5AQNDavdYuCjf@mail.gmail.com> (raw)
In-Reply-To: <20100516075244.GA9010@progeny.tock>

On Sun, May 16, 2010 at 07:52, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Pavan Kumar Sunkara wrote:
>> Ævar Arnfjörð Bjarmason wrote:
>
>>> --- a/.gitignore
>>> +++ b/.gitignore
>>> @@ -203,3 +203,4 @@
>>>  *.pdb
>>>  /Debug/
>>>  /Release/
>>> +[0-9][0-9][0-9][0-9]-*.patch
> [...]
>> git format-patch -M origin/master -o outgoing/
>>
>> So, my patches will be in subdirectory outgoing.
>> But the regex rule in this patch won't be able to hide them.
>>
>> What do u want to do in that case ?
>
> Try it out.

Right, patches in outgoing/ will be ignored too because the rule isn't
prefixed with /, so it works regardless of whether the file is in a
subdirectory or not.

> In fact, I was worried that this patch would trigger a similar
> problem: maybe some test data directory contains format-patch
> output?  In fact none do, so I like the patch.

None do, there's no file that matches '????-*.patch' in Git. Even if
there was you could still 'git add -f' it, which wouldn't be that big
of a problem because it would be part of some rarely touched test
suite in t/*.

  reply	other threads:[~2010-05-16 13:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-15 21:22 [PATCH] Add git format-patch produced patches to .gitignore Ævar Arnfjörð Bjarmason
2010-05-16  6:27 ` Pavan Kumar Sunkara
2010-05-16  7:52   ` Jonathan Nieder
2010-05-16 13:06     ` Ævar Arnfjörð Bjarmason [this message]
2010-05-16 14:05 ` Michael J Gruber
2010-05-17  1:35   ` Jonathan Nieder
2010-05-17  2:04     ` [PATCH] Remove editor-specific droppings from .gitignore Ævar Arnfjörð Bjarmason
2010-05-17  2:22   ` [PATCH] Add git format-patch produced patches to .gitignore Jonathan Nieder
2010-05-17  7:52     ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTilsZ1Dzsu6GwWaNh8WvMrzpQtj5AQNDavdYuCjf@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=pavan.sss1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).