git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC v8 0/2] Gettext support for Git
Date: Sat, 5 Jun 2010 21:35:29 +0000	[thread overview]
Message-ID: <AANLkTikvP6z4-AdbSJQYV5yo9UXKVh3lleFZ49_hmSZ5@mail.gmail.com> (raw)
In-Reply-To: <m3vd9xp3oz.fsf@localhost.localdomain>

On Sat, Jun 5, 2010 at 21:29, Jakub Narebski <jnareb@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> This is version 8 of the series to make Git optionally translatable
>> with GNU gettext.
>>
>> Changes since version 7:
> [...]
>
>>    * Add back support (and a new test) for the no-op N_() macro. This
>>      is used for marking translations for later use, e.g.:
>>
>>         const char help[] =
>>               N_("See 'git help COMMAND' for more information on a specific command.");
>>
>>         int main(void)
>>         {
>>             puts(_(help));
>
> Shouldn't you add also corresponding N__ subroutine to Git::I18N
> module?
>
>  # Dummy functions for string marking.
>  sub N__($) {
>        return shift;
>  }

I don't really see the need. It's very useful in C because you can't
call functions outside function bodies (like in the example
above). Perl has no such restriction, so I don't see the use case.

Can you think of one? Perhaps I'm just being unimaginative.

      reply	other threads:[~2010-06-05 21:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-05 21:12 [PATCH/RFC v8 0/2] Gettext support for Git Ævar Arnfjörð Bjarmason
2010-06-05 21:12 ` [PATCH/RFC v8 1/2] Add infrastructure for translating Git with gettext Ævar Arnfjörð Bjarmason
2010-06-05 21:12 ` [PATCH/RFC v8 2/2] Add initial C, Shell and Perl gettext translations Ævar Arnfjörð Bjarmason
2010-06-05 21:29 ` [PATCH/RFC v8 0/2] Gettext support for Git Jakub Narebski
2010-06-05 21:35   ` Ævar Arnfjörð Bjarmason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikvP6z4-AdbSJQYV5yo9UXKVh3lleFZ49_hmSZ5@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).