From: Greg Brockman <gdb@MIT.EDU>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>, Petr Baudis <pasky@suse.cz>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3] shell: Rewrite documentation and improve error message
Date: Tue, 24 Aug 2010 11:22:07 -0400 [thread overview]
Message-ID: <AANLkTikqoELMOxjdtzvrFTgyHK0dLCZLrwt2NhCSUDL5@mail.gmail.com> (raw)
In-Reply-To: <20100824123525.GA18641@kytes>
>> > - "hint: ~/$COMMAND_DIR should exist "
>> > + "hint: ~/" $COMMAND_DIR " should exist "
>> There's still a floating $. (Recall, you're in C land here, not shell.)
>
> Ugh. So sorry about this- I've been suffering from insomnia over the
> last few days.
No worries :).
> -- 8< --
> diff --git a/shell.c b/shell.c
> index 6aade3d..b539cdf 100644
> --- a/shell.c
> +++ b/shell.c
> @@ -154,7 +154,7 @@ int main(int argc, char **argv)
> cd_to_homedir();
> if (access(COMMAND_DIR, R_OK | X_OK) == -1) {
> die("Interactive git shell is not enabled.\n"
> - "hint: ~/" $COMMAND_DIR " should exist "
> + "hint: ~/" COMMAND_DIR " should exist "
> "and have read and execute access.");
> }
> run_shell();
LGTM.
Reviewed-by: Greg Brockman <gdb@mit.edu>
next prev parent reply other threads:[~2010-08-24 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 19:44 [PATCH] shell: Rewrite documentation and improve error message Ramkumar Ramachandra
2010-08-20 19:51 ` Ramkumar Ramachandra
2010-08-22 6:00 ` Greg Brockman
2010-08-22 8:04 ` [PATCH v2] " Ramkumar Ramachandra
2010-08-23 17:42 ` Greg Brockman
2010-08-24 5:36 ` [PATCH v3] " Ramkumar Ramachandra
2010-08-24 5:43 ` Greg Brockman
2010-08-24 12:35 ` Ramkumar Ramachandra
2010-08-24 15:22 ` Greg Brockman [this message]
2010-08-24 19:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikqoELMOxjdtzvrFTgyHK0dLCZLrwt2NhCSUDL5@mail.gmail.com \
--to=gdb@mit.edu \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).