From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: git@vger.kernel.org, judge.packham@gmail.co
Cc: Jens.Lehmann@web.de, "Junio C Hamano" <gitster@pobox.com>,
jrnieder@gmail.com, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH 2/2] worktree: provide better prefix to go back to original cwd
Date: Thu, 7 Oct 2010 12:53:33 +0700 [thread overview]
Message-ID: <AANLkTikQJDBsSg96DBohqGjgg+E4LUXU-F1a5DEyz0JU@mail.gmail.com> (raw)
In-Reply-To: <4cad50da.0e958e0a.40e3.5efd@mx.google.com>
On Thu, Oct 7, 2010 at 11:46 AM, <pclouds@gmail.com> wrote:
> + /* Worktree and cwd are on different drives? */
> + if (len == 3 && has_dos_drive_prefix(cwd)) {
> + if (startup_info) {
> + /* make_path_to_path will add the trailing slash */
> + startup_info->cwd_to_worktree = make_path_to_path(NULL, worktree);
> + startup_info->worktree_to_cwd = make_path_to_path(NULL, cwd);
> + }
> + return NULL;
> + }
Went for lunch and realized this code is just wrong. Gaahh..
--
Duy
next prev parent reply other threads:[~2010-10-07 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 4:46 [PATCH 2/2] worktree: provide better prefix to go back to original cwd pclouds
2010-10-07 5:53 ` Nguyen Thai Ngoc Duy [this message]
2010-10-07 5:54 ` Junio C Hamano
2010-10-07 7:20 ` Nguyen Thai Ngoc Duy
2010-10-07 14:56 ` Junio C Hamano
2010-10-07 15:11 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikQJDBsSg96DBohqGjgg+E4LUXU-F1a5DEyz0JU@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=judge.packham@gmail.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).