From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 1/3] Make test-lib.sh emit valid TAP format
Date: Mon, 14 Jun 2010 22:29:29 +0000 [thread overview]
Message-ID: <AANLkTik4Zxh5cKUEn1_yoNGKvNSudILvEVEAqeeElmB0@mail.gmail.com> (raw)
In-Reply-To: <m31vc9p93t.fsf@localhost.localdomain>
On Mon, Jun 14, 2010 at 22:01, Jakub Narebski <jnareb@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> TAP, the Test Anything Protocol, is a simple text-based interface
>> between testing modules in a test harness. test-lib.sh's output was
>> already very close to being valid TAP. This change brings it all the
>> way there. Before:
>>
>> $ ./t0005-signals.sh
>> * ok 1: sigchain works
>> * passed all 1 test(s)
>>
>> And after:
>>
>> $ ./t0005-signals.sh
>> ok 1 - sigchain works
>> # passed all 1 test(s)
>> 1..1
>
> How failing test looks like before and after the change?
>
> How test_expect_failure, i.e. known breakage (TODO test) looks like
> (both in known broken, and in accidentally fixed version) before and
> after the change?
>
> How does '--verbose' and '--debug' output looks like before and after
> the change?
I'll submit a version with an updated commit message. The gist of it:
* It's now ok/not ok instead of ok/failed
* --debug and --verbose work just like before
* Other things look like before, but may be changed to make TAP like
it (e.g. prefixing comments with #)
next prev parent reply other threads:[~2010-06-14 22:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 15:22 [PATCH v2 0/3] Make the Git tests emit TAP format Ævar Arnfjörð Bjarmason
2010-06-09 15:22 ` [PATCH v2 1/3] Make test-lib.sh emit valid " Ævar Arnfjörð Bjarmason
2010-06-14 22:01 ` Jakub Narebski
2010-06-14 22:29 ` Ævar Arnfjörð Bjarmason [this message]
2010-06-09 15:22 ` [PATCH v2 2/3] Skip tests in a way that makes sense under TAP Ævar Arnfjörð Bjarmason
2010-06-09 15:24 ` [PATCH v2 3/3] We use TAP so the Perl test can run without scaffolding Ævar Arnfjörð Bjarmason
2010-06-14 21:49 ` [PATCH v2 0/3] Make the Git tests emit TAP format Jakub Narebski
2010-06-14 22:10 ` Ævar Arnfjörð Bjarmason
2010-06-14 23:16 ` Ævar Arnfjörð Bjarmason
2010-06-15 3:08 ` Junio C Hamano
2010-06-15 3:10 ` Ævar Arnfjörð Bjarmason
2010-06-15 15:17 ` Ævar Arnfjörð Bjarmason
2010-06-15 16:42 ` Andreas Ericsson
2010-06-15 16:49 ` Ævar Arnfjörð Bjarmason
2010-06-15 22:32 ` [PATCH v3 0/5] TAP support for Git Ævar Arnfjörð Bjarmason
2010-06-15 22:32 ` [PATCH v3 1/5] Make test-lib.sh emit valid TAP format Ævar Arnfjörð Bjarmason
2010-06-15 22:32 ` [PATCH v3 2/5] Skip tests in a way that makes sense under TAP Ævar Arnfjörð Bjarmason
2010-06-15 22:32 ` [PATCH v3 3/5] We use TAP so the Perl test can run without scaffolding Ævar Arnfjörð Bjarmason
2010-06-15 22:32 ` [PATCH v3 4/5] TAP: Say "pass" rather than "ok" on an empty line Ævar Arnfjörð Bjarmason
2010-06-15 22:32 ` [PATCH v3 5/5] TAP: Make sure there's a newline before "ok" under harness Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik4Zxh5cKUEn1_yoNGKvNSudILvEVEAqeeElmB0@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).