From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Pat Thoyts <patthoyts@users.sourceforge.net>,
Tarmigan Casebolt <tarmigan+git@gmail.com>
Subject: Re: [PATCH] t/t5560: use `X=Y && export X' not `export X=Y'
Date: Thu, 7 Oct 2010 08:09:34 +0000 [thread overview]
Message-ID: <AANLkTi=cMYoLVipaiFajcssrRBVPX5NXFNwj21Ji3Lru@mail.gmail.com> (raw)
In-Reply-To: <vpqhbgy8mjj.fsf@bauges.imag.fr>
On Thu, Oct 7, 2010 at 07:55, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
> Ęvar Arnfjörš Bjarmason <avarab@gmail.com> writes:
>
>> Change t/t5560-http-backend-noserver.sh to use the `X=Y && export X'
>> style instead of `export X=Y'. The latter doesn't work on all POSIX
>> shells.
>
> According to
>
> git grep '\<export [A-Za-z_]*='
>
> there seem to be a couple of other instances of this.
Yeah, the ones in Documentation/*.txt are OK IMO. The users reading
the docs probably don't have a shell old enough to complain about
this.
Likewise for contrib/hg-to-git/hg-to-git.py and gitweb/INSTALL.
These we probably want to fix:
git-am.sh: export GIT_MERGE_VERBOSITY=0
git-rebase.sh: export GIT_MERGE_VERBOSITY=1
git-stash.sh: export GIT_MERGE_VERBOSITY=0
and maybe this:
git-gui/lib/shortcut.tcl: puts $fd
"export PATH=[sq [file dirname $::_git]]:\$PATH &&"
This is the only other thing in the test suite:
t/t1509-root-worktree.sh:export GIT_DIR="$TRASH_DIRECTORY/.git"
t/t1509-root-worktree.sh:export GIT_WORK_TREE=/
t/t1509-root-worktree.sh:export GIT_DIR="$(echo
$TRASH_DIRECTORY|sed 's,^/,,')/.git"
But I didn't touch that since nobody runs that test anyway, and if
they do having a strict POSIX shell is the least of their problems.
next prev parent reply other threads:[~2010-10-07 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 7:47 [PATCH] t/t5560: use `X=Y && export X' not `export X=Y' Ævar Arnfjörð Bjarmason
2010-10-07 7:55 ` Matthieu Moy
2010-10-07 8:09 ` Ævar Arnfjörð Bjarmason [this message]
2010-10-10 17:20 ` Clemens Buchacher
2010-10-13 18:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=cMYoLVipaiFajcssrRBVPX5NXFNwj21Ji3Lru@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=patthoyts@users.sourceforge.net \
--cc=tarmigan+git@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).