From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Yann Dirson <ydirson@altern.org>, git@vger.kernel.org
Subject: Re: [PATCH] compat: add memrchr()
Date: Fri, 15 Oct 2010 10:49:00 +0000 [thread overview]
Message-ID: <AANLkTi=YN41n-BnVNo3HsnxNxQNBX=Ev-upmM0N49uOZ@mail.gmail.com> (raw)
In-Reply-To: <20101015060654.GD21830@burratino>
On Fri, Oct 15, 2010 at 06:06, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>
>> Maybe something like this for configure.ac:
>>
>> AC_CHECK_LIB([c], [memchr],
>> [HAVE_MEMRCHR=YesPlease],
>> [HAVE_MEMRCHR=])
>> AC_SUBST(HAVE_MEMRCHR)
>>
>> And documentation with the other HAVE_* variables at the top of the
>> Makefile?
>
> Hmm, the BSDs and plan 9 have an memrchr() apparently. Any idea for
> taking advantage of that (the makefile support part) that's less ugly
> than this?
Check out my "Makefile & configure: add a NO_FNMATCH flag" and
"Makefile & configure: add a NO_FNMATCH_CASEFOLD flag" patches already
in pu.
Maybe it should be a NO_* flag since that's what we use when we expect
sanity, e.g. we have NO_REGEXP=, NO_CURL and NO_GETTEXT.
Then you just need NO_MEMRCHR=UnfortunatelyYes entries in the big
if/else block for those platforms that don't have it.
But memrchr() is a GNU extension so it should probably be a HAVE_*. I
don't know.
> If we miss a platform, that's no big deal. The 1-char-at-a-time
> loop is not so slow, and the "#define memrchr gitmemrchr" ensures
> that it would not conflict with the libc version.
Yup, probably best as a HAVE_*. In any case the autoconf probe I added
should work when memrchr is spelled properly.
next prev parent reply other threads:[~2010-10-15 10:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 23:29 [PATCH v6 0/5] Detection of directory renames Yann Dirson
2010-10-14 23:29 ` [PATCH v6 1/5] Introduce bulk-move detection in diffcore Yann Dirson
2010-10-14 23:29 ` [PATCH v6 2/5] Add testcases for the --detect-bulk-moves diffcore flag Yann Dirson
2010-10-14 23:29 ` [PATCH v6 3/5] [RFC] Handle the simpler case of a subdir invalidating bulk move Yann Dirson
2010-10-14 23:29 ` [PATCH v6 4/5] [RFC] Consider all parents of a file as candidates for bulk rename Yann Dirson
2010-10-14 23:29 ` [PATCH v6 5/5] [WIP] Allow hiding renames of individual files involved in a directory rename Yann Dirson
2010-10-17 19:24 ` [PATCH v6.1] [RFC] Consider all parents of a file as candidates for bulk rename Yann Dirson
2010-10-15 5:17 ` [PATCH] compat: add memrchr() Jonathan Nieder
2010-10-15 5:31 ` Ævar Arnfjörð Bjarmason
2010-10-15 6:06 ` Jonathan Nieder
2010-10-15 10:49 ` Ævar Arnfjörð Bjarmason [this message]
2010-10-15 22:27 ` Junio C Hamano
2010-10-15 6:57 ` Johannes Sixt
2010-10-15 8:56 ` Ludvig Strigeus
2010-10-15 15:26 ` [PATCH v2] " Jonathan Nieder
2010-10-15 8:56 ` [PATCH] " Erik Faye-Lund
2010-10-15 9:35 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=YN41n-BnVNo3HsnxNxQNBX=Ev-upmM0N49uOZ@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).