git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Michael Horowitz <michael.horowitz@ieee.org>
To: git <git@vger.kernel.org>
Subject: git-p4 issue
Date: Thu, 24 Feb 2011 16:12:31 -0500	[thread overview]
Message-ID: <AANLkTi=2evJB9Pffoo43bB6+qjUsG71t4o=pqHcu2Hzu@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=b60kqd6fRXzf39BBepLOeA3ts6EN3AuY0iAp4@mail.gmail.com>

Hello,

I ran into an issue with git-p4 and was given a fix described below by
someone assisting me, but I am not a Python developer...

...
By looking at the git-p4 code turns out that in the prepareLogMessage
function, everything between the Description and Files section of the
p4 change specification is skipped. The Jobs section happens to be
between Description and Files...

Good thing the fix is simple, in the prepareLogMessage function, just add this:

    if inDescriptionSection:
-       if line.startswith("Files:"):
+       if line.startswith("Files:") or line.startswith("Jobs:"):

And you should now see your jobs appear in the p4 change specification.
...

Given the simple nature of it, I was hoping someone could help get
this fixed in the main git distro.

-- 
Mike

       reply	other threads:[~2011-02-24 21:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTikXHJqmzZDv6NhujHqjUFva-uCRB3td306vi=WX@mail.gmail.com>
     [not found] ` <AANLkTi=b60kqd6fRXzf39BBepLOeA3ts6EN3AuY0iAp4@mail.gmail.com>
2011-02-24 21:12   ` Michael Horowitz [this message]
2011-04-15  3:00 git-p4 issue Michael Horowitz
2011-04-15 20:22 ` Tor Arvid Lund
2011-04-15 20:39   ` Michael Horowitz
2011-04-16 16:01     ` Pete Wyckoff
2011-04-18 12:59       ` Vitor Antunes
2011-04-19  3:57     ` Michael Horowitz
2011-04-19  9:59       ` Vitor Antunes
2011-04-20  0:31       ` Pete Wyckoff
2011-04-20  2:40         ` Michael Horowitz
2011-04-20 10:51           ` Vitor Antunes
2011-05-06 20:16           ` Michael Horowitz
2011-05-13 14:31             ` Vitor Antunes
2011-12-17  5:52               ` Michael Horowitz
  -- strict thread matches above, loose matches on Subject: below --
2023-03-16 17:28 Brent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=2evJB9Pffoo43bB6+qjUsG71t4o=pqHcu2Hzu@mail.gmail.com' \
    --to=michael.horowitz@ieee.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).