From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: stefan.naewe@atlas-elektronik.com, git@vger.kernel.org
Subject: Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it
Date: Thu, 22 Sep 2016 11:03:45 +0200 [thread overview]
Message-ID: <A1C0644E-095A-4903-AE86-72EAEFEB385B@gmail.com> (raw)
In-Reply-To: <xmqqzin19pbj.fsf@gitster.mtv.corp.google.com>
> On 21 Sep 2016, at 18:42, Junio C Hamano <gitster@pobox.com> wrote:
>
> Lars Schneider <larsxschneider@gmail.com> writes:
>
>>> On 21 Sep 2016, at 11:31, stefan.naewe@atlas-elektronik.com wrote:
>>>
>>> In the Subject: s/the //
>>>
>>> Am 21.09.2016 um 10:45 schrieb larsxschneider@gmail.com:
>>>> From: Lars Schneider <larsxschneider@gmail.com>
>>>>
>>>> The TravisCI macOS build is broken because homebrew (a macOS depedency
>>>
>>> s/depedency/dependency/
>>
>> Thanks for spotting both errors!
>>
>> @Junio: Should I make a v2?
>
> No. osx before_install stuff was in there since the very beginning,
> i.e. 522354d7 ("Add Travis CI support", 2015-11-27), so I guess this
> needs to go to maint-2.7 and upwards, but I guess we should discourage
> people to stay on an older maintenance track forever, so let's do
> this only for 'maint' and upwards.
Sound good to me.
Thank you,
Lars
Minor nit:
If still possible and no trouble for you please do
`s/the //` on the subject line of 72fa5cd29f2a9249462215109dbf41b4a6c0c768 (in PU)
prev parent reply other threads:[~2016-09-22 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 8:45 [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it larsxschneider
2016-09-21 9:31 ` stefan.naewe
2016-09-21 13:28 ` Lars Schneider
2016-09-21 16:42 ` Junio C Hamano
2016-09-22 9:03 ` Lars Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A1C0644E-095A-4903-AE86-72EAEFEB385B@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stefan.naewe@atlas-elektronik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).