From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Shumkin Subject: [PATCH v7 4/5] pretty: Add failing tests: --format output should honor logOutputEncoding Date: Wed, 26 Jun 2013 14:19:49 +0400 Message-ID: <9e83de68067be7548c0119d6e99caa905fab0c0f.1372240999.git.Alex.Crezoff@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexey Shumkin , Junio C Hamano To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Jun 26 12:20:29 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Urmpv-0002wu-1T for gcvg-git-2@plane.gmane.org; Wed, 26 Jun 2013 12:20:27 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752012Ab3FZKUW convert rfc822-to-quoted-printable (ORCPT ); Wed, 26 Jun 2013 06:20:22 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:35061 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843Ab3FZKUR (ORCPT ); Wed, 26 Jun 2013 06:20:17 -0400 Received: by mail-lb0-f175.google.com with SMTP id r10so1382157lbi.20 for ; Wed, 26 Jun 2013 03:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rarus.ru; s=google; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:in-reply-to:references:mime-version:content-type :content-transfer-encoding; bh=BUucWMI00a559xtTodVhkIC5xNW6H6q3P8C7VS5C3kc=; b=oMn4fRYO2UAkUN8Y6Dg0dXu7q6ATCfOwMSweFRRERtAUmXmhbfcsTq8E1kweuYf1iZ 9p/oOMCaimcEdC9Z3JJhP5z2uRJlpjZmstbT2qBPkhWTIXPciHiS6BDiRmMny2VBS6B1 zXfSXatKBH8/WnYbJerTlZd6stqBaKVv92aQ0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:in-reply-to:references:mime-version:content-type :content-transfer-encoding; bh=BUucWMI00a559xtTodVhkIC5xNW6H6q3P8C7VS5C3kc=; b=bNK2WPF9Y5q8lkAWYu697cyiBmDeN6OoRTxk/B87qXAuEvZUfM2aDrBPAwC9D3gLoM 2GNjgm6XEJFSlZaMvErFz4p+ngFxRBX2ejCOIIcfUwL32kBNp4Wrn4WYWEKdQXhZ1ElP aLr0XLXAFeXnR51J784EVkYu+infUizMxpcAmWg+cDmxB0EshYVVuXnj4R4Z4nPJjh4K YO6BQbJBnn4D6T8/EjWSJ37Zgd21zYT+Gc2kgSlItxoR5gHlrzaBxLJz3rkX9qgXBwk0 Ob8hoZP5ZJ07pKhm4ttwB5UrxcmaoahB6wUYL45l6QRadd1HDpxYFVftL1cAwWGM6raA yeOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:in-reply-to:references:mime-version:content-type :content-transfer-encoding:x-gm-message-state; bh=BUucWMI00a559xtTodVhkIC5xNW6H6q3P8C7VS5C3kc=; b=VCL+NimpQPuXf8ugfkKsmLGJ/DuI/Z8/4zrXmvIL6Qmybotw1gl0OhjxsbPxivxXWp 6PYuSiB5aEcBNXyWCY+ZvAYVyRZDomYMP5v9bQopV2yaycSQHMLVbDx1TRBxDUKvVrX0 B0z7ZOP72mTfqoQzo9++POThkZ476sWf1no6D5NSrmEZsUs3KjaSWHbbfgEQ8nEZwKlc e+eQzDaZvVEzAVd9hPdZZ6YLj2hc54Ch7xz86cpFNxpX27irmz65kyU+T9rx1Fv3ZmHP WNE9YpbhvKjsJa52pZbW7sA1ks1KJSSJvM7ORKHiAelSprsCJhy3+Ol9QCXwETj7Jy95 6fTw== X-Received: by 10.112.201.138 with SMTP id ka10mr1768482lbc.72.1372242015606; Wed, 26 Jun 2013 03:20:15 -0700 (PDT) Received: from localhost ([85.21.218.130]) by mx.google.com with ESMTPSA id c4sm10508273lae.7.2013.06.26.03.20.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 26 Jun 2013 03:20:14 -0700 (PDT) X-Mailer: git-send-email 1.8.3.1.15.g5c23c1e In-Reply-To: In-Reply-To: References: X-Gm-Message-State: ALoCoQmZBoEMpZnjkKiAJBlbT2H20p/pu8M+rZIGcSzJc0sZUj6BVLOlT33RDjZJiurhmlTHZjZ6 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: One can set an alias $ git config alias.lg "log --graph --pretty=3Dformat:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cd) %C(bold blue)<%an>%Creset' --abbrev-commit --date=3Dlocal" to see the log as a pretty tree (like *gitk* but in a terminal). However, log messages written in an encoding i18n.commitEncoding which = differs from terminal encoding are shown corrupted even when i18n.logOutputEnco= ding and terminal encoding are the same (e.g. log messages committed on a Cy= gwin box with Windows-1251 encoding seen on a Linux box with a UTF-8 encoding an= d vice versa). To simplify an example we can say the following two commands are expect= ed to give the same output to a terminal: $ git log --oneline --no-color $ git log --pretty=3Dformat:'%h %s' However, the former pays attention to i18n.logOutputEncoding configuration, while the latter does not when it formats "%s". The same corruption is true for $ git diff --submodule=3Dlog and $ git rev-list --pretty=3Dformat:%s HEAD and $ git reset --hard This patch adds failing tests for the next patch that fixes them. Signed-off-by: Alexey Shumkin --- t/t4041-diff-submodule-option.sh | 35 +++++---- t/t4205-log-pretty-formats.sh | 149 ++++++++++++++++++++++++-------= -------- t/t6006-rev-list-format.sh | 83 +++++++++++++++------- t/t7102-reset.sh | 29 +++++++- 4 files changed, 199 insertions(+), 97 deletions(-) diff --git a/t/t4041-diff-submodule-option.sh b/t/t4041-diff-submodule-= option.sh index 32d4a60..2a7877d 100755 --- a/t/t4041-diff-submodule-option.sh +++ b/t/t4041-diff-submodule-option.sh @@ -1,6 +1,7 @@ #!/bin/sh # # Copyright (c) 2009 Jens Lehmann, based on t7401 by Ping Yin +# Copyright (c) 2011 Alexey Shumkin (+ non-UTF-8 commit encoding tests= ) # =20 test_description=3D'Support for verbose submodule differences in git d= iff @@ -10,6 +11,9 @@ This test tries to verify the sanity of the --submodu= le option of git diff. =20 . ./test-lib.sh =20 +# String "added" in German (translated with Google Translate), encoded= in UTF-8, +# used in sample commit log messages in add_file() function below. +added=3D$(printf "hinzugef\303\274gt") add_file () { ( cd "$1" && @@ -19,7 +23,8 @@ add_file () { echo "$name" >"$name" && git add "$name" && test_tick && - git commit -m "Add $name" || exit + msg_added_iso88591=3D$(echo "Add $name ($added $name)" | iconv -f u= tf-8 -t iso-8859-1) && + git -c 'i18n.commitEncoding=3Diso-8859-1' commit -m "$msg_added_iso= 88591" done >/dev/null && git rev-parse --short --verify HEAD ) @@ -89,29 +94,29 @@ test_expect_success 'diff.submodule does not affect= plumbing' ' commit_file sm1 && head2=3D$(add_file sm1 foo3) =20 -test_expect_success 'modified submodule(forward)' ' +test_expect_failure 'modified submodule(forward)' ' git diff-index -p --submodule=3Dlog HEAD >actual && cat >expected <<-EOF && Submodule sm1 $head1..$head2: - > Add foo3 + > Add foo3 ($added foo3) EOF test_cmp expected actual ' =20 -test_expect_success 'modified submodule(forward)' ' +test_expect_failure 'modified submodule(forward)' ' git diff --submodule=3Dlog >actual && cat >expected <<-EOF && Submodule sm1 $head1..$head2: - > Add foo3 + > Add foo3 ($added foo3) EOF test_cmp expected actual ' =20 -test_expect_success 'modified submodule(forward) --submodule' ' +test_expect_failure 'modified submodule(forward) --submodule' ' git diff --submodule >actual && cat >expected <<-EOF && Submodule sm1 $head1..$head2: - > Add foo3 + > Add foo3 ($added foo3) EOF test_cmp expected actual ' @@ -138,25 +143,25 @@ head3=3D$( git rev-parse --short --verify HEAD ) =20 -test_expect_success 'modified submodule(backward)' ' +test_expect_failure 'modified submodule(backward)' ' git diff-index -p --submodule=3Dlog HEAD >actual && cat >expected <<-EOF && Submodule sm1 $head2..$head3 (rewind): - < Add foo3 - < Add foo2 + < Add foo3 ($added foo3) + < Add foo2 ($added foo2) EOF test_cmp expected actual ' =20 head4=3D$(add_file sm1 foo4 foo5) -test_expect_success 'modified submodule(backward and forward)' ' +test_expect_failure 'modified submodule(backward and forward)' ' git diff-index -p --submodule=3Dlog HEAD >actual && cat >expected <<-EOF && Submodule sm1 $head2...$head4: - > Add foo5 - > Add foo4 - < Add foo3 - < Add foo2 + > Add foo5 ($added foo5) + > Add foo4 ($added foo4) + < Add foo3 ($added foo3) + < Add foo2 ($added foo2) EOF test_cmp expected actual ' diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats= =2Esh index 73ba5e8..6b62da2 100755 --- a/t/t4205-log-pretty-formats.sh +++ b/t/t4205-log-pretty-formats.sh @@ -1,20 +1,43 @@ #!/bin/sh # # Copyright (c) 2010, Will Palmer +# Copyright (c) 2011, Alexey Shumkin (+ non-UTF-8 commit encoding test= s) # =20 test_description=3D'Test pretty formats' . ./test-lib.sh =20 +commit_msg() { + # String "initial. initial" partly in German (translated with Google = Translate), + # encoded in UTF-8, used as a commit log message below. + msg=3D$(printf "initial. anf\303\244nglich") + if test -n "$1" + then + msg=3D$(echo $msg | iconv -f utf-8 -t $1) + fi + if test -n "$2" -a -n "$3" + then + # cut string, replace cut part with two dots + # $2 - chars count from the beginning of the string + # $3 - "trailing" chars + # LC_ALL is set to make `sed` interpret "." as a UTF-8 char not a by= te + # as it does with C locale + msg=3D$(echo $msg | LC_ALL=3Den_US.UTF-8 sed -e "s/^\(.\{$2\}\)$3/\1= =2E./") + fi + echo $msg +} + test_expect_success 'set up basic repos' ' >foo && >bar && git add foo && test_tick && - git commit -m initial && + git config i18n.commitEncoding iso-8859-1 && + git commit -m "$(commit_msg iso-8859-1)" && git add bar && test_tick && - git commit -m "add bar" + git commit -m "add bar" && + git config --unset i18n.commitEncoding ' =20 test_expect_success 'alias builtin format' ' @@ -38,6 +61,20 @@ test_expect_success 'alias user-defined format' ' test_cmp expected actual ' =20 +test_expect_success 'alias user-defined tformat with %s (iso-8859-1 en= coding)' ' + git config i18n.logOutputEncoding iso-8859-1 && + git log --oneline >expected-s && + git log --pretty=3D"tformat:%h %s" >actual-s && + git config --unset i18n.logOutputEncoding && + test_cmp expected-s actual-s +' + +test_expect_failure 'alias user-defined tformat with %s (utf-8 encodin= g)' ' + git log --oneline >expected-s && + git log --pretty=3D"tformat:%h %s" >actual-s && + test_cmp expected-s actual-s +' + test_expect_success 'alias user-defined tformat' ' git log --pretty=3D"tformat:%h" >expected && git config pretty.test-alias "tformat:%h" && @@ -71,22 +108,22 @@ test_expect_success 'alias loop' ' test_must_fail git log --pretty=3Dtest-foo ' =20 -test_expect_success 'NUL separation' ' - printf "add bar\0initial" >expected && +test_expect_failure 'NUL separation' ' + printf "add bar\0$(commit_msg)" >expected && git log -z --pretty=3D"format:%s" >actual && test_cmp expected actual ' =20 -test_expect_success 'NUL termination' ' - printf "add bar\0initial\0" >expected && +test_expect_failure 'NUL termination' ' + printf "add bar\0$(commit_msg)\0" >expected && git log -z --pretty=3D"tformat:%s" >actual && test_cmp expected actual ' =20 -test_expect_success 'NUL separation with --stat' ' +test_expect_failure 'NUL separation with --stat' ' stat0_part=3D$(git diff --stat HEAD^ HEAD) && stat1_part=3D$(git diff-tree --no-commit-id --stat --root HEAD^) && - printf "add bar\n$stat0_part\n\0initial\n$stat1_part\n" >expected && + printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n" >expect= ed && git log -z --stat --pretty=3D"format:%s" >actual && test_i18ncmp expected actual ' @@ -94,7 +131,7 @@ test_expect_success 'NUL separation with --stat' ' test_expect_failure 'NUL termination with --stat' ' stat0_part=3D$(git diff --stat HEAD^ HEAD) && stat1_part=3D$(git diff-tree --no-commit-id --stat --root HEAD^) && - printf "add bar\n$stat0_part\n\0initial\n$stat1_part\n\0" >expected &= & + printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n0" >expec= ted && git log -z --stat --pretty=3D"tformat:%s" >actual && test_i18ncmp expected actual ' @@ -108,20 +145,20 @@ test_expect_success 'setup more commits' ' head4=3D$(git rev-parse --verify --short HEAD~3) ' =20 -test_expect_success 'left alignment formatting' ' - git log --pretty=3D"format:%<(40)%s" >actual && +test_expect_failure 'left alignment formatting' " + git log --pretty=3D'format:%<(40)%s' >actual && # complete the incomplete line at the end echo >>actual && qz_to_tab_space <<\EOF >expected && message two Z message one Z add bar Z -initial Z +$(commit_msg) Z EOF test_cmp expected actual -' +" =20 -test_expect_success 'left alignment formatting at the nth column' " +test_expect_failure 'left alignment formatting at the nth column' " git log --pretty=3D'format:%h %<|(40)%s' >actual && # complete the incomplete line at the end echo >>actual && @@ -129,77 +166,77 @@ test_expect_success 'left alignment formatting at= the nth column' " $head1 message two Z $head2 message one Z $head3 add bar Z -$head4 initial Z +$head4 $(commit_msg) Z EOF test_cmp expected actual " =20 -test_expect_success 'left alignment formatting with no padding' ' - git log --pretty=3D"format:%<(1)%s" >actual && +test_expect_failure 'left alignment formatting with no padding' " + git log --pretty=3D'format:%<(1)%s' >actual && # complete the incomplete line at the end echo >>actual && cat <<\EOF >expected && message two message one add bar -initial +$(commit_msg) EOF test_cmp expected actual -' +" =20 -test_expect_success 'left alignment formatting with trunc' ' - git log --pretty=3D"format:%<(10,trunc)%s" >actual && +test_expect_failure 'left alignment formatting with trunc' " + git log --pretty=3D'format:%<(10,trunc)%s' >actual && # complete the incomplete line at the end echo >>actual && qz_to_tab_space <<\EOF >expected && message .. message .. add bar Z -initial Z +$(commit_msg "" "8" ".\+$") EOF test_cmp expected actual -' +" =20 -test_expect_success 'left alignment formatting with ltrunc' ' - git log --pretty=3D"format:%<(10,ltrunc)%s" >actual && +test_expect_failure 'left alignment formatting with ltrunc' " + git log --pretty=3D'format:%<(10,ltrunc)%s' >actual && # complete the incomplete line at the end echo >>actual && qz_to_tab_space <<\EOF >expected && ..sage two ..sage one add bar Z -initial Z +$(commit_msg "" "0" ".\{11\}") EOF test_cmp expected actual -' +" =20 -test_expect_success 'left alignment formatting with mtrunc' ' - git log --pretty=3D"format:%<(10,mtrunc)%s" >actual && +test_expect_failure 'left alignment formatting with mtrunc' " + git log --pretty=3D'format:%<(10,mtrunc)%s' >actual && # complete the incomplete line at the end echo >>actual && qz_to_tab_space <<\EOF >expected && mess.. two mess.. one add bar Z -initial Z +$(commit_msg "" "4" ".\{11\}") EOF test_cmp expected actual -' +" =20 -test_expect_success 'right alignment formatting' ' - git log --pretty=3D"format:%>(40)%s" >actual && +test_expect_failure 'right alignment formatting' " + git log --pretty=3D'format:%>(40)%s' >actual && # complete the incomplete line at the end echo >>actual && qz_to_tab_space <<\EOF >expected && Z message two Z message one Z add bar -Z initial +Z $(commit_msg) EOF test_cmp expected actual -' +" =20 -test_expect_success 'right alignment formatting at the nth column' " +test_expect_failure 'right alignment formatting at the nth column' " git log --pretty=3D'format:%h %>|(40)%s' >actual && # complete the incomplete line at the end echo >>actual && @@ -207,38 +244,38 @@ test_expect_success 'right alignment formatting a= t the nth column' " $head1 message two $head2 message one $head3 add bar -$head4 initial +$head4 $(commit_msg) EOF test_cmp expected actual " =20 -test_expect_success 'right alignment formatting with no padding' ' - git log --pretty=3D"format:%>(1)%s" >actual && +test_expect_failure 'right alignment formatting with no padding' " + git log --pretty=3D'format:%>(1)%s' >actual && # complete the incomplete line at the end echo >>actual && cat <<\EOF >expected && message two message one add bar -initial +$(commit_msg) EOF test_cmp expected actual -' +" =20 -test_expect_success 'center alignment formatting' ' - git log --pretty=3D"format:%><(40)%s" >actual && +test_expect_failure 'center alignment formatting' " + git log --pretty=3D'format:%><(40)%s' >actual && # complete the incomplete line at the end echo >>actual && qz_to_tab_space <<\EOF >expected && Z message two Z Z message one Z Z add bar Z -Z initial Z +Z $(commit_msg) Z EOF test_cmp expected actual -' +" =20 -test_expect_success 'center alignment formatting at the nth column' " +test_expect_failure 'center alignment formatting at the nth column' " git log --pretty=3D'format:%h %><|(40)%s' >actual && # complete the incomplete line at the end echo >>actual && @@ -246,36 +283,36 @@ test_expect_success 'center alignment formatting = at the nth column' " $head1 message two Z $head2 message one Z $head3 add bar Z -$head4 initial Z +$head4 $(commit_msg) Z EOF test_cmp expected actual " =20 -test_expect_success 'center alignment formatting with no padding' ' - git log --pretty=3D"format:%><(1)%s" >actual && +test_expect_failure 'center alignment formatting with no padding' " + git log --pretty=3D'format:%><(1)%s' >actual && # complete the incomplete line at the end echo >>actual && cat <<\EOF >expected && message two message one add bar -initial +$(commit_msg) EOF test_cmp expected actual -' +" =20 -test_expect_success 'left/right alignment formatting with stealing' ' - git commit --amend -m short --author "long long long " &= & - git log --pretty=3D"format:%<(10,trunc)%s%>>(10,ltrunc)% an" >actual = && +test_expect_failure 'left/right alignment formatting with stealing' " + git commit --amend -m short --author 'long long long ' &= & + git log --pretty=3D'format:%<(10,trunc)%s%>>(10,ltrunc)% an' >actual = && # complete the incomplete line at the end echo >>actual && cat <<\EOF >expected && short long long long message .. A U Thor add bar A U Thor -initial A U Thor +$(commit_msg "" "8" ".\+$") A U Thor EOF test_cmp expected actual -' +" =20 test_done diff --git a/t/t6006-rev-list-format.sh b/t/t6006-rev-list-format.sh index cc1008d..c66a07f 100755 --- a/t/t6006-rev-list-format.sh +++ b/t/t6006-rev-list-format.sh @@ -1,34 +1,60 @@ #!/bin/sh =20 +# Copyright (c) 2009 Jens Lehmann +# Copyright (c) 2011 Alexey Shumkin (+ non-UTF-8 commit encoding tests= ) + test_description=3D'git rev-list --pretty=3Dformat test' =20 . ./test-lib.sh . "$TEST_DIRECTORY"/lib-terminal.sh =20 test_tick +# String "added" in German (translated with Google Translate), encoded= in UTF-8, +# used as a commit log message below. +added=3D$(printf "added (hinzugef\303\274gt) foo") +added_iso88591=3D$(echo "$added" | iconv -f utf-8 -t iso-8859-1) +# same but "changed" +changed=3D$(printf "changed (ge\303\244ndert) foo") +changed_iso88591=3D$(echo "$changed" | iconv -f utf-8 -t iso-8859-1) + test_expect_success 'setup' ' : >foo && git add foo && - git commit -m "added foo" && + git config i18n.commitEncoding iso-8859-1 && + git commit -m "$added_iso88591" && head1=3D$(git rev-parse --verify HEAD) && head1_short=3D$(git rev-parse --verify --short $head1) && tree1=3D$(git rev-parse --verify HEAD:) && tree1_short=3D$(git rev-parse --verify --short $tree1) && - echo changed >foo && - git commit -a -m "changed foo" && + echo "$changed" > foo && + git commit -a -m "$changed_iso88591" && head2=3D$(git rev-parse --verify HEAD) && head2_short=3D$(git rev-parse --verify --short $head2) && tree2=3D$(git rev-parse --verify HEAD:) && tree2_short=3D$(git rev-parse --verify --short $tree2) + git config --unset i18n.commitEncoding ' =20 -# usage: test_format name format_string expect.$1 - test_expect_success "format $1" " - git rev-list --pretty=3Dformat:'$2' master >output.$1 && - test_cmp expect.$1 output.$1 - " + name=3D"format $1" + command=3D"git rev-list --pretty=3Dformat:'$2' master >output.$1 && + test_cmp expect.$1 output.$1" + if test $must_fail -eq 1 + then + test_expect_failure "$name" "$command" + else + test_expect_success "$name" "$command" + fi } =20 # Feed to --format to provide predictable colored sequences. @@ -110,14 +136,16 @@ EOF =20 test_format encoding %e <commit-msg <<'EOF' +iconv -f utf-8 -t iso8859-1 > commit-msg <foo && git commit -a -F commit-msg && head3=3D$(git rev-parse --verify HEAD) && - head3_short=3D$(git rev-parse --short $head3) + head3_short=3D$(git rev-parse --short $head3) && + # unset commit encoding config + # otherwise %e does not print encoding value + # and following test fails + git config --unset i18n.commitEncoding + ' =20 test_format complex-encoding %e <actual && - test $(wc -w actual && - test $(wc -w first && @@ -28,7 +39,7 @@ test_expect_success 'creating initial files and commi= ts' ' =20 echo "1st line 2nd file" >secondfile && echo "2nd line 2nd file" >>secondfile && - git commit -a -m "modify 2nd file" && + git -c "i18n.commitEncoding=3Diso-8859-1" commit -a -m "$(commit_msg = iso-8859-1)" && head5=3D$(git rev-parse --verify HEAD) ' # git log --pretty=3Doneline # to see those SHA1 involved @@ -44,6 +55,20 @@ check_changes () { done | test_cmp .cat_expect - } =20 +test_expect_failure 'reset --hard message' ' + hex=3D$(git log -1 --format=3D"%h") && + git reset --hard > .actual && + echo HEAD is now at $hex $(commit_msg) > .expected && + test_cmp .expected .actual +' + +test_expect_success 'reset --hard message (iso-8859-1 logoutencoding)'= ' + hex=3D$(git log -1 --format=3D"%h") && + git -c "i18n.logOutputEncoding=3Diso-8859-1" reset --hard > .actual &= & + echo HEAD is now at $hex $(commit_msg iso-8859-1) > .expected && + test_cmp .expected .actual +' + >.diff_expect >.cached_expect cat >.cat_expect <secondfile && echo "2nd line 2nd file" >>secondfile && - git commit -a -m "modify 2nd file" && + git -c "i18n.commitEncoding=3Diso-8859-1" commit -a -m "$(commit_msg = iso-8859-1)" && check_changes $head5 ' =20 --=20 1.8.3.1.15.g5c23c1e