git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Joakim Petersen <joak-pet@online.no>
To: Felipe Contreras <felipe.contreras@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Justin Donnelly <justinrdonnelly@gmail.com>
Subject: Re: [PATCH try2] completion: prompt: use generic colors
Date: Thu, 16 Mar 2023 15:11:06 +0100	[thread overview]
Message-ID: <9e317aa7-0037-7076-e159-3a70c581ebc1@online.no> (raw)
In-Reply-To: <CAMP44s23cvp-YWDN7vzsKQCcWoc43PgURq+J6pwtx0rxOpZLBg@mail.gmail.com>

On 01/03/2023 21:27, Felipe Contreras wrote:
>>> We don't need bash to do this conversion, we can use \001 \002
>>> ourselves, and then the prompt command mode is not necessary to display
>>> colors.
> 
>> Comments from those who use colored prompt and who are familiar with
>> the mechansim used to implement this?  As I do not use the feature
>> at all and haven't been following it, seeing independent support
>> would help the topic.
> 
> At least in try1 Justin Donnelly reported success [1].

I've played around a bit with this patch, and it seems to work as 
advertised.


  reply	other threads:[~2023-03-16 14:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 14:59 [PATCH try2] completion: prompt: use generic colors Felipe Contreras
2023-03-01 19:34 ` Junio C Hamano
2023-03-01 20:27   ` Felipe Contreras
2023-03-16 14:11     ` Joakim Petersen [this message]
2023-03-16 23:00       ` Junio C Hamano
2023-03-16 23:21         ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e317aa7-0037-7076-e159-3a70c581ebc1@online.no \
    --to=joak-pet@online.no \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=justinrdonnelly@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).