git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Andrew Janke <floss@apjanke.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: gettext, multiple Preferred languages, and English
Date: Sun, 21 Apr 2019 20:57:27 -0400	[thread overview]
Message-ID: <9d7a2fb4-8bab-2d28-1066-fbace688a5cc@apjanke.net> (raw)
In-Reply-To: <CACsJy8C1w0zJm71KFb21MC+c2NAGnRLDtE3KNK21hO7U4Ax7Hg@mail.gmail.com>



On 4/21/19 8:35 PM, Duy Nguyen wrote:
> On Sun, Apr 21, 2019 at 6:40 PM Andrew Janke <floss@apjanke.net> wrote:
>>
>> Hi, Git folks,
>>
>> This is a follow-up to https://marc.info/?l=git&m=154757938429747&w=2.
> 
> This says the problem with "en" detection has been fixed. Would
> upgrading gettext fix it?
> 
> You would need to upgrade something (git or gettext) and if it's
> already fixed in gettext I don't see why we need a workaround in git.

From reading the bug report, that does sound like it would fix it. But
from what I can see, that fix hasn't made it out into a released version
of gettext yet. I haven't downloaded the development gettext to confirm
the fix.

Looking at the gettext ftp site at https://ftp.gnu.org/pub/gnu/gettext/,
it looks like gettext does not make frequent releases, and the last
release was two and a half years ago. Who knows when the next release
will be. And then it'll take longer to trickle down into Linux
distributions and such.

From your release history at https://github.com/git/git/releases, it
seems like Git is a lot more active in making releases than gettext. So
including this fix in Git would get it into the hands of affected users
sooner. And it seems like a pretty low-risk change to me.

Then once the new gettext release is out, their fix is confirmed, and it
makes it out into common distros, the workaround could be removed from Git.

Cheers,
Andrew

  reply	other threads:[~2019-04-22  0:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-21 11:08 gettext, multiple Preferred languages, and English Andrew Janke
2019-04-21 12:59 ` Philip Oakley
2019-04-21 13:27   ` Andrew Janke
2019-04-22  1:33     ` Andrew Janke
2019-04-21 23:44   ` Junio C Hamano
2019-04-22  0:35 ` Duy Nguyen
2019-04-22  0:57   ` Andrew Janke [this message]
2019-04-22 17:47     ` Ævar Arnfjörð Bjarmason
2019-04-23 11:45       ` Andrew Janke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d7a2fb4-8bab-2d28-1066-fbace688a5cc@apjanke.net \
    --to=floss@apjanke.net \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).