From: "Garima Singh via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: garimasigit@gmail.com, jeffhost@microsoft.com, stolee@gmail.com,
Junio C Hamano <gitster@pobox.com>,
Garima Singh <garima.singh@microsoft.com>
Subject: [PATCH 1/1] quote: handle null and empty strings in sq_quote_buf_pretty()
Date: Tue, 20 Aug 2019 12:35:01 -0700 (PDT) [thread overview]
Message-ID: <9d2685bdb2e193986bec8cad88795963977d41fe.1566329700.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.314.git.gitgitgadget@gmail.com>
From: Garima Singh <garima.singh@microsoft.com>
In [1], Junio described a potential bug in sq_quote_buf_pretty() when the arg
is a zero length string. It should emit quote-quote rather than nothing.
This commit teaches sq_quote_buf_pretty to emit '' for null and empty strings.
[1] https://public-inbox.org/git/pull.298.git.gitgitgadget@gmail.com/T/#m9e33936067ec2066f675aa63133a2486efd415fd
Signed-off-by: Garima Singh <garima.singh@microsoft.com>
---
Makefile | 1 +
quote.c | 9 +++++++
t/helper/test-quote.c | 28 +++++++++++++++++++++
t/helper/test-tool.c | 1 +
t/helper/test-tool.h | 1 +
t/t0091-quote.sh | 58 +++++++++++++++++++++++++++++++++++++++++++
6 files changed, 98 insertions(+)
create mode 100644 t/helper/test-quote.c
create mode 100755 t/t0091-quote.sh
diff --git a/Makefile b/Makefile
index f9255344ae..2d6a12db57 100644
--- a/Makefile
+++ b/Makefile
@@ -728,6 +728,7 @@ TEST_BUILTINS_OBJS += test-parse-options.o
TEST_BUILTINS_OBJS += test-path-utils.o
TEST_BUILTINS_OBJS += test-pkt-line.o
TEST_BUILTINS_OBJS += test-prio-queue.o
+TEST_BUILTINS_OBJS += test-quote.o
TEST_BUILTINS_OBJS += test-reach.o
TEST_BUILTINS_OBJS += test-read-cache.o
TEST_BUILTINS_OBJS += test-read-midx.o
diff --git a/quote.c b/quote.c
index 7f2aa6faa4..84f61380fc 100644
--- a/quote.c
+++ b/quote.c
@@ -48,6 +48,15 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src)
static const char ok_punct[] = "+,-./:=@_^";
const char *p;
+ /*
+ * In case of null or empty tokens, add a '' to ensure we
+ * don't inadvertently drop those tokens
+ */
+ if (!src || !*src) {
+ strbuf_addstr(dst, "''");
+ return;
+ }
+
for (p = src; *p; p++) {
if (!isalpha(*p) && !isdigit(*p) && !strchr(ok_punct, *p)) {
sq_quote_buf(dst, src);
diff --git a/t/helper/test-quote.c b/t/helper/test-quote.c
new file mode 100644
index 0000000000..0266cc4fec
--- /dev/null
+++ b/t/helper/test-quote.c
@@ -0,0 +1,28 @@
+#include "test-tool.h"
+#include "quote.h"
+#include "strbuf.h"
+#include "string.h"
+
+int cmd__quote_buf_pretty(int argc, const char **argv)
+{
+ struct strbuf buf_payload = STRBUF_INIT;
+
+ if (!argv[1]) {
+ strbuf_release(&buf_payload);
+ die("missing input string");
+ }
+
+ if (!strcmp(argv[1], "nullString"))
+ sq_quote_buf_pretty(&buf_payload, NULL);
+
+ else if (!*argv[1])
+ sq_quote_buf_pretty(&buf_payload, "");
+
+ else
+ sq_quote_buf_pretty(&buf_payload, argv[1]);
+
+ /* Wrap the results in [] to make the test script more readable */
+ printf("[%s]\n", buf_payload.buf);
+ strbuf_release(&buf_payload);
+ return 0;
+}
diff --git a/t/helper/test-tool.c b/t/helper/test-tool.c
index ce7e89028c..55ee1402dd 100644
--- a/t/helper/test-tool.c
+++ b/t/helper/test-tool.c
@@ -56,6 +56,7 @@ static struct test_cmd cmds[] = {
{ "sha1-array", cmd__sha1_array },
{ "sha256", cmd__sha256 },
{ "sigchain", cmd__sigchain },
+ { "quote-buf-pretty", cmd__quote_buf_pretty },
{ "strcmp-offset", cmd__strcmp_offset },
{ "string-list", cmd__string_list },
{ "submodule-config", cmd__submodule_config },
diff --git a/t/helper/test-tool.h b/t/helper/test-tool.h
index f805bb39ae..8c0affe89c 100644
--- a/t/helper/test-tool.h
+++ b/t/helper/test-tool.h
@@ -46,6 +46,7 @@ int cmd__sha1(int argc, const char **argv);
int cmd__sha1_array(int argc, const char **argv);
int cmd__sha256(int argc, const char **argv);
int cmd__sigchain(int argc, const char **argv);
+int cmd__quote_buf_pretty(int argc, const char **argv);
int cmd__strcmp_offset(int argc, const char **argv);
int cmd__string_list(int argc, const char **argv);
int cmd__submodule_config(int argc, const char **argv);
diff --git a/t/t0091-quote.sh b/t/t0091-quote.sh
new file mode 100755
index 0000000000..a5515973c7
--- /dev/null
+++ b/t/t0091-quote.sh
@@ -0,0 +1,58 @@
+#!/bin/sh
+
+test_description='Testing the sq_quote_buf_pretty method in quote.c'
+. ./test-lib.sh
+
+test_expect_success 'test method without input string' '
+ test_must_fail test-tool quote-buf-pretty
+'
+
+test_expect_success 'test null string' '
+ cat >expect <<-EOF &&
+ '[\'\']'
+ EOF
+ test-tool quote-buf-pretty nullString >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'test empty string' '
+ cat >expect <<-EOF &&
+ '[\'\']'
+ EOF
+ test-tool quote-buf-pretty "" >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'string without any punctuation' '
+ cat >expect <<-EOF &&
+ [testString]
+ EOF
+ test-tool quote-buf-pretty testString >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'string with punctuation that do not require special quotes' '
+ cat >expect <<-EOF &&
+ [test+String]
+ EOF
+ test-tool quote-buf-pretty test+String >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'string with punctuation that requires special quotes' '
+ cat >expect <<-EOF &&
+ '[\'test~String\']'
+ EOF
+ test-tool quote-buf-pretty test~String >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'string with punctuation that requires special quotes' '
+ cat >expect <<-EOF &&
+ '[\'test\'\\!\'String\']'
+ EOF
+ test-tool quote-buf-pretty test!String >actual &&
+ test_cmp expect actual
+'
+
+test_done
--
gitgitgadget
next prev parent reply other threads:[~2019-08-20 19:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 19:35 [PATCH 0/1] quote: handle null and empty strings in sq_quote_buf_pretty() Garima Singh via GitGitGadget
2019-08-20 19:35 ` Garima Singh via GitGitGadget [this message]
2019-08-20 20:29 ` [PATCH 1/1] " Junio C Hamano
2019-08-21 15:22 ` Junio C Hamano
2019-08-20 20:32 ` Junio C Hamano
2019-08-26 14:44 ` [PATCH v2 0/1] " Garima Singh via GitGitGadget
2019-08-26 14:44 ` [PATCH v2 1/1] " Garima Singh via GitGitGadget
2019-08-26 15:24 ` Garima Singh
2019-08-26 16:20 ` Junio C Hamano
2019-10-07 16:17 ` [PATCH v3 0/1] " Garima Singh via GitGitGadget
2019-10-07 16:17 ` [PATCH v3 1/1] quote: handle numm and empty strings in sq_quote_buf_pretty Garima Singh via GitGitGadget
2019-10-07 17:08 ` Garima Singh
2019-10-07 17:27 ` Eric Sunshine
2019-10-07 17:47 ` Garima Singh
2019-10-07 19:38 ` [PATCH v4 0/1] quote: handle null and empty strings in sq_quote_buf_pretty() Garima Singh via GitGitGadget
2019-10-07 19:38 ` [PATCH v4 1/1] sq_quote_buf_pretty: don't drop empty arguments Garima Singh via GitGitGadget
2019-10-08 3:16 ` Junio C Hamano
2019-10-08 16:40 ` [PATCH v5 0/1] quote: handle null and empty strings in sq_quote_buf_pretty() Garima Singh via GitGitGadget
2019-10-08 16:40 ` [PATCH v5 1/1] sq_quote_buf_pretty: don't drop empty arguments Garima Singh via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d2685bdb2e193986bec8cad88795963977d41fe.1566329700.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=garima.singh@microsoft.com \
--cc=garimasigit@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).