From: William Baker <williamtbakeremail@gmail.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>,
"William Baker via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, stolee@gmail.com,
Johannes.Schindelin@gmx.de, jeffhost@microsoft.com,
Junio C Hamano <gitster@pobox.com>,
William Baker <William.Baker@microsoft.com>
Subject: Re: [PATCH v2 1/1] fsmonitor: don't fill bitmap with entries to be removed
Date: Fri, 11 Oct 2019 09:38:41 -0700 [thread overview]
Message-ID: <9c012ff1-182b-d71b-cd50-9c476f26748c@gmail.com> (raw)
In-Reply-To: <20191010112204.GK29845@szeder.dev>
On 10/10/19 4:22 AM, SZEDER Gábor wrote:
>>> +# This test covers staging/unstaging files that appear at the end of the index.
>>> +# Test files with names beginning with 'z' are used under the assumption that
>>> +# earlier tests do not add/leave index entries that sort below them.
>
> I just read through Junio's comments on the first version of this
> patch, in particular his remarks about this comment.
>
> If this new test case below were run in a dedicated repository, then
> this comment wouldn't be necessary, and all my comments below about
> that not-really-initial commit would be moot, too.
>
Thanks for this suggestion! I will submit a v3 version of the patch
with an update to the test script.
- William
next prev parent reply other threads:[~2019-10-11 16:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 19:49 [PATCH 0/1] fsmonitor: don't fill bitmap with entries to be removed William Baker via GitGitGadget
2019-10-03 19:49 ` [PATCH 1/1] " William Baker via GitGitGadget
2019-10-03 23:36 ` Junio C Hamano
2019-10-07 18:10 ` William Baker
2019-10-03 21:08 ` [PATCH 0/1] " Johannes Schindelin
2019-10-03 23:17 ` Junio C Hamano
2019-10-09 21:00 ` [PATCH v2 " William Baker via GitGitGadget
2019-10-09 21:00 ` [PATCH v2 1/1] " William Baker via GitGitGadget
2019-10-10 11:07 ` SZEDER Gábor
2019-10-10 11:22 ` SZEDER Gábor
2019-10-11 16:38 ` William Baker [this message]
2019-10-10 1:56 ` [PATCH v2 0/1] " Junio C Hamano
2019-10-10 12:02 ` Johannes Schindelin
2019-10-11 20:11 ` [PATCH v3 " William Baker via GitGitGadget
2019-10-11 20:11 ` [PATCH v3 1/1] " William Baker via GitGitGadget
2019-10-12 1:26 ` Junio C Hamano
2019-10-15 19:07 ` William Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c012ff1-182b-d71b-cd50-9c476f26748c@gmail.com \
--to=williamtbakeremail@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=William.Baker@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).