From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] Documentation/Makefile: conditionally include doc.dep
Date: Tue, 8 Dec 2020 22:19:36 +0000 [thread overview]
Message-ID: <9bc6dc79-7c15-b0c3-e765-7fd0d1c1a81b@ramsayjones.plus.com> (raw)
In-Reply-To: <CAMP44s1eb7O+bYXFyYm7BLCP37r1k80XY4MOC8RRL4nY61CMDQ@mail.gmail.com>
On 07/12/2020 03:18, Felipe Contreras wrote:
> On Sun, Dec 6, 2020 at 6:35 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
[snip commit message]
>
> All this makes sense, but I had to do "make doc.dep" and take a look
> at that file to understand why:
>
> doc.dep contains make rules with targets and dependencies that will
> not be used in "make clean".
>
> This is in my opinion the important information. Maybe mention
> something like that in the commit message?
Yep, Junio made a similar comment. v3 comming soon ... :-D
ATB,
Ramsay Jones
next prev parent reply other threads:[~2020-12-08 22:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 0:31 [PATCH v2 1/5] Documentation/Makefile: conditionally include doc.dep Ramsay Jones
2020-12-07 3:18 ` Felipe Contreras
2020-12-08 22:19 ` Ramsay Jones [this message]
2020-12-07 7:44 ` Junio C Hamano
2020-12-08 22:25 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bc6dc79-7c15-b0c3-e765-7fd0d1c1a81b@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).