From: "Robert Anderson" <rwa000@gmail.com>
To: "Jakub Narebski" <jnareb@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] improve doc heading for git-bisect
Date: Sat, 7 Jun 2008 09:06:19 -0700 [thread overview]
Message-ID: <9af502e50806070906u63e52de4wa0bc4dced0c4d984@mail.gmail.com> (raw)
In-Reply-To: <m37id1y4zj.fsf@localhost.localdomain>
On Sat, Jun 7, 2008 at 2:22 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> rwa000@gmail.com (Robert Anderson) writes:
>
>> From 7af03a835b7311c501f2147e25f428642fc3acb7 Mon Sep 17 00:00:00 2001
>
> FYI this line is not necessary, and should be removed from
> git-format-patch output when pasting it to your MUA.
Err, then shouldn't it be removed from format-patch, rather than
deleted manually every time format-patch is used?
>> From: Robert W. Anderson <rwa000@gmail.com>
>> Date: Fri, 6 Jun 2008 23:53:37 -0700
>> Subject: [PATCH] improve doc heading for git-bisect
>
> FYI the above isn't strictly necessary: if you have 'From:' header set
> correctly you can simply set subject of email, and put in body the
> rest of commit message and patch only, without extra mail-like
> headers.
Then remove them from format-patch, IMO.
>> Improve awkward heading in git-bisect documentation.
> [...]
>> -Avoiding to test a commit
>> -~~~~~~~~~~~~~~~~~~~~~~~~~
>> +Changing the revision to test
>> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> If in a middle of bisect session, you know what the bisect suggested
>> to try next is not a good one to test (e.g. the change the commit
>
> It is, I guess, better, but is it the best heading? What we want to
> describe here is how to deal when bisect stops on commit which cannot
> be tested (e.g. project does not compile).
I disagree. The situation you want to use this is more general than
that. Maybe you could test it, but doing so would be a waste of time
because the commit is a trivial comment change. In general, this
simply what you need to know when you want to change the revision
under test.
Bob
next prev parent reply other threads:[~2008-06-07 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-07 7:06 [PATCH] improve doc heading for git-bisect Robert Anderson
2008-06-07 9:22 ` Jakub Narebski
2008-06-07 16:06 ` Robert Anderson [this message]
2008-06-07 16:25 ` Jakub Narebski
2008-06-07 17:47 ` Junio C Hamano
2008-06-08 4:35 ` Jeff King
2008-06-08 15:01 ` Johannes Schindelin
2008-06-08 21:27 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9af502e50806070906u63e52de4wa0bc4dced0c4d984@mail.gmail.com \
--to=rwa000@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).