From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 90F411F463 for ; Wed, 18 Dec 2019 22:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbfLRWpF (ORCPT ); Wed, 18 Dec 2019 17:45:05 -0500 Received: from smtp.hosts.co.uk ([85.233.160.19]:25022 "EHLO smtp.hosts.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbfLRWpF (ORCPT ); Wed, 18 Dec 2019 17:45:05 -0500 Received: from [92.30.123.115] (helo=[192.168.1.22]) by smtp.hosts.co.uk with esmtpa (Exim) (envelope-from ) id 1ihi3z-0006Xp-58; Wed, 18 Dec 2019 22:45:03 +0000 Subject: Re: [PATCH 1/1] config: allow user to know scope of config options To: Matthew Rogers via GitGitGadget , git@vger.kernel.org Cc: Matthew Rogers , Junio C Hamano References: From: Philip Oakley Message-ID: <9a91caa0-72c3-3a38-3eb7-55a43537762e@iee.email> Date: Wed, 18 Dec 2019 22:45:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Matthew, On 18/12/2019 01:11, Matthew Rogers via GitGitGadget wrote: > From: Matthew Rogers > > Add new option --show-scope which allows a user to know what the scope > of listed config options are (local/global/system/etc.). > > Signed-off-by: Matthew Rogers > --- > builtin/config.c | 60 ++++++++++++++++++++++++++++++++++++++++------- > t/t1300-config.sh | 51 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 103 insertions(+), 8 deletions(-) Doesn't this also need a man page update as well for adding the option to the synopsis. The commit message doesn't fully highlight that the config list will often be all the users config values, so each value will be disambiguated/identified as to it's origin. Philip