* [PATCH v4] send-email: --batch-size to work around some SMTP server limit
@ 2017-05-13 1:57 xiaoqiang zhao
2017-05-15 3:59 ` Junio C Hamano
2017-05-16 12:10 ` Jan Viktorin
0 siblings, 2 replies; 8+ messages in thread
From: xiaoqiang zhao @ 2017-05-13 1:57 UTC (permalink / raw
To: git; +Cc: gitster, viktorin, mst, pbonzini, mina86, artagnon, avarab
Some email servers (e.g. smtp.163.com) limit the number emails to be
sent per session(connection) and this will lead to a faliure when
sending many messages.
Teach send-email to disconnect after sending a number of messages
(configurable via the --batch-size=<num> option), wait for a few
seconds (configurable via the --relogin-delay=<seconds> option) and
reconnect, to work around such a limit.
Also add this two configure option for git config command.
Note:
Re-authentication will happen every $<batch-size> messages, so it
will be much more acceptable if you use some form of credential helper
(e.g. the 'sendemail.smtppass' config option), otherwise you will have
to retype password every time when asked.
Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
---
contrib/completion/git-completion.bash | 2 ++
git-send-email.perl | 18 ++++++++++++++++++
2 files changed, 20 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index af658995d..29496353a 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2608,6 +2608,8 @@ _git_config ()
sendemail.thread
sendemail.to
sendemail.validate
+ sendemail.smtpbatchsize
+ sendemail.smtprelogindelay
showbranch.default
status.relativePaths
status.showUntrackedFiles
diff --git a/git-send-email.perl b/git-send-email.perl
index eea0a517f..071d1ab9d 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -81,6 +81,10 @@ git send-email --dump-aliases
This setting forces to use one of the listed mechanisms.
--smtp-debug <0|1> * Disable, enable Net::SMTP debug.
+ --batch-size <int> * send max <int> message per connection.
+ --relogin-delay <int> * delay <int> seconds between two successive login, default to 1,
+ This option can only be used with --batch-size
+
Automating:
--identity <str> * Use the sendemail.<id> options.
--to-cmd <str> * Email To: via `<str> \$patch_path`
@@ -153,6 +157,7 @@ my $have_email_valid = eval { require Email::Valid; 1 };
my $have_mail_address = eval { require Mail::Address; 1 };
my $smtp;
my $auth;
+my $num_sent = 0;
# Regexes for RFC 2047 productions.
my $re_token = qr/[^][()<>@,;:\\"\/?.= \000-\037\177-\377]+/;
@@ -216,6 +221,7 @@ my ($cover_cc, $cover_to);
my ($to_cmd, $cc_cmd);
my ($smtp_server, $smtp_server_port, @smtp_server_options);
my ($smtp_authuser, $smtp_encryption, $smtp_ssl_cert_path);
+my ($batch_size, $relogin_delay);
my ($identity, $aliasfiletype, @alias_files, $smtp_domain, $smtp_auth);
my ($validate, $confirm);
my (@suppress_cc);
@@ -247,6 +253,8 @@ my %config_settings = (
"smtppass" => \$smtp_authpass,
"smtpdomain" => \$smtp_domain,
"smtpauth" => \$smtp_auth,
+ "smtpbatchsize" => \$batch_size,
+ "smtprelogindelay" => \$relogin_delay,
"to" => \@initial_to,
"tocmd" => \$to_cmd,
"cc" => \@initial_cc,
@@ -358,6 +366,8 @@ $rc = GetOptions(
"force" => \$force,
"xmailer!" => \$use_xmailer,
"no-xmailer" => sub {$use_xmailer = 0},
+ "batch-size=i" => \$batch_size,
+ "relogin-delay=i" => \$relogin_delay,
);
usage() if $help;
@@ -1664,6 +1674,14 @@ foreach my $t (@files) {
}
}
$message_id = undef;
+ $num_sent++;
+ if ($num_sent == $batch_size) {
+ $num_sent = 0;
+ $smtp->quit if defined $smtp;
+ undef $smtp;
+ undef $auth;
+ sleep($relogin_delay);
+ }
}
# Execute a command (e.g. $to_cmd) to get a list of email addresses
--
2.13.0.rc2.49.g12cd49e6e
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit
2017-05-13 1:57 [PATCH v4] send-email: --batch-size to work around some SMTP server limit xiaoqiang zhao
@ 2017-05-15 3:59 ` Junio C Hamano
2017-05-16 23:49 ` Junio C Hamano
2017-05-16 12:10 ` Jan Viktorin
1 sibling, 1 reply; 8+ messages in thread
From: Junio C Hamano @ 2017-05-15 3:59 UTC (permalink / raw
To: xiaoqiang zhao; +Cc: git, viktorin, mst, pbonzini, mina86, artagnon, avarab
xiaoqiang zhao <zxq_yx_007@163.com> writes:
> Some email servers (e.g. smtp.163.com) limit the number emails to be
> sent per session(connection) and this will lead to a faliure when
> sending many messages.
>
> Teach send-email to disconnect after sending a number of messages
> (configurable via the --batch-size=<num> option), wait for a few
> seconds (configurable via the --relogin-delay=<seconds> option) and
> reconnect, to work around such a limit.
>
> Also add this two configure option for git config command.
s/configure/configuration/; "for git config command" is better left
unsaid (too obvious).
> Note:
> Re-authentication will happen every $<batch-size> messages, so it
> will be much more acceptable if you use some form of credential helper
> (e.g. the 'sendemail.smtppass' config option), otherwise you will have
> to retype password every time when asked.
I think this deserves to be in the end-user documentation (i.e. the
part of your patch that updates Documentation/git-send-email.txt).
Other than that, looking good ;-)
Thanks.
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> ---
> contrib/completion/git-completion.bash | 2 ++
> git-send-email.perl | 18 ++++++++++++++++++
> 2 files changed, 20 insertions(+)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit
2017-05-13 1:57 [PATCH v4] send-email: --batch-size to work around some SMTP server limit xiaoqiang zhao
2017-05-15 3:59 ` Junio C Hamano
@ 2017-05-16 12:10 ` Jan Viktorin
2017-05-16 13:55 ` 赵小强
1 sibling, 1 reply; 8+ messages in thread
From: Jan Viktorin @ 2017-05-16 12:10 UTC (permalink / raw
To: xiaoqiang zhao; +Cc: git, gitster, mst, pbonzini, mina86, artagnon, avarab
Hello,
with this patch applied to git 2.12, I could see:
Use of uninitialized value $batch_size in numeric eq (==) at /usr/lib/git-core/git-send-email line 1679
when --batch-size is NOT used. See below...
On Sat, 13 May 2017 09:57:26 +0800
xiaoqiang zhao <zxq_yx_007@163.com> wrote:
> Some email servers (e.g. smtp.163.com) limit the number emails to be
> sent per session(connection) and this will lead to a faliure when
> sending many messages.
>
> Teach send-email to disconnect after sending a number of messages
> (configurable via the --batch-size=<num> option), wait for a few
> seconds (configurable via the --relogin-delay=<seconds> option) and
> reconnect, to work around such a limit.
>
> Also add this two configure option for git config command.
>
> Note:
> Re-authentication will happen every $<batch-size> messages, so it
> will be much more acceptable if you use some form of credential helper
> (e.g. the 'sendemail.smtppass' config option), otherwise you will have
> to retype password every time when asked.
>
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> ---
> contrib/completion/git-completion.bash | 2 ++
> git-send-email.perl | 18 ++++++++++++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index af658995d..29496353a 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2608,6 +2608,8 @@ _git_config ()
> sendemail.thread
> sendemail.to
> sendemail.validate
> + sendemail.smtpbatchsize
> + sendemail.smtprelogindelay
> showbranch.default
> status.relativePaths
> status.showUntrackedFiles
> diff --git a/git-send-email.perl b/git-send-email.perl
> index eea0a517f..071d1ab9d 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -81,6 +81,10 @@ git send-email --dump-aliases
> This setting forces to use one of the listed mechanisms.
> --smtp-debug <0|1> * Disable, enable Net::SMTP debug.
>
> + --batch-size <int> * send max <int> message per connection.
> + --relogin-delay <int> * delay <int> seconds between two successive login, default to 1,
> + This option can only be used with --batch-size
> +
> Automating:
> --identity <str> * Use the sendemail.<id> options.
> --to-cmd <str> * Email To: via `<str> \$patch_path`
> @@ -153,6 +157,7 @@ my $have_email_valid = eval { require Email::Valid; 1 };
> my $have_mail_address = eval { require Mail::Address; 1 };
> my $smtp;
> my $auth;
> +my $num_sent = 0;
>
> # Regexes for RFC 2047 productions.
> my $re_token = qr/[^][()<>@,;:\\"\/?.= \000-\037\177-\377]+/;
> @@ -216,6 +221,7 @@ my ($cover_cc, $cover_to);
> my ($to_cmd, $cc_cmd);
> my ($smtp_server, $smtp_server_port, @smtp_server_options);
> my ($smtp_authuser, $smtp_encryption, $smtp_ssl_cert_path);
> +my ($batch_size, $relogin_delay);
> my ($identity, $aliasfiletype, @alias_files, $smtp_domain, $smtp_auth);
> my ($validate, $confirm);
> my (@suppress_cc);
> @@ -247,6 +253,8 @@ my %config_settings = (
> "smtppass" => \$smtp_authpass,
> "smtpdomain" => \$smtp_domain,
> "smtpauth" => \$smtp_auth,
> + "smtpbatchsize" => \$batch_size,
> + "smtprelogindelay" => \$relogin_delay,
> "to" => \@initial_to,
> "tocmd" => \$to_cmd,
> "cc" => \@initial_cc,
> @@ -358,6 +366,8 @@ $rc = GetOptions(
> "force" => \$force,
> "xmailer!" => \$use_xmailer,
> "no-xmailer" => sub {$use_xmailer = 0},
> + "batch-size=i" => \$batch_size,
> + "relogin-delay=i" => \$relogin_delay,
> );
>
> usage() if $help;
> @@ -1664,6 +1674,14 @@ foreach my $t (@files) {
> }
> }
> $message_id = undef;
> + $num_sent++;
> + if ($num_sent == $batch_size) {
This is the line. I think, batch_size can be sometimes uninitialized
while this statement is executed.
Regards
Jan
> + $num_sent = 0;
> + $smtp->quit if defined $smtp;
> + undef $smtp;
> + undef $auth;
> + sleep($relogin_delay);
> + }
> }
>
> # Execute a command (e.g. $to_cmd) to get a list of email addresses
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit
2017-05-16 12:10 ` Jan Viktorin
@ 2017-05-16 13:55 ` 赵小强
2017-05-16 17:43 ` Ævar Arnfjörð Bjarmason
0 siblings, 1 reply; 8+ messages in thread
From: 赵小强 @ 2017-05-16 13:55 UTC (permalink / raw
To: Jan Viktorin; +Cc: git, gitster, mst, pbonzini, mina86, artagnon, avarab
> 在 2017年5月16日,20:10,Jan Viktorin <viktorin@rehivetech.com> 写道:
>
> Hello,
>
> with this patch applied to git 2.12, I could see:
>
> Use of uninitialized value $batch_size in numeric eq (==) at /usr/lib/git-core/git-send-email line 1679
>
> when --batch-size is NOT used. See below...
>
> On Sat, 13 May 2017 09:57:26 +0800
> xiaoqiang zhao <zxq_yx_007@163.com> wrote:
>
>> Some email servers (e.g. smtp.163.com) limit the number emails to be
>> sent per session(connection) and this will lead to a faliure when
>> sending many messages.
>>
>> Teach send-email to disconnect after sending a number of messages
>> (configurable via the --batch-size=<num> option), wait for a few
>> seconds (configurable via the --relogin-delay=<seconds> option) and
>> reconnect, to work around such a limit.
>>
>> Also add this two configure option for git config command.
>>
>> Note:
>> Re-authentication will happen every $<batch-size> messages, so it
>> will be much more acceptable if you use some form of credential helper
>> (e.g. the 'sendemail.smtppass' config option), otherwise you will have
>> to retype password every time when asked.
>>
>> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
>> ---
>> contrib/completion/git-completion.bash | 2 ++
>> git-send-email.perl | 18 ++++++++++++++++++
>> 2 files changed, 20 insertions(+)
>>
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index af658995d..29496353a 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -2608,6 +2608,8 @@ _git_config ()
>> sendemail.thread
>> sendemail.to
>> sendemail.validate
>> + sendemail.smtpbatchsize
>> + sendemail.smtprelogindelay
>> showbranch.default
>> status.relativePaths
>> status.showUntrackedFiles
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index eea0a517f..071d1ab9d 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -81,6 +81,10 @@ git send-email --dump-aliases
>> This setting forces to use one of the listed mechanisms.
>> --smtp-debug <0|1> * Disable, enable Net::SMTP debug.
>>
>> + --batch-size <int> * send max <int> message per connection.
>> + --relogin-delay <int> * delay <int> seconds between two successive login, default to 1,
>> + This option can only be used with --batch-size
>> +
>> Automating:
>> --identity <str> * Use the sendemail.<id> options.
>> --to-cmd <str> * Email To: via `<str> \$patch_path`
>> @@ -153,6 +157,7 @@ my $have_email_valid = eval { require Email::Valid; 1 };
>> my $have_mail_address = eval { require Mail::Address; 1 };
>> my $smtp;
>> my $auth;
>> +my $num_sent = 0;
>>
>> # Regexes for RFC 2047 productions.
>> my $re_token = qr/[^][()<>@,;:\\"\/?.= \000-\037\177-\377]+/;
>> @@ -216,6 +221,7 @@ my ($cover_cc, $cover_to);
>> my ($to_cmd, $cc_cmd);
>> my ($smtp_server, $smtp_server_port, @smtp_server_options);
>> my ($smtp_authuser, $smtp_encryption, $smtp_ssl_cert_path);
>> +my ($batch_size, $relogin_delay);
>> my ($identity, $aliasfiletype, @alias_files, $smtp_domain, $smtp_auth);
>> my ($validate, $confirm);
>> my (@suppress_cc);
>> @@ -247,6 +253,8 @@ my %config_settings = (
>> "smtppass" => \$smtp_authpass,
>> "smtpdomain" => \$smtp_domain,
>> "smtpauth" => \$smtp_auth,
>> + "smtpbatchsize" => \$batch_size,
>> + "smtprelogindelay" => \$relogin_delay,
>> "to" => \@initial_to,
>> "tocmd" => \$to_cmd,
>> "cc" => \@initial_cc,
>> @@ -358,6 +366,8 @@ $rc = GetOptions(
>> "force" => \$force,
>> "xmailer!" => \$use_xmailer,
>> "no-xmailer" => sub {$use_xmailer = 0},
>> + "batch-size=i" => \$batch_size,
>> + "relogin-delay=i" => \$relogin_delay,
>> );
>>
>> usage() if $help;
>> @@ -1664,6 +1674,14 @@ foreach my $t (@files) {
>> }
>> }
>> $message_id = undef;
>> + $num_sent++;
>> + if ($num_sent == $batch_size) {
>
> This is the line. I think, batch_size can be sometimes uninitialized
> while this statement is executed.
>
> Regards
> Jan
Thank you for reporting this,I will take a look .
>
>> + $num_sent = 0;
>> + $smtp->quit if defined $smtp;
>> + undef $smtp;
>> + undef $auth;
>> + sleep($relogin_delay);
>> + }
>> }
>>
>> # Execute a command (e.g. $to_cmd) to get a list of email addresses
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit
2017-05-16 13:55 ` 赵小强
@ 2017-05-16 17:43 ` Ævar Arnfjörð Bjarmason
2017-05-17 0:04 ` 赵小强
0 siblings, 1 reply; 8+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2017-05-16 17:43 UTC (permalink / raw
To: 赵小强
Cc: Jan Viktorin, Git Mailing List, Junio C Hamano, mst, pbonzini,
mina86, Ramkumar Ramachandra
On Tue, May 16, 2017 at 3:55 PM, 赵小强 <zxq_yx_007@163.com> wrote:
>
>
>> 在 2017年5月16日,20:10,Jan Viktorin <viktorin@rehivetech.com> 写道:
>>
>> Hello,
>>
>> with this patch applied to git 2.12, I could see:
>>
>> Use of uninitialized value $batch_size in numeric eq (==) at /usr/lib/git-core/git-send-email line 1679
>>
>> when --batch-size is NOT used. See below...
>>
>> On Sat, 13 May 2017 09:57:26 +0800
>> xiaoqiang zhao <zxq_yx_007@163.com> wrote:
>>
>>> Some email servers (e.g. smtp.163.com) limit the number emails to be
>>> sent per session(connection) and this will lead to a faliure when
>>> sending many messages.
>>>
>>> Teach send-email to disconnect after sending a number of messages
>>> (configurable via the --batch-size=<num> option), wait for a few
>>> seconds (configurable via the --relogin-delay=<seconds> option) and
>>> reconnect, to work around such a limit.
>>>
>>> Also add this two configure option for git config command.
>>>
>>> Note:
>>> Re-authentication will happen every $<batch-size> messages, so it
>>> will be much more acceptable if you use some form of credential helper
>>> (e.g. the 'sendemail.smtppass' config option), otherwise you will have
>>> to retype password every time when asked.
>>>
>>> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
>>> ---
>>> contrib/completion/git-completion.bash | 2 ++
>>> git-send-email.perl | 18 ++++++++++++++++++
>>> 2 files changed, 20 insertions(+)
>>>
>>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>>> index af658995d..29496353a 100644
>>> --- a/contrib/completion/git-completion.bash
>>> +++ b/contrib/completion/git-completion.bash
>>> @@ -2608,6 +2608,8 @@ _git_config ()
>>> sendemail.thread
>>> sendemail.to
>>> sendemail.validate
>>> + sendemail.smtpbatchsize
>>> + sendemail.smtprelogindelay
>>> showbranch.default
>>> status.relativePaths
>>> status.showUntrackedFiles
>>> diff --git a/git-send-email.perl b/git-send-email.perl
>>> index eea0a517f..071d1ab9d 100755
>>> --- a/git-send-email.perl
>>> +++ b/git-send-email.perl
>>> @@ -81,6 +81,10 @@ git send-email --dump-aliases
>>> This setting forces to use one of the listed mechanisms.
>>> --smtp-debug <0|1> * Disable, enable Net::SMTP debug.
>>>
>>> + --batch-size <int> * send max <int> message per connection.
>>> + --relogin-delay <int> * delay <int> seconds between two successive login, default to 1,
>>> + This option can only be used with --batch-size
>>> +
>>> Automating:
>>> --identity <str> * Use the sendemail.<id> options.
>>> --to-cmd <str> * Email To: via `<str> \$patch_path`
>>> @@ -153,6 +157,7 @@ my $have_email_valid = eval { require Email::Valid; 1 };
>>> my $have_mail_address = eval { require Mail::Address; 1 };
>>> my $smtp;
>>> my $auth;
>>> +my $num_sent = 0;
>>>
>>> # Regexes for RFC 2047 productions.
>>> my $re_token = qr/[^][()<>@,;:\\"\/?.= \000-\037\177-\377]+/;
>>> @@ -216,6 +221,7 @@ my ($cover_cc, $cover_to);
>>> my ($to_cmd, $cc_cmd);
>>> my ($smtp_server, $smtp_server_port, @smtp_server_options);
>>> my ($smtp_authuser, $smtp_encryption, $smtp_ssl_cert_path);
>>> +my ($batch_size, $relogin_delay);
>>> my ($identity, $aliasfiletype, @alias_files, $smtp_domain, $smtp_auth);
>>> my ($validate, $confirm);
>>> my (@suppress_cc);
>>> @@ -247,6 +253,8 @@ my %config_settings = (
>>> "smtppass" => \$smtp_authpass,
>>> "smtpdomain" => \$smtp_domain,
>>> "smtpauth" => \$smtp_auth,
>>> + "smtpbatchsize" => \$batch_size,
>>> + "smtprelogindelay" => \$relogin_delay,
>>> "to" => \@initial_to,
>>> "tocmd" => \$to_cmd,
>>> "cc" => \@initial_cc,
>>> @@ -358,6 +366,8 @@ $rc = GetOptions(
>>> "force" => \$force,
>>> "xmailer!" => \$use_xmailer,
>>> "no-xmailer" => sub {$use_xmailer = 0},
>>> + "batch-size=i" => \$batch_size,
>>> + "relogin-delay=i" => \$relogin_delay,
>>> );
>>>
>>> usage() if $help;
>>> @@ -1664,6 +1674,14 @@ foreach my $t (@files) {
>>> }
>>> }
>>> $message_id = undef;
>>> + $num_sent++;
>>> + if ($num_sent == $batch_size) {
>>
>> This is the line. I think, batch_size can be sometimes uninitialized
>> while this statement is executed.
>>
>> Regards
>> Jan
>
> Thank you for reporting this,I will take a look .
You just need to initialize the variables you're using, see e.g. these
existing ones:
my ($quiet, $dry_run) = (0, 0);
Just do the same for the ones you're adding.
>>> + $num_sent = 0;
>>> + $smtp->quit if defined $smtp;
>>> + undef $smtp;
>>> + undef $auth;
>>> + sleep($relogin_delay);
>>> + }
>>> }
>>>
>>> # Execute a command (e.g. $to_cmd) to get a list of email addresses
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit
2017-05-15 3:59 ` Junio C Hamano
@ 2017-05-16 23:49 ` Junio C Hamano
2017-05-17 0:03 ` 赵小强
0 siblings, 1 reply; 8+ messages in thread
From: Junio C Hamano @ 2017-05-16 23:49 UTC (permalink / raw
To: xiaoqiang zhao; +Cc: git, viktorin, mst, pbonzini, mina86, artagnon, avarab
Junio C Hamano <gitster@pobox.com> writes:
> xiaoqiang zhao <zxq_yx_007@163.com> writes:
> ...
>> Note:
>> Re-authentication will happen every $<batch-size> messages, so it
>> will be much more acceptable if you use some form of credential helper
>> (e.g. the 'sendemail.smtppass' config option), otherwise you will have
>> to retype password every time when asked.
>
> I think this deserves to be in the end-user documentation (i.e. the
> part of your patch that updates Documentation/git-send-email.txt).
Ah, this came out to be rather obliqu, but you do need an update to
the documentation as part of this patch.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit
2017-05-16 23:49 ` Junio C Hamano
@ 2017-05-17 0:03 ` 赵小强
0 siblings, 0 replies; 8+ messages in thread
From: 赵小强 @ 2017-05-17 0:03 UTC (permalink / raw
To: Junio C Hamano; +Cc: git, viktorin, mst, pbonzini, mina86, artagnon, avarab
> 在 2017年5月17日,07:49,Junio C Hamano <gitster@pobox.com> 写道:
>
> Junio C Hamano <gitster@pobox.com> writes:
>
>> xiaoqiang zhao <zxq_yx_007@163.com> writes:
>> ...
>>> Note:
>>> Re-authentication will happen every $<batch-size> messages, so it
>>> will be much more acceptable if you use some form of credential helper
>>> (e.g. the 'sendemail.smtppass' config option), otherwise you will have
>>> to retype password every time when asked.
>>
>> I think this deserves to be in the end-user documentation (i.e. the
>> part of your patch that updates Documentation/git-send-email.txt).
>
> Ah, this came out to be rather obliqu, but you do need an update to
> the documentation as part of this patch.
>
> Thanks.
Sure!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit
2017-05-16 17:43 ` Ævar Arnfjörð Bjarmason
@ 2017-05-17 0:04 ` 赵小强
0 siblings, 0 replies; 8+ messages in thread
From: 赵小强 @ 2017-05-17 0:04 UTC (permalink / raw
To: Ævar Arnfjörð Bjarmason
Cc: Jan Viktorin, Git Mailing List, Junio C Hamano, mst, pbonzini,
mina86, Ramkumar Ramachandra
在 2017年5月17日,01:43,Ævar Arnfjörð Bjarmason <avarab@gmail.com> 写道:
>>> Regards
>>> Jan
>>
>> Thank you for reporting this,I will take a look .
>
> You just need to initialize the variables you're using, see e.g. these
> existing ones:
>
> my ($quiet, $dry_run) = (0, 0);
>
> Just do the same for the ones you're adding.
Yes,has to be.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-05-17 0:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-13 1:57 [PATCH v4] send-email: --batch-size to work around some SMTP server limit xiaoqiang zhao
2017-05-15 3:59 ` Junio C Hamano
2017-05-16 23:49 ` Junio C Hamano
2017-05-17 0:03 ` 赵小强
2017-05-16 12:10 ` Jan Viktorin
2017-05-16 13:55 ` 赵小强
2017-05-16 17:43 ` Ævar Arnfjörð Bjarmason
2017-05-17 0:04 ` 赵小强
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).