git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, johannes.schindelin@gmx.de
Subject: Re: [PATCH] doc: mention that 'git submodule update' fetches missing commits
Date: Mon, 18 Nov 2019 22:55:37 -0500	[thread overview]
Message-ID: <9B605234-8F49-4FEB-9156-22367E01B08B@gmail.com> (raw)
In-Reply-To: <xmqqsgs4nn6k.fsf@gitster-ct.c.googlers.com>

Hi Junio,

First off, sorry for not answering this summer. 
Dscho suggested [1] I try to convince you. 

> Le 20 juin 2019 à 14:09, Junio C Hamano <gitster@pobox.com> a écrit :
> 
> The additional text may not be wrong per-se, but isn't it fairly
> obvious that there is no other way than to fetch, in order to
> "update the registered submodules to match what the superproject
> expects »,

Well, that’s true, but I think that it is important in the documentation to be thorough as to what git commands talk to a remote in what circumstances, and which don’t (this is something that is sometimes not obvious to new users in my opinion). Since by default ‘git pull’ will fetch missing submodule commits, it may not be obvious that ‘git submodule update’ will also fetch from a remote if need be. 

> How else would the subcommand come up
> with the missing commit out of thin air?

Since 'git pull’ will fetch submodules changes, and is usually run first, the commits are usually already there, but I think it’s worth mentioning that they will be fetched if they need to.

I like thoroughness in software documentation :) 

Philippe.

[1] https://github.com/git/git/pull/596

  reply	other threads:[~2019-11-19  3:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 19:24 [PATCH] git-submodule.txt: mention that 'git submodule update' fetches missing commits Philippe Blain
2019-06-20  2:09 ` [PATCH] doc: " Philippe Blain
2019-06-20 18:09   ` Junio C Hamano
2019-11-19  3:55     ` Philippe Blain [this message]
2019-11-20  2:51       ` Junio C Hamano
2019-11-24  2:01 ` [PATCH v2] " Philippe Blain
2019-11-24  6:05   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9B605234-8F49-4FEB-9156-22367E01B08B@gmail.com \
    --to=levraiphilippeblain@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).