From: John Cai <johncai86@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/8] reflog.c: indent argument lists
Date: Thu, 17 Mar 2022 15:42:10 -0400 [thread overview]
Message-ID: <99CF36A8-B9FD-4E05-A2DA-B4662C530738@gmail.com> (raw)
In-Reply-To: <patch-1.8-5069b3fd0ff-20220317T180439Z-avarab@gmail.com>
Hi Ævar
On 17 Mar 2022, at 14:08, Ævar Arnfjörð Bjarmason wrote:
> When reflog.c was lib-ified in 7d3d226e700 (reflog: libify delete
> reflog function and helpers, 2022-03-02) these previously "static"
> functions were made non-"static", but the argument lists were not
> correspondingly indented according to our usual coding style. Let's do
> that.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> reflog.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/reflog.c b/reflog.c
> index 333fd8708fe..82e5a935117 100644
> --- a/reflog.c
> +++ b/reflog.c
> @@ -240,8 +240,8 @@ static int unreachable(struct expire_reflog_policy_cb *cb, struct commit *commit
> * Return true iff the specified reflog entry should be expired.
> */
> int should_expire_reflog_ent(struct object_id *ooid, struct object_id *noid,
> - const char *email, timestamp_t timestamp, int tz,
> - const char *message, void *cb_data)
> + const char *email, timestamp_t timestamp, int tz,
> + const char *message, void *cb_data)
> {
> struct expire_reflog_policy_cb *cb = cb_data;
> struct commit *old_commit, *new_commit;
> @@ -273,10 +273,10 @@ int should_expire_reflog_ent(struct object_id *ooid, struct object_id *noid,
> }
>
> int should_expire_reflog_ent_verbose(struct object_id *ooid,
> - struct object_id *noid,
> - const char *email,
> - timestamp_t timestamp, int tz,
> - const char *message, void *cb_data)
> + struct object_id *noid,
> + const char *email,
> + timestamp_t timestamp, int tz,
> + const char *message, void *cb_data)
> {
> struct expire_reflog_policy_cb *cb = cb_data;
> int expire;
> @@ -323,8 +323,8 @@ static int is_head(const char *refname)
> }
>
> void reflog_expiry_prepare(const char *refname,
> - const struct object_id *oid,
> - void *cb_data)
> + const struct object_id *oid,
> + void *cb_data)
> {
> struct expire_reflog_policy_cb *cb = cb_data;
> struct commit_list *elem;
> @@ -377,8 +377,8 @@ void reflog_expiry_cleanup(void *cb_data)
> }
>
> int count_reflog_ent(struct object_id *ooid, struct object_id *noid,
> - const char *email, timestamp_t timestamp, int tz,
> - const char *message, void *cb_data)
> + const char *email, timestamp_t timestamp, int tz,
> + const char *message, void *cb_data)
> {
> struct cmd_reflog_expire_cb *cb = cb_data;
> if (!cb->expire_total || timestamp < cb->expire_total)
Just wanted to say thanks for fixing these :)
> --
> 2.35.1.1384.g7d2906948a1
next prev parent reply other threads:[~2022-03-17 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 18:08 [PATCH 0/8] reflog: migrate fully to parse_options() Ævar Arnfjörð Bjarmason
2022-03-17 18:08 ` [PATCH 1/8] reflog.c: indent argument lists Ævar Arnfjörð Bjarmason
2022-03-17 19:42 ` John Cai [this message]
2022-03-17 18:08 ` [PATCH 2/8] reflog: refactor cmd_reflog() to "if" branches Ævar Arnfjörð Bjarmason
2022-03-17 18:08 ` [PATCH 3/8] reflog tests: add missing "git reflog exists" tests Ævar Arnfjörð Bjarmason
2022-03-17 18:08 ` [PATCH 4/8] reflog: move "usage" variables and use macros Ævar Arnfjörð Bjarmason
2022-03-17 18:08 ` [PATCH 5/8] git reflog [expire|delete]: make -h output consistent with SYNOPSIS Ævar Arnfjörð Bjarmason
2022-03-18 1:24 ` Junio C Hamano
2022-03-17 18:08 ` [PATCH 6/8] reflog exists: use parse_options() API Ævar Arnfjörð Bjarmason
2022-03-18 1:30 ` Junio C Hamano
2022-03-17 18:08 ` [PATCH 7/8] reflog: convert to " Ævar Arnfjörð Bjarmason
2022-03-18 1:49 ` Junio C Hamano
2022-03-17 18:08 ` [PATCH 8/8] reflog [show]: display sensible -h output Ævar Arnfjörð Bjarmason
2022-03-28 21:21 ` [PATCH] reflog: fix 'show' subcommand's argv SZEDER Gábor
2022-03-28 22:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99CF36A8-B9FD-4E05-A2DA-B4662C530738@gmail.com \
--to=johncai86@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).