From: Thomas Braun <thomas.braun@virtuell-zuhause.de>
To: Junio C Hamano <gitster@pobox.com>, Stefan Beller <sbeller@google.com>
Cc: git <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v1 1/2] log -G: Ignore binary files
Date: Wed, 28 Nov 2018 12:31:30 +0100 (CET) [thread overview]
Message-ID: <992623969.1654.1543404690644@ox.hosteurope.de> (raw)
In-Reply-To: <xmqq4lc3uyuh.fsf@gitster-ct.c.googlers.com>
> Junio C Hamano <gitster@pobox.com> hat am 27. November 2018 um 01:51 geschrieben:
>
>
> Stefan Beller <sbeller@google.com> writes:
>
> > On Wed, Nov 21, 2018 at 1:08 PM Thomas Braun
> > <thomas.braun@virtuell-zuhause.de> wrote:
> >>
> >> The -G <regex> option of log looks for the differences whose patch text
> >> contains added/removed lines that match regex.
> >>
> >> The concept of differences only makes sense for text files, therefore
> >> we need to ignore binary files when searching with -G <regex> as well.
> >
> > What about partial text/partial binary files?
>
> Good point. You'd use "-a" (or "--text") to tell the diff machinery
> to treat the contents as text, and the new logic must pay attention
> to that command line option.
Yes exactly. Either use -a for the occasional use or a textconv filter
for permanent use.
Coming from the opposite side: I usually mark svg files as binary as the
textual diff is well, let's say uninspiring.
prev parent reply other threads:[~2018-11-28 11:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 20:52 [PATCH 0/2] Teach log -G to ignore binary files Thomas Braun
2018-11-21 20:52 ` [PATCH v1 1/2] log -G: Ignore " Thomas Braun
2018-11-21 20:52 ` [PATCH v1 2/2] log -S: Add test which searches in " Thomas Braun
2018-11-21 21:00 ` [PATCH 0/2] Teach log -G to ignore " Thomas Braun
2018-11-28 11:32 ` [PATCH v2] log -G: Ignore " Thomas Braun
2018-11-28 12:54 ` Ævar Arnfjörð Bjarmason
2018-12-14 18:44 ` Thomas Braun
2018-11-29 7:10 ` Junio C Hamano
2018-11-29 7:22 ` Junio C Hamano
2018-12-14 18:45 ` Thomas Braun
2018-12-14 18:45 ` Thomas Braun
2018-12-14 18:49 ` [PATCH v3] log -G: ignore " Thomas Braun
2018-12-26 23:24 ` Junio C Hamano
2018-11-22 1:34 ` [PATCH v1 2/2] log -S: Add test which searches in " Junio C Hamano
2018-11-28 11:31 ` Thomas Braun
2018-11-22 9:14 ` Ævar Arnfjörð Bjarmason
2018-11-24 2:27 ` Junio C Hamano
2018-11-28 11:31 ` Thomas Braun
2018-11-22 1:29 ` [PATCH v1 1/2] log -G: Ignore " Junio C Hamano
2018-11-28 11:31 ` Thomas Braun
2018-11-22 10:16 ` Ævar Arnfjörð Bjarmason
2018-11-22 16:27 ` Jeff King
2018-11-28 11:31 ` Thomas Braun
2018-11-28 11:31 ` Thomas Braun
2018-11-22 16:20 ` Jeff King
2018-11-24 2:32 ` Junio C Hamano
2018-11-28 11:31 ` Thomas Braun
2018-11-26 20:19 ` Stefan Beller
2018-11-27 0:51 ` Junio C Hamano
2018-11-28 11:31 ` Thomas Braun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=992623969.1654.1543404690644@ox.hosteurope.de \
--to=thomas.braun@virtuell-zuhause.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).