* [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings
@ 2018-03-25 10:57 René Scharfe
2018-03-25 15:20 ` brian m. carlson
0 siblings, 1 reply; 3+ messages in thread
From: René Scharfe @ 2018-03-25 10:57 UTC (permalink / raw)
To: Git List; +Cc: Yasushi SHOJI, brian m. carlson, Junio C Hamano
Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
object to object_id).
bisect.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bisect.c b/bisect.c
index f6d05bd66f..319d60edad 100644
--- a/bisect.c
+++ b/bisect.c
@@ -144,10 +144,10 @@ static void show_list(const char *debug, int counted, int nr,
fprintf(stderr, "%3d", weight(p));
else
fprintf(stderr, "---");
- fprintf(stderr, " %.*s", 8, sha1_to_hex(commit->object.oid.hash));
+ fprintf(stderr, " %.*s", 8, oid_to_hex(&commit->object.oid));
for (pp = commit->parents; pp; pp = pp->next)
fprintf(stderr, " %.*s", 8,
- sha1_to_hex(pp->item->object.oid.hash));
+ oid_to_hex(&pp->item->object.oid));
subject_len = find_commit_subject(buf, &subject_start);
if (subject_len)
--
2.16.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings
2018-03-25 10:57 [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings René Scharfe
@ 2018-03-25 15:20 ` brian m. carlson
2018-03-25 16:48 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: brian m. carlson @ 2018-03-25 15:20 UTC (permalink / raw)
To: René Scharfe; +Cc: Git List, Yasushi SHOJI, Junio C Hamano
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote:
> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
> object to object_id).
This looks good to me.
--
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings
2018-03-25 15:20 ` brian m. carlson
@ 2018-03-25 16:48 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2018-03-25 16:48 UTC (permalink / raw)
To: brian m. carlson; +Cc: René Scharfe, Git List, Yasushi SHOJI
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote:
>> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.
>>
>> Signed-off-by: Rene Scharfe <l.s.r@web.de>
>> ---
>> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
>> object to object_id).
>
> This looks good to me.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-25 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-25 10:57 [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings René Scharfe
2018-03-25 15:20 ` brian m. carlson
2018-03-25 16:48 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).