From: Lars Schneider <larsxschneider@gmail.com>
To: tboegi@web.de
Cc: Jeff King <peff@peff.net>, Johannes Sixt <j6t@kdbg.org>,
lars.schneider@autodesk.com, git@vger.kernel.org,
gitster@pobox.com, patrick@luehne.de
Subject: Re: [PATCH 1/5] convert_to_git(): checksafe becomes an integer
Date: Sun, 31 Dec 2017 13:23:25 +0100 [thread overview]
Message-ID: <96B6CD4C-0A0C-47F5-922D-B8BAFB832FD1@gmail.com> (raw)
In-Reply-To: <20171231080552.22258-1-tboegi@web.de>
> On 31 Dec 2017, at 09:05, tboegi@web.de wrote:
>
> From: Torsten Bögershausen <tboegi@web.de>
>
> When calling convert_to_git(), the checksafe parameter has been used to
> check if commit would give a non-roundtrip conversion of EOL.
>
> When checksafe was introduced, 3 values had been in use:
> SAFE_CRLF_FALSE: no warning
> SAFE_CRLF_FAIL: reject the commit if EOL do not roundtrip
> SAFE_CRLF_WARN: warn the user if EOL do not roundtrip
In general, I really like the direction as this simplifies
my patch later on in 5/5. However, I see a few problems:
(1) The prefix "SAFE_CRLF" confuses me because the main theme
is EOL and CRLF just happens to be a EOL type.
What do you think about something like this:
CONVERT_ERROR_IGNORE 0
CONVERT_EOL_ERROR_DIE (1<<0)
CONVERT_EOL_ERROR_WARN (1<<1)
CONVERT_EOL_TO_LF (1<<2)
CONVERT_EOL_KEEP_CRLF (1<<3)
CONVERT_ENCODE_ERROR_DIE (1<<4)
(2) We mix error reporting switches (FALSE/FAIL/WARN) with
switches that change the content (RENORMALIZE/KEEP_CRLF).
Plus, these the switches should be mutually exclusive
(e.g. we don't want to enable the FAIL and WARN bit at
the same time).
(3) We kind of replicate some flags defined in cache.h:
#define HASH_WRITE_OBJECT 1
#define HASH_RENORMALIZE 4
- Lars
next prev parent reply other threads:[~2017-12-31 12:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 15:22 [PATCH v2 0/5] convert: add support for different encodings lars.schneider
2017-12-29 15:22 ` [PATCH v2 1/5] strbuf: add xstrdup_toupper() lars.schneider
2017-12-29 15:56 ` Torsten Bögershausen
2017-12-29 16:55 ` Lars Schneider
2017-12-29 15:22 ` [PATCH v2 2/5] utf8: add function to detect prohibited UTF-16/32 BOM lars.schneider
2017-12-29 15:22 ` [PATCH v2 3/5] utf8: add function to detect a missing " lars.schneider
2017-12-29 15:22 ` [PATCH v2 4/5] convert: add support for 'checkout-encoding' attribute lars.schneider
2017-12-29 17:28 ` Torsten Bögershausen
2017-12-30 19:58 ` Lars Schneider
2017-12-29 15:22 ` [PATCH v2 5/5] convert: add tracing for checkout-encoding lars.schneider
2017-12-31 8:05 ` [PATCH 0/5] V2B: simplify convert.c/h tboegi
2017-12-31 8:05 ` [PATCH 1/5] convert_to_git(): checksafe becomes an integer tboegi
2017-12-31 12:23 ` Lars Schneider [this message]
2018-01-01 21:59 ` [PATCH v3 1/1] convert_to_git(): checksafe becomes int conv_flags tboegi
2018-01-02 19:11 ` Lars Schneider
2018-01-03 5:36 ` Torsten Bögershausen
2018-01-03 9:37 ` Lars Schneider
2018-01-05 19:00 ` Lars Schneider
2018-01-05 19:33 ` Torsten Bögershausen
2018-01-05 23:22 ` [PATCH 1/5] convert_to_git(): checksafe becomes an integer Junio C Hamano
2018-01-06 0:55 ` Lars Schneider
2017-12-31 8:05 ` [PATCH 2/5] strbuf: add xstrdup_toupper() tboegi
2017-12-31 8:05 ` [PATCH 3/5] utf8: add function to detect prohibited UTF-16/32 BOM tboegi
2017-12-31 8:05 ` [PATCH 4/5] utf8: add function to detect a missing " tboegi
2017-12-31 8:06 ` [PATCH 5/5] convert: add support for 'checkout-encoding' attribute tboegi
2018-01-05 14:45 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96B6CD4C-0A0C-47F5-922D-B8BAFB832FD1@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=lars.schneider@autodesk.com \
--cc=patrick@luehne.de \
--cc=peff@peff.net \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).