From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Jeff King <peff@peff.net>
Subject: Re: [RFC] Native access to Git LFS cache
Date: Tue, 28 Jun 2016 15:22:59 +0200 [thread overview]
Message-ID: <9603B6F9-3BEF-4779-84C3-6DC61D7FBC46@gmail.com> (raw)
In-Reply-To: <xmqqmvm6bom5.fsf@gitster.mtv.corp.google.com>
> On 27 Jun 2016, at 18:09, Junio C Hamano <gitster@pobox.com> wrote:
>
> larsxschneider@gmail.com writes:
>
>> Unfortunately that fix helps only with cloning. Any local Git operation
>> that invokes the clean/smudge filter (e.g. switching branches) is still
>> slow.
>
> Do you know where the slowness comes from? Does Joey's new
> clean/smudge interface help GitLFS?
I am pretty sure the startup time of the external clean/smudge process
causes the slowness and consequently I don't think Joey's patch would help.
The following tests makes me believe that:
I ran the same test as in my original email using the repo with 15,000
LFS files. Instead of the LFS binary I use the fast and simple shell
built-in `true` command:
$ git -c filter.lfs.smudge=true -c filter.lfs.clean=true clone https://github.com/larsxschneider/lfstest-manyfiles.git
$ cd lfstest-manyfiles/
$ time git -c filter.lfs.smudge=true -c filter.lfs.clean=true checkout removed-files
real 0m47.030s
user 0m29.521s
sys 0m16.993s
It still takes 47 seconds to switch the branch. Does this test prove my
point or do you see a flaw in the test?
> You are not likely to get anything that knows that a blob object may
> be named as anything other than SHA-1("blob <len>" + <contents>) to
> Git core. The remote-object-store idea that was floated by Peff and
> Christian started running with at least maintains that object naming
> property and has a better chance of interacting better with the core,
> but LFS, Annex or anything that would not preserve the object naming
> would not.
>
> Personally, I view a surrogate blob left by LFS in the tree object
> and filtered via clean/smudge a "smarter" kind of symbolic link that
> points outside what Git controls. The area outside what Git
> controls is left to be managed by whatever the add-on does; Git
> shouldn't even be aware of how they are structured and/or managed.
I understand and somewhat anticipated your point of view. I will try
to find a less intrusive solution.
@Christian/Peff:
Is there a place to look for more info about your remote-object-store idea?
Thanks,
Lars
next prev parent reply other threads:[~2016-06-28 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 5:38 [RFC] Native access to Git LFS cache larsxschneider
2016-06-27 15:53 ` Duy Nguyen
2016-06-28 9:40 ` Johannes Schindelin
2016-06-28 13:11 ` Duy Nguyen
2016-06-28 13:14 ` Johannes Schindelin
2016-06-28 13:43 ` Lars Schneider
2016-06-28 16:00 ` Duy Nguyen
2016-06-28 15:50 ` Duy Nguyen
2016-06-27 16:09 ` Junio C Hamano
2016-06-28 13:22 ` Lars Schneider [this message]
2016-06-28 13:53 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9603B6F9-3BEF-4779-84C3-6DC61D7FBC46@gmail.com \
--to=larsxschneider@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).