From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Phillip Wood <phillip.wood@dunelm.org.uk>,
Git Mailing List <git@vger.kernel.org>
Cc: carenas@gmail.com, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 1/4] terminal: use flags for save_term()
Date: Fri, 4 Mar 2022 20:40:36 +0000 [thread overview]
Message-ID: <95cbca4c-ec26-853e-243f-461a365d9f71@ramsayjones.plus.com> (raw)
In-Reply-To: <20220304131126.8293-2-phillip.wood123@gmail.com>
Hi Phillip,
I have not studied/applied your patches, they are just floating
past my inbox, so please ignore me if I have misunderstood ...
On 04/03/2022 13:11, Phillip Wood wrote:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> The next commit will add another flag in addition to the existing
> full_duplex so change the function signature to take an unsigned flags
> argument. Also alter the functions that call save_term() so that they
> can pass flags down to it.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> ---
> compat/terminal.c | 41 +++++++++++++++++++++--------------------
> compat/terminal.h | 5 ++++-
> 2 files changed, 25 insertions(+), 21 deletions(-)
>
> diff --git a/compat/terminal.c b/compat/terminal.c
> index d882dfa06e..bad8e04cd8 100644
> --- a/compat/terminal.c
> +++ b/compat/terminal.c
> @@ -34,7 +34,7 @@ void restore_term(void)
> sigchain_pop_common();
> }
>
> -int save_term(int full_duplex)
> +int save_term(unsigned flags)
> {
> if (term_fd < 0)
> term_fd = open("/dev/tty", O_RDWR);
> @@ -47,11 +47,11 @@ int save_term(int full_duplex)
> return 0;
> }
>
> -static int disable_bits(tcflag_t bits)
> +static int disable_bits(unsigned flags, tcflag_t bits)
.. you add the 'flags' as the new first parameter ...
> {
> struct termios t;
>
> - if (save_term(0) < 0)
> + if (save_term(flags) < 0)
> goto error;
>
> t = old_term;
> @@ -71,14 +71,14 @@ static int disable_bits(tcflag_t bits)
> return -1;
> }
>
> -static int disable_echo(void)
> +static int disable_echo(unsigned flags)
> {
> - return disable_bits(ECHO);
> + return disable_bits(flags, ECHO);
.. and pass it as first parameter, good, and ...
> }
>
> -static int enable_non_canonical(void)
> +static int enable_non_canonical(unsigned flags)
> {
> - return disable_bits(ICANON | ECHO);
> + return disable_bits(flags, ICANON | ECHO);
.. here as well, good, and ...
> }
>
> #elif defined(GIT_WINDOWS_NATIVE)
> @@ -126,15 +126,15 @@ void restore_term(void)
> hconin = hconout = INVALID_HANDLE_VALUE;
> }
>
> -int save_term(int full_duplex)
> +int save_term(unsigned flags)
> {
> hconin = CreateFileA("CONIN$", GENERIC_READ | GENERIC_WRITE,
> FILE_SHARE_READ, NULL, OPEN_EXISTING,
> FILE_ATTRIBUTE_NORMAL, NULL);
> if (hconin == INVALID_HANDLE_VALUE)
> return -1;
>
> - if (full_duplex) {
> + if (flags & SAVE_TERM_DUPLEX) {
> hconout = CreateFileA("CONOUT$", GENERIC_READ | GENERIC_WRITE,
> FILE_SHARE_WRITE, NULL, OPEN_EXISTING,
> FILE_ATTRIBUTE_NORMAL, NULL);
> @@ -154,7 +154,7 @@ int save_term(int full_duplex)
> return -1;
> }
>
> -static int disable_bits(DWORD bits)
> +static int disable_bits(unsigned flags, DWORD bits)
.. Huh? Ah, the DWORD suggests this is in an #ifdef'd windows
part of the file, OK. ...
> {
> if (use_stty) {
> struct child_process cp = CHILD_PROCESS_INIT;
> @@ -191,7 +191,7 @@ static int disable_bits(DWORD bits)
> use_stty = 0;
> }
>
> - if (save_term(0) < 0)
> + if (save_term(flags) < 0)
> return -1;
>
> if (!SetConsoleMode(hconin, cmode_in & ~bits)) {
> @@ -204,14 +204,15 @@ static int disable_bits(DWORD bits)
> return 0;
> }
>
> -static int disable_echo(void)
> +static int disable_echo(unsigned flags)
> {
> - return disable_bits(ENABLE_ECHO_INPUT);
> + return disable_bits(ENABLE_ECHO_INPUT, flags);
.. but here, you pass the flags as the second parameter. ;-)
> }
>
> -static int enable_non_canonical(void)
> +static int enable_non_canonical(unsigned flags)
> {
> - return disable_bits(ENABLE_ECHO_INPUT | ENABLE_LINE_INPUT | ENABLE_PROCESSED_INPUT);
> + return disable_bits(ENABLE_ECHO_INPUT | ENABLE_LINE_INPUT | ENABLE_PROCESSED_INPUT,
> + flags);
.. ditto here.
ATB,
Ramsay Jones
> }
>
> /*
> @@ -267,7 +268,7 @@ char *git_terminal_prompt(const char *prompt, int echo)
> return NULL;
> }
>
> - if (!echo && disable_echo()) {
> + if (!echo && disable_echo(0)) {
> fclose(input_fh);
> fclose(output_fh);
> return NULL;
> @@ -361,7 +362,7 @@ int read_key_without_echo(struct strbuf *buf)
> static int warning_displayed;
> int ch;
>
> - if (warning_displayed || enable_non_canonical() < 0) {
> + if (warning_displayed || enable_non_canonical(0) < 0) {
> if (!warning_displayed) {
> warning("reading single keystrokes not supported on "
> "this platform; reading line instead");
> @@ -413,10 +414,10 @@ int read_key_without_echo(struct strbuf *buf)
>
> #else
>
> -int save_term(int full_duplex)
> +int save_term(unsigned flags)
> {
> - /* full_duplex == 1, but no support available */
> - return -full_duplex;
> + /* no duplex support available */
> + return -!!(flags & SAVE_TERM_DUPLEX);
> }
>
> void restore_term(void)
> diff --git a/compat/terminal.h b/compat/terminal.h
> index 0fb9fa147c..f24b91390d 100644
> --- a/compat/terminal.h
> +++ b/compat/terminal.h
> @@ -1,14 +1,17 @@
> #ifndef COMPAT_TERMINAL_H
> #define COMPAT_TERMINAL_H
>
> +/* Save input and output settings */
> +#define SAVE_TERM_DUPLEX (1u << 0)
> +
> /*
> * Save the terminal attributes so they can be restored later by a
> * call to restore_term(). Note that every successful call to
> * save_term() must be matched by a call to restore_term() even if the
> * attributes have not been changed. Returns 0 on success, -1 on
> * failure.
> */
> -int save_term(int full_duplex);
> +int save_term(unsigned flags);
> /* Restore the terminal attributes that were saved with save_term() */
> void restore_term(void);
>
next prev parent reply other threads:[~2022-03-04 20:43 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 13:11 [PATCH 0/4] builtin add -p: hopefully final readkey fixes Phillip Wood
2022-03-04 13:11 ` [PATCH 1/4] terminal: use flags for save_term() Phillip Wood
2022-03-04 20:40 ` Ramsay Jones [this message]
2022-03-07 11:11 ` Phillip Wood
2022-03-07 20:21 ` Ramsay Jones
2022-03-08 10:41 ` Phillip Wood
2022-03-05 14:02 ` Ævar Arnfjörð Bjarmason
2022-03-07 10:45 ` Phillip Wood
2022-03-07 12:06 ` Ævar Arnfjörð Bjarmason
2022-03-04 13:11 ` [PATCH 2/4] terminal: don't assume stdin is /dev/tty Phillip Wood
2022-03-04 20:42 ` Ramsay Jones
2022-03-04 13:11 ` [PATCH 3/4] terminal: work around macos poll() bug Phillip Wood
2022-03-04 13:11 ` [PATCH 4/4] terminal: restore settings on SIGTSTP Phillip Wood
2022-03-05 13:59 ` Ævar Arnfjörð Bjarmason
2022-03-07 10:53 ` Phillip Wood
2022-03-07 11:49 ` Ævar Arnfjörð Bjarmason
2022-03-07 13:49 ` Phillip Wood
2022-03-07 14:45 ` Ævar Arnfjörð Bjarmason
2022-03-08 10:54 ` Phillip Wood
2022-03-09 12:19 ` Johannes Schindelin
2022-03-10 16:06 ` Phillip Wood
2022-03-09 11:03 ` [PATCH v2 0/4] builtin add -p: hopefully final readkey fixes Phillip Wood
2022-03-09 11:03 ` [PATCH v2 1/4] terminal: use flags for save_term() Phillip Wood
2022-03-11 16:52 ` Carlo Arenas
2022-03-14 10:49 ` Phillip Wood
2022-03-09 11:03 ` [PATCH v2 2/4] terminal: don't assume stdin is /dev/tty Phillip Wood
2022-03-09 11:03 ` [PATCH v2 3/4] terminal: work around macos poll() bug Phillip Wood
2022-03-10 13:35 ` Ævar Arnfjörð Bjarmason
2022-03-10 16:02 ` Phillip Wood
2022-03-10 18:02 ` Junio C Hamano
2022-03-09 11:03 ` [PATCH v2 4/4] terminal: restore settings on SIGTSTP Phillip Wood
2022-03-09 23:10 ` [PATCH v2 0/4] builtin add -p: hopefully final readkey fixes Junio C Hamano
2022-03-09 23:37 ` Junio C Hamano
2022-03-10 13:28 ` Phillip Wood
2022-03-10 18:18 ` Phillip Wood
2022-03-10 18:53 ` Junio C Hamano
2022-03-10 13:25 ` Johannes Schindelin
2022-03-10 16:08 ` Phillip Wood
2022-03-15 10:57 ` [PATCH v3 " Phillip Wood
2022-03-15 10:57 ` [PATCH v3 1/4] terminal: use flags for save_term() Phillip Wood
2022-03-15 10:57 ` [PATCH v3 2/4] terminal: don't assume stdin is /dev/tty Phillip Wood
2022-03-15 17:42 ` Junio C Hamano
2022-03-15 18:01 ` rsbecker
2022-03-15 19:05 ` Junio C Hamano
2022-03-15 19:38 ` rsbecker
2022-03-15 10:57 ` [PATCH v3 3/4] terminal: work around macos poll() bug Phillip Wood
2022-03-15 10:57 ` [PATCH v3 4/4] terminal: restore settings on SIGTSTP Phillip Wood
2022-03-15 17:51 ` Junio C Hamano
2022-03-16 18:54 ` [PATCH v4 0/4] builtin add -p: hopefully final readkey fixes Phillip Wood
2022-03-16 18:54 ` [PATCH v4 1/4] terminal: use flags for save_term() Phillip Wood
2022-03-16 18:54 ` [PATCH v4 2/4] terminal: don't assume stdin is /dev/tty Phillip Wood
2022-03-16 18:54 ` [PATCH v4 3/4] terminal: work around macos poll() bug Phillip Wood
2022-03-16 18:54 ` [PATCH v4 4/4] terminal: restore settings on SIGTSTP Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95cbca4c-ec26-853e-243f-461a365d9f71@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).