From: Jeff Hostetler <git@jeffhostetler.com>
To: Stefan Beller <sbeller@google.com>, git <git@vger.kernel.org>
Subject: Re: Fwd: New Defects reported by Coverity Scan for git
Date: Tue, 27 Mar 2018 06:38:35 -0400 [thread overview]
Message-ID: <95add9fa-85f2-4c2b-4610-dc32edd78acf@jeffhostetler.com> (raw)
In-Reply-To: <CAGZ79kbAOcwaRzjuMtZ_HVsYvUr_7UAPbOcnrmPgsdE19q=PrQ@mail.gmail.com>
On 3/26/2018 7:39 PM, Stefan Beller wrote:
> coverity scan failed for the last couple month (since Nov 20th)
> without me noticing, I plan on running it again nightly for the
> Git project.
>
> Anyway, here are issues that piled up (in origin/pu) since then.
>
> Stefan
>
>
> ---------- Forwarded message ----------
[...]
________________________________________________________________________________________________________
> *** CID 1433539: Null pointer dereferences (FORWARD_NULL)
> /t/helper/test-json-writer.c: 278 in scripted()
> 272 struct json_writer jw = JSON_WRITER_INIT;
> 273 int k;
> 274
> 275 if (!strcmp(argv[0], "@object"))
> 276 jw_object_begin(&jw);
> 277 else if (!strcmp(argv[0], "@array"))
>>>> CID 1433539: Null pointer dereferences (FORWARD_NULL)
>>>> Passing "&jw" to "jw_array_begin", which dereferences null "jw.levels".
> 278 jw_array_begin(&jw);
> 279 else
> 280 die("first script term must be '@object' or
> '@array': '%s'", argv[0]);
> 281
> 282 for (k = 1; k < argc; k++) {
> 283 const char *a_k = argv[k];
>
> ** CID 1433538: Null pointer dereferences (FORWARD_NULL)
>
The "jw.levels" field has been removed in the json-writer V4 reroll,
so this isn't an issue going forward.
Thanks,
Jeff
next prev parent reply other threads:[~2018-03-27 10:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 23:39 Fwd: New Defects reported by Coverity Scan for git Stefan Beller
2018-03-27 10:38 ` Jeff Hostetler [this message]
[not found] <596ddaa620821_77f83e7330107c4@ss1435.mail>
2017-07-18 16:59 ` Stefan Beller
2017-07-18 17:23 ` Junio C Hamano
2017-07-18 17:41 ` Stefan Beller
2017-07-18 17:55 ` Junio C Hamano
2017-07-18 18:00 ` Brandon Williams
2017-07-18 18:06 ` Stefan Beller
2017-07-20 20:32 ` René Scharfe
2017-07-20 21:52 ` Junio C Hamano
[not found] <580893d5a4736_4ed37b53181837@ss1435.mail>
2016-10-20 17:05 ` Stefan Beller
2016-10-20 17:50 ` Junio C Hamano
2016-10-20 17:58 ` Stefan Beller
2016-10-20 18:05 ` Junio C Hamano
2016-10-20 18:13 ` Stefan Beller
2016-10-20 21:42 ` Jeff King
2016-10-20 22:07 ` Junio C Hamano
2016-10-20 21:40 ` Jeff King
[not found] <55bb53d17f78c_2d71521318537c@scan.mail>
2015-07-31 11:24 ` Duy Nguyen
[not found] <558151df465a5_4fafe3b3182568a@scan.mail>
2015-06-17 13:54 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95add9fa-85f2-4c2b-4610-dc32edd78acf@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).