From: Phillip Wood <phillip.wood@talktalk.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Stefan Beller <sbeller@google.com>
Subject: Re: What's cooking in git.git (Oct 2018, #01; Wed, 10)
Date: Tue, 16 Oct 2018 14:38:59 +0100 [thread overview]
Message-ID: <9521f0a8-efa7-46d7-1aeb-aea700fc2fed@talktalk.net> (raw)
In-Reply-To: <xmqqbm7zb81z.fsf@gitster-ct.c.googlers.com>
On 12/10/2018 14:36, Junio C Hamano wrote:
> Phillip Wood <phillip.wood@talktalk.net> writes:
>
>> It would be nice if the parsing used starts_with(option_name, user_text)
>> rather than strcmp() as well. Also I think --color-moved=no is valid as
>> a synonym of --no-color-moved but --color-moved-ws=no is not supported.
>
> I am not sure about starts_with(). Do you mean we should accept
> "--color-mo", as that is a prefix of "--color-moved" that is not
> shared with any existing option, until we gain a different option
> "--color-more"?
I was thinking of the option arguments rather than the option names
although being able to abbreviate the names in the same way as the
commands that parse_options() would be good too (I seem to remember
someone saying they had some rough patches to use parse_options() for
diff and log in a discussion of adding completion support to
parse_options())
> If you mean "--color-moved-ws=no" (or "--no-color-moved-ws") as a
> way to countermand an earlier --color-moved-ws=<something> on the
> command line, I fully agree that it is a good idea.
Oh I assumed --no-color-moved-ws was allowed but it isn't it. Allowing
--color-moved-ws=no as well would match what is allowed for
--color-moved. I'll try and look at that.
Best Wishes
Phillip
next prev parent reply other threads:[~2018-10-16 13:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 5:43 What's cooking in git.git (Oct 2018, #01; Wed, 10) Junio C Hamano
2018-10-10 7:59 ` Ævar Arnfjörð Bjarmason
2018-10-10 15:06 ` Jeff King
2018-10-10 12:57 ` builtin stash/rebase, was " Johannes Schindelin
2018-10-10 13:19 ` Junio C Hamano
2018-10-11 2:18 ` Junio C Hamano
2018-10-10 13:04 ` js/mingw-wants-vista-or-above, " Johannes Schindelin
2018-10-10 13:13 ` Junio C Hamano
2018-10-10 13:58 ` Phillip Wood
2018-10-11 1:54 ` Junio C Hamano
2018-10-11 22:40 ` Junio C Hamano
2018-10-11 22:59 ` [PATCH] diff.c: die on unknown color-moved ws mode Stefan Beller
2018-10-11 23:01 ` Stefan Beller
2018-10-12 1:22 ` Junio C Hamano
2018-10-11 23:06 ` What's cooking in git.git (Oct 2018, #01; Wed, 10) Stefan Beller
2018-10-12 0:51 ` Junio C Hamano
2018-10-12 9:59 ` Phillip Wood
2018-10-12 13:36 ` Junio C Hamano
2018-10-16 13:38 ` Phillip Wood [this message]
2018-10-16 17:13 ` Stefan Beller
2018-10-10 14:18 ` Thomas Gummerer
2018-10-11 1:40 ` Junio C Hamano
2018-10-10 18:51 ` `--rebase-merges' still failing badly Michael Witten
2018-10-10 19:00 ` Michael Witten
2018-10-10 23:01 ` Junio C Hamano
2018-10-11 2:44 ` Michael Witten
2018-10-12 9:11 ` Johannes Schindelin
2018-10-10 18:55 ` What's cooking in git.git (Oct 2018, #01; Wed, 10) Stefan Beller
2018-10-11 2:00 ` Junio C Hamano
2018-10-10 20:38 ` Tim Schumacher
2018-10-10 21:25 ` Johannes Sixt
2018-10-11 1:53 ` Junio C Hamano
2018-10-11 11:16 ` Derrick Stolee
2018-10-14 12:21 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9521f0a8-efa7-46d7-1aeb-aea700fc2fed@talktalk.net \
--to=phillip.wood@talktalk.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).