Re: [PATCH v3] builtin/remote.c: teach `-v` to list filters for promisor remotes

[Philippe Blain <levraiphilippeblain@gmail.com>]

Hi Junio,

Le 2022-05-09 à 12:29, Junio C Hamano a écrit :
> Philippe Blain <levraiphilippeblain@gmail.com> writes:
> 
>>> Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
>>> ---
>>>     builtin/remote.c: teach -v to list filters for promisor remotes
>>>     
>>>     Fixes #1211 [1]
>>
>> I don't think this matters much, but if Junio is OK with that, it would
>> be nice to include the reference to the GitGitGadget issue in the commit
>> message itself, though with its full URL, something like:
>>
>> Closes: https://github.com/gitgitgadget/git/issues/1211
>>
>> as another trailer before your signed-off-by. By including it in the 
>> commit message we allow the issue to be closed automatically when your topic
>> branch is merged to 'master'. By using the full link we make sure that GitHub 
>> knows we are targetting that issue specifically, not any other issue or PR in 
>> any fork of Git with the same number.
> 
> Nice to know.  Is there a handy GGG users' guide that mentions these
> "magic trailers" (the other one I have seen used is "Cc:")?

"CC:" is GGG-specific, it is mentioned on the GGG homepage, 
https://gitgitgadget.github.io/, under "How can you use GitGitGadget?".
It's also mentioned on the Welcome message GGG adds to the PR for new 
contributors [1].

"Fixes", "Closes" etc. are GitHub features (though GitLab implements the same
feature), see [2], [3].

[1] https://github.com/gitgitgadget/gitgitgadget/blob/main/res/WELCOME.md#welcome-to-gitgitgadget
[2] https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
[3] https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#closing-issues-automatically

Philippe.