From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, newren@gmail.com
Subject: [PATCH 1/3] t6437: run absorbgitdirs on repos
Date: Wed, 8 Sep 2021 11:18:13 -0700 [thread overview]
Message-ID: <942d3ce2d3cf96192c7e9d5860a18c333dd08acf.1631123754.git.jonathantanmy@google.com> (raw)
In-Reply-To: <cover.1631123754.git.jonathantanmy@google.com>
The submodule merge code is being transitioned away from
add_submodule_odb() to repo_submodule_init(), and the latter does not
support submodules that have their .git directories in the worktree
(instead of in .git/modules). Migrate the test code by calling
absorbgitdirs wherever necessary to place the .git directories of
submodules in .git/modules of the superproject.
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
t/t6437-submodule-merge.sh | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/t/t6437-submodule-merge.sh b/t/t6437-submodule-merge.sh
index e5e89c2045..8efce86b42 100755
--- a/t/t6437-submodule-merge.sh
+++ b/t/t6437-submodule-merge.sh
@@ -27,7 +27,8 @@ test_expect_success setup '
git add file &&
test_tick &&
git commit -m sub-root) &&
- git add sub &&
+ git submodule add ./sub sub &&
+ git submodule absorbgitdirs &&
test_tick &&
git commit -m root &&
@@ -82,7 +83,8 @@ test_expect_success 'setup for merge search' '
git branch sub-a) &&
git commit --allow-empty -m init &&
git branch init &&
- git add sub &&
+ git submodule add ./sub sub &&
+ git submodule absorbgitdirs &&
git commit -m "a" &&
git branch a &&
@@ -112,7 +114,8 @@ test_expect_success 'setup for merge search' '
git checkout -b g init &&
(cd sub &&
git checkout -b sub-g sub-c) &&
- git add sub &&
+ git submodule add ./sub sub &&
+ git submodule absorbgitdirs &&
git commit -a -m "g")
'
--
2.33.0.309.g3052b89438-goog
next prev parent reply other threads:[~2021-09-08 18:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 18:18 [PATCH 0/3] More add_submodule_odb() cleanup in merge code Jonathan Tan
2021-09-08 18:18 ` Jonathan Tan [this message]
2021-09-08 22:02 ` [PATCH 1/3] t6437: run absorbgitdirs on repos Jonathan Tan
2021-09-08 22:20 ` Junio C Hamano
2021-09-09 17:47 ` Jonathan Tan
2021-09-08 18:18 ` [PATCH 2/3] revision: remove "submodule" from opt struct Jonathan Tan
2021-09-08 18:18 ` [PATCH 3/3] DO NOT SUBMIT commit-reach,revision: verify non-mixing Jonathan Tan
2021-09-09 15:26 ` [PATCH 0/3] More add_submodule_odb() cleanup in merge code Elijah Newren
2021-09-09 17:51 ` Jonathan Tan
2021-09-09 18:47 ` [PATCH v2 " Jonathan Tan
2021-09-09 18:47 ` [PATCH v2 1/3] submodule: remove unnecessary unabsorbed fallback Jonathan Tan
2021-09-09 18:47 ` [PATCH v2 2/3] repository: support unabsorbed in repo_submodule_init Jonathan Tan
2021-09-09 18:47 ` [PATCH v2 3/3] revision: remove "submodule" from opt struct Jonathan Tan
2021-09-14 1:31 ` [PATCH v2 0/3] More add_submodule_odb() cleanup in merge code Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942d3ce2d3cf96192c7e9d5860a18c333dd08acf.1631123754.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).