* [PATCH] t4150: remove unused variable
@ 2019-03-12 14:38 Andrei Rybak
2019-03-13 2:10 ` Junio C Hamano
2019-03-13 14:47 ` Phillip Wood
0 siblings, 2 replies; 3+ messages in thread
From: Andrei Rybak @ 2019-03-12 14:38 UTC (permalink / raw)
To: git; +Cc: phillip.wood, s-beyer, Paul Tan, Junio C Hamano
In commit 735285b403 ("am: fix signoff when other trailers are present",
2017-08-08) tests using variable $signoff were rewritten and it is no
longer used, so just remove it from the test setup.
Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
---
t/t4150-am.sh | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/t/t4150-am.sh b/t/t4150-am.sh
index 55b577d919..3f7f750cc8 100755
--- a/t/t4150-am.sh
+++ b/t/t4150-am.sh
@@ -77,14 +77,12 @@ test_expect_success 'setup: messages' '
printf "Subject: " >subject-prefix &&
- cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF &&
+ cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF
This line should not be included in the commit message with --scissors enabled.
- - >8 - - remove everything above this line - - >8 - -
EOF
-
- signoff="Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>"
'
test_expect_success setup '
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t4150: remove unused variable
2019-03-12 14:38 [PATCH] t4150: remove unused variable Andrei Rybak
@ 2019-03-13 2:10 ` Junio C Hamano
2019-03-13 14:47 ` Phillip Wood
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2019-03-13 2:10 UTC (permalink / raw)
To: Andrei Rybak; +Cc: git, phillip.wood, s-beyer, Paul Tan
Andrei Rybak <rybak.a.v@gmail.com> writes:
> In commit 735285b403 ("am: fix signoff when other trailers are present",
> 2017-08-08) tests using variable $signoff were rewritten and it is no
> longer used, so just remove it from the test setup.
>
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
> t/t4150-am.sh | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Looks good; thanks.
>
> diff --git a/t/t4150-am.sh b/t/t4150-am.sh
> index 55b577d919..3f7f750cc8 100755
> --- a/t/t4150-am.sh
> +++ b/t/t4150-am.sh
> @@ -77,14 +77,12 @@ test_expect_success 'setup: messages' '
>
> printf "Subject: " >subject-prefix &&
>
> - cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF &&
> + cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF
> This line should not be included in the commit message with --scissors enabled.
>
> - - >8 - - remove everything above this line - - >8 - -
>
> EOF
> -
> - signoff="Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>"
> '
>
> test_expect_success setup '
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] t4150: remove unused variable
2019-03-12 14:38 [PATCH] t4150: remove unused variable Andrei Rybak
2019-03-13 2:10 ` Junio C Hamano
@ 2019-03-13 14:47 ` Phillip Wood
1 sibling, 0 replies; 3+ messages in thread
From: Phillip Wood @ 2019-03-13 14:47 UTC (permalink / raw)
To: Andrei Rybak, git; +Cc: phillip.wood, s-beyer, Paul Tan, Junio C Hamano
On 12/03/2019 14:38, Andrei Rybak wrote:
> In commit 735285b403 ("am: fix signoff when other trailers are present",
> 2017-08-08) tests using variable $signoff were rewritten and it is no
> longer used, so just remove it from the test setup.
Well spotted, thanks
Phillip
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
> t/t4150-am.sh | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/t/t4150-am.sh b/t/t4150-am.sh
> index 55b577d919..3f7f750cc8 100755
> --- a/t/t4150-am.sh
> +++ b/t/t4150-am.sh
> @@ -77,14 +77,12 @@ test_expect_success 'setup: messages' '
>
> printf "Subject: " >subject-prefix &&
>
> - cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF &&
> + cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF
> This line should not be included in the commit message with --scissors enabled.
>
> - - >8 - - remove everything above this line - - >8 - -
>
> EOF
> -
> - signoff="Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>"
> '
>
> test_expect_success setup '
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-13 14:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 14:38 [PATCH] t4150: remove unused variable Andrei Rybak
2019-03-13 2:10 ` Junio C Hamano
2019-03-13 14:47 ` Phillip Wood
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).