From: Derrick Stolee <stolee@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: Commit graph chains with no corresponding files?
Date: Mon, 29 Jun 2020 21:51:39 -0400 [thread overview]
Message-ID: <92b218ca-f2b4-db9d-9f9c-1d071ea4fa97@gmail.com> (raw)
In-Reply-To: <20200629220744.1054093-1-jonathantanmy@google.com>
On 6/29/2020 6:07 PM, Jonathan Tan wrote:
> At $DAYJOB, a few people have reported "warning: unable to find all
> commit-graph files" warnings. Their commit-graph-chain files have a few
> lines, but they only have one commit graph file with very few commits. I
> suspected something happening during fetch, because (as far as I know) a
> fetch may cause an incremental commit graph to be written, but I ran a
> fetch on a large repository myself and didn't run into this problem.
>
> Has anyone ran into this problem before, and know how to reproduce?
The incremental commit-graph code deletes any commit-graph files
that do not appear in the chain. I believe this is done by comparing
the contents of the ".git/objects/info/commit-graphs/" directory to
the contents of the chain file.
These appear to be case-sensitive, full-path comparisons.
It is _possible_ that something like a case switch or a symlink
could be causing a problem here. That's where I would look on
the affected systems.
Likely the full-path comparison in expire_commit_graphs() should
be dropped in favor of local filename comparisons. A case-
sensitive match is less likely to be important here since Git
is writing the paths itself and should get the proper case back
from the directory listing.
Thanks,
-Stolee
next prev parent reply other threads:[~2020-06-30 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 22:07 Commit graph chains with no corresponding files? Jonathan Tan
2020-06-30 1:51 ` Derrick Stolee [this message]
2020-07-16 22:57 ` [FYI] commit-graph: trace expiry of commit graph links Jonathan Tan
2021-02-25 4:54 ` Commit graph chains with no corresponding files? Bryan Turner
2021-02-25 14:20 ` Derrick Stolee
2021-02-27 2:49 ` Bryan Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92b218ca-f2b4-db9d-9f9c-1d071ea4fa97@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).