From: Kevin Ballard <kevin@sb.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PROPOSAL] .gitignore syntax modification
Date: Tue, 12 Oct 2010 20:05:19 -0700 [thread overview]
Message-ID: <91EEA44C-E519-4375-BD9E-68D5C3D7C4EE@sb.org> (raw)
In-Reply-To: <20101013024034.GA26483@burratino>
On Oct 12, 2010, at 7:40 PM, Jonathan Nieder wrote:
> Kevin Ballard wrote:
>> On Oct 12, 2010, at 7:24 PM, Nguyen Thai Ngoc Duy wrote:
>
>>> Special case "**/" (also "path/to/**/") is probably good enough. You
>>> might need to handle all combinations of "**/" and other optimizations
>>> in excluded_from_list() though. Can you make a patch (or a few
>>> patches) for it?
> [...]
>> At
>> this point I'm actually in favor of simply assuming all paths that
>> don't start with / can be matched at any level
>
> As a long-term change with early warnings and proper deprecation
> procedure that may (or may not) be an ok idea, but in the short
> term it is certainly a no-go.
>
> If linux-2.6 is any indication of what to expect, some projects are
> not using / in front of any paths with / at all.
Another possibility is using this new behavior for core.excludesfile and possibly .git/info/exclude, but not for patterns in .gitignore files. The benefit here is any existing project that uses .gitignore files will be unchanged, but global (and possibly repo-wide) patterns can benefit from the new behavior. The drawback is this would introduce a behavioral difference for patterns depending on which file they're in, which is probably not acceptable.
I will look into how much work is required to support **/ patterns without doing a wholesale replacement of fnmatch(). Hopefully it won't be infeasible.
-Kevin Ballard
next prev parent reply other threads:[~2010-10-13 3:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 21:26 [PROPOSAL] .gitignore syntax modification Kevin Ballard
2010-10-08 21:58 ` Maaartin
2010-10-09 0:03 ` Kevin Ballard
2010-10-11 23:46 ` Maaartin
2010-10-13 2:24 ` Nguyen Thai Ngoc Duy
2010-10-13 2:32 ` Kevin Ballard
2010-10-13 2:40 ` Jonathan Nieder
2010-10-13 3:05 ` Kevin Ballard [this message]
2010-10-13 16:51 ` Junio C Hamano
2010-10-13 12:15 ` Nguyen Thai Ngoc Duy
2010-10-15 11:01 ` Kevin Ballard
2010-10-15 12:57 ` Nguyen Thai Ngoc Duy
2010-10-15 20:15 ` Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91EEA44C-E519-4375-BD9E-68D5C3D7C4EE@sb.org \
--to=kevin@sb.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).