From: Derrick Stolee <stolee@gmail.com>
To: "René Scharfe" <l.s.r@web.de>, "Git Mailing List" <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Chris Torek <chris.torek@gmail.com>
Subject: Re: [PATCH] midx: use buffered I/O to talk to pack-objects
Date: Mon, 3 Aug 2020 08:39:05 -0400 [thread overview]
Message-ID: <90541678-f412-89a1-2ee0-4cae30e26551@gmail.com> (raw)
In-Reply-To: <c5920e08-b7dd-e870-f99e-225d0aafc663@web.de>
On 8/2/2020 10:38 AM, René Scharfe wrote:
> Like f0bca72dc77 (send-pack: use buffered I/O to talk to pack-objects,
> 2016-06-08), significantly reduce the number of system calls and
> simplify the code for sending object IDs to pack-objects by using
> stdio's buffering and handling errors after the loop.
Good find. Thanks for doing this important cleanup.
Outside of Chris's other feedback, this looks like an obviously
correct transformation.
Thanks,
-Stolee
next prev parent reply other threads:[~2020-08-03 12:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 14:38 [PATCH] midx: use buffered I/O to talk to pack-objects René Scharfe
2020-08-02 16:11 ` Chris Torek
2020-08-03 18:10 ` Johannes Sixt
2020-08-03 22:27 ` René Scharfe
2020-08-04 4:31 ` René Scharfe
2020-08-04 4:37 ` Junio C Hamano
2020-08-03 12:39 ` Derrick Stolee [this message]
2020-08-11 16:08 ` René Scharfe
2020-08-11 17:14 ` Derrick Stolee
2020-08-12 16:52 ` [PATCH v2] " René Scharfe
2020-08-12 20:28 ` Junio C Hamano
2020-08-12 20:31 ` Junio C Hamano
2020-08-13 9:11 ` Jeff King
2020-08-13 9:06 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90541678-f412-89a1-2ee0-4cae30e26551@gmail.com \
--to=stolee@gmail.com \
--cc=chris.torek@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).