* [PATCH] commit-graph-format.txt: fix no-parent value
@ 2020-09-15 4:03 Conor Davis via GitGitGadget
2020-09-15 4:26 ` Taylor Blau
0 siblings, 1 reply; 4+ messages in thread
From: Conor Davis via GitGitGadget @ 2020-09-15 4:03 UTC (permalink / raw)
To: git; +Cc: Conor Davis, Conor Davis
From: Conor Davis <git@conor.fastmail.fm>
The correct value from commit-graph.c:
#define GRAPH_PARENT_NONE 0x70000000
Signed-off-by: Conor Davis <git@conor.fastmail.fm>
---
commit-graph-format.txt: fix no-parent value
The correct value from commit-graph.c:
#define GRAPH_PARENT_NONE 0x70000000
Signed-off-by: Conor Davis git@conor.fastmail.fm [git@conor.fastmail.fm]
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-733%2Favoidscorn%2Fgraph-parent-none-doc-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-733/avoidscorn/graph-parent-none-doc-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/733
Documentation/technical/commit-graph-format.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/technical/commit-graph-format.txt b/Documentation/technical/commit-graph-format.txt
index 1beef17182..002a480c9c 100644
--- a/Documentation/technical/commit-graph-format.txt
+++ b/Documentation/technical/commit-graph-format.txt
@@ -77,7 +77,7 @@ CHUNK DATA:
Commit Data (ID: {'C', 'D', 'A', 'T' }) (N * (H + 16) bytes)
* The first H bytes are for the OID of the root tree.
* The next 8 bytes are for the positions of the first two parents
- of the ith commit. Stores value 0x7000000 if no parent in that
+ of the ith commit. Stores value 0x70000000 if no parent in that
position. If there are more than two parents, the second value
has its most-significant bit on and the other bits store an array
position into the Extra Edge List chunk.
base-commit: 47ae905ffb98cc4d4fd90083da6bc8dab55d9ecc
--
gitgitgadget
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] commit-graph-format.txt: fix no-parent value
2020-09-15 4:03 [PATCH] commit-graph-format.txt: fix no-parent value Conor Davis via GitGitGadget
@ 2020-09-15 4:26 ` Taylor Blau
2020-09-15 12:16 ` Derrick Stolee
0 siblings, 1 reply; 4+ messages in thread
From: Taylor Blau @ 2020-09-15 4:26 UTC (permalink / raw)
To: Conor Davis via GitGitGadget; +Cc: git, Conor Davis
Hi Conor,
On Tue, Sep 15, 2020 at 04:03:53AM +0000, Conor Davis via GitGitGadget wrote:
> - of the ith commit. Stores value 0x7000000 if no parent in that
> + of the ith commit. Stores value 0x70000000 if no parent in that
Thnaks for fixing this up. This dates back to a9aa3c0927 (commit-graph:
fix documentation inconsistencies, 2018-06-28) which mentions the
correct value in the commit message, but uses the incorrect value in the
patch itself.
For what it's worth, I can hardly blame the author of a9aa3c0927, since
I had to flip back and forth between the two a couple of times to
convince myself which one was which.
Anyway, this is obviously correct. Thank you for your contribution!
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Thanks,
Taylor
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] commit-graph-format.txt: fix no-parent value
2020-09-15 4:26 ` Taylor Blau
@ 2020-09-15 12:16 ` Derrick Stolee
2020-09-15 23:12 ` Conor Davis
0 siblings, 1 reply; 4+ messages in thread
From: Derrick Stolee @ 2020-09-15 12:16 UTC (permalink / raw)
To: Taylor Blau, Conor Davis via GitGitGadget; +Cc: git, Conor Davis
On 9/15/2020 12:26 AM, Taylor Blau wrote:
> For what it's worth, I can hardly blame the author of a9aa3c0927,
I can!
Thanks for noticing the doc bug. May I ask why you were looking
at the format document so closely? Are you working on a new
implementation?
Thanks,
-Stolee
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] commit-graph-format.txt: fix no-parent value
2020-09-15 12:16 ` Derrick Stolee
@ 2020-09-15 23:12 ` Conor Davis
0 siblings, 0 replies; 4+ messages in thread
From: Conor Davis @ 2020-09-15 23:12 UTC (permalink / raw)
To: git
On 9/15/20 7:16 AM, Derrick Stolee wrote:
> On 9/15/2020 12:26 AM, Taylor Blau wrote:
>> For what it's worth, I can hardly blame the author of a9aa3c0927,
> I can!
>
> Thanks for noticing the doc bug. May I ask why you were looking
> at the format document so closely? Are you working on a new
> implementation?
Yes, I'm adding commit-graph support to gitoxide:
https://github.com/Byron/gitoxide/pull/21
-Conor
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-15 23:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 4:03 [PATCH] commit-graph-format.txt: fix no-parent value Conor Davis via GitGitGadget
2020-09-15 4:26 ` Taylor Blau
2020-09-15 12:16 ` Derrick Stolee
2020-09-15 23:12 ` Conor Davis
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).