git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: rs/strbuf-addftime-zZ, was Re: What's cooking in git.git (Jun 2017, #04; Tue, 13)
Date: Thu, 15 Jun 2017 10:46:00 +0200	[thread overview]
Message-ID: <8fc457ea-393b-37fe-c033-beec4128e781@web.de> (raw)
In-Reply-To: <20170615054209.yfucmiq3pghxu76j@sigill.intra.peff.net>

Am 15.06.2017 um 07:42 schrieb Jeff King:
> On Thu, Jun 15, 2017 at 01:03:29AM +0200, René Scharfe wrote:
>> But there's more.  strftime on Windows doesn't support common POSIX-
>> defined tokens like %F (%Y-%m-%d) and %T (%H:%M:%S). We could handle
>> them as well.  Do we want that?  At least we'd have to update the
>> added test that uses them..
>>
>> Here's the full list of tokens in POSIX [1], but not supported by
>> Windows [2]: %C, %D, %F, %G, %R, %T, %V, %e, %g, %h, %n, %r, %t, %u
>> plus the modifiers %E and %O.
> 
> I don't have a real opinion on that. The point of adding strftime was
> always to give the user access to whatever their system supports. In
> particular "%c" which we cannot emulate ourselves.
> 
> If people want support for those other things on platforms that don't
> have it, I have no real objection. But I also don't know that it's worth
> spending time on if nobody is asking for it.

Agreed; let's make the tests more focused (i.e. not exercise %F and %T
needlessly).

René

  reply	other threads:[~2017-06-15  8:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 21:40 What's cooking in git.git (Jun 2017, #04; Tue, 13) Junio C Hamano
2017-06-14  0:52 ` Jonathan Nieder
2017-06-15 15:54   ` Junio C Hamano
2017-06-14  7:42 ` Lars Schneider
2017-06-14 18:38   ` Torsten Bögershausen
2017-06-14 10:57 ` rs/strbuf-addftime-zZ, was " Johannes Schindelin
2017-06-14 11:10   ` Jeff King
2017-06-14 19:36     ` René Scharfe
2017-06-14 21:04       ` Johannes Schindelin
2017-06-14 23:03         ` René Scharfe
2017-06-15  5:42           ` Jeff King
2017-06-15  8:46             ` René Scharfe [this message]
2017-06-14 18:23   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fc457ea-393b-37fe-c033-beec4128e781@web.de \
    --to=l.s.r@web.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).