From: Derrick Stolee <stolee@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Mike Hommey" <mh@glandium.org>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
git@vger.kernel.org
Subject: Re: [RFC/PATCH] commit-graph: generation v5 (backward compatible date ceiling)
Date: Wed, 18 Sep 2019 08:26:41 -0400 [thread overview]
Message-ID: <8fba9eb7-934f-9b4e-f898-bab099b95ede@gmail.com> (raw)
In-Reply-To: <86o8ziatb2.fsf_-_@gmail.com>
On 9/18/2019 4:43 AM, Jakub Narebski wrote:
> Derrick Stolee <stolee@gmail.com> writes:
>> On 6/25/2019 3:51 AM, Jakub Narebski wrote:
>>> Jakub Narebski <jnareb@gmail.com> writes:
>>>> Derrick Stolee <stolee@gmail.com> writes:
> [...]
>>>> O.K., so the "generation number v2 (legacy)" would be incremental and
>>>> backward-compatibile in use (though not in generation and validation).
> [...]
>>>> Do you have benchmark for this "monotonically offset corrected commit
>>>> date" generation number in https://github.com/derrickstolee/git/commits/reach-perf
>>>> and https://github.com/derrickstolee/gen-test ?
>>>
>>> I guess this will have to wait...
>>
>> I have not had time to revisit this topic and re-run performance
>> numbers, sorry.
>
> I have created pull requests against `reach-perf` branch of
> derrickstolee/git repository[1], and companion pull request against
> gen-test repository[2] with proposed prototype of backward-compatible
> corrected commit date (with monotonic offsets).
>
> Could you please run the tests for this generation number v5?
I'll try to get to this, but it may take a few days.
> I was not
> able to do so. It was my first time trying to compile Git on MS
> Windows, and while there were no problems compiling `master` (well,
> except for compilation taking a long time), I was unable to do it for
> `reach-perf` branch because of independent of change compilation errors.
I don't think I tested this on Windows. I do most of my performance tests
in Linux, especially when presenting numbers to the mailing list. The
gen-test repo has a bunch of shell scripts that I used for testing in
that environment.
Thanks,
-Stolee
next prev parent reply other threads:[~2019-09-18 12:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 0:54 Revision walking, commit dates, slop Mike Hommey
2019-05-18 1:50 ` SZEDER Gábor
2019-05-18 3:58 ` Mike Hommey
2019-05-18 4:17 ` Mike Hommey
2019-05-18 12:01 ` SZEDER Gábor
2019-05-19 22:28 ` Jakub Narebski
2019-05-20 1:33 ` Derrick Stolee
2019-05-20 11:02 ` Jakub Narebski
2019-05-20 11:20 ` Derrick Stolee
2019-05-20 13:42 ` Jakub Narebski
2019-05-20 23:27 ` Jakub Narebski
2019-05-21 1:20 ` Derrick Stolee
2019-05-22 18:29 ` Jakub Narebski
2019-05-22 19:06 ` Derrick Stolee
2019-05-23 21:04 ` Jakub Narebski
2019-06-25 7:51 ` Jakub Narebski
2019-06-25 10:54 ` Derrick Stolee
2019-09-18 8:43 ` [RFC/PATCH] commit-graph: generation v5 (backward compatible date ceiling) Jakub Narebski
2019-09-18 12:26 ` Derrick Stolee [this message]
2019-05-21 13:14 ` [PATCH] revision: use generation for A..B --topo-order queries Derrick Stolee
2019-05-21 13:59 ` [PATCH 2/2] revision: keep topo-walk free of unintersting commits Derrick Stolee
2019-05-22 2:19 ` Mike Hommey
2019-05-21 2:00 ` Revision walking, commit dates, slop Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fba9eb7-934f-9b4e-f898-bab099b95ede@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=mh@glandium.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).