From: Derrick Stolee <stolee@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH 2/2] read-cache: fix incorrect count and progress bar stalling
Date: Mon, 7 Jun 2021 11:31:00 -0400 [thread overview]
Message-ID: <8f336b1b-6cb7-8277-79d5-0f331159b00c@gmail.com> (raw)
In-Reply-To: <patch-2.2-042f598826-20210607T144206Z-avarab@gmail.com>
On 6/7/2021 10:43 AM, Ævar Arnfjörð Bjarmason wrote:
> Fix a potential incorrect display of the number of items (off by one)
> and stalling of the progress bar in refresh_index().
>
> The off-by-one error is minor, we should say we're processing the 1st
> item, not the 0th. This along with the next change also allows us to
> remove the last display_progress() call outside the loop, as we'll
> always have reached 100% now.
This "pre-announce the progress" seems correct and is unlikely
to have a user sitting at "100%" while the loop is actually doing
work on that last cache entry.
Thanks,
-Stolee
next prev parent reply other threads:[~2021-06-07 15:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 14:43 [PATCH 0/2] trivial progress.c API usage fixes Ævar Arnfjörð Bjarmason
2021-06-07 14:43 ` [PATCH 1/2] read-cache.c: don't guard calls to progress.c API Ævar Arnfjörð Bjarmason
2021-06-07 15:28 ` Derrick Stolee
2021-06-07 15:52 ` Ævar Arnfjörð Bjarmason
2021-06-07 16:11 ` Derrick Stolee
2021-06-07 14:43 ` [PATCH 2/2] read-cache: fix incorrect count and progress bar stalling Ævar Arnfjörð Bjarmason
2021-06-07 15:31 ` Derrick Stolee [this message]
2021-06-07 15:58 ` Ævar Arnfjörð Bjarmason
2021-06-07 19:20 ` René Scharfe
2021-06-07 19:49 ` Ævar Arnfjörð Bjarmason
2021-06-07 23:41 ` Junio C Hamano
2021-06-08 10:58 ` Ævar Arnfjörð Bjarmason
2021-06-08 16:14 ` René Scharfe
2021-06-08 22:12 ` Ævar Arnfjörð Bjarmason
2021-06-10 5:30 ` Junio C Hamano
2021-06-10 15:14 ` René Scharfe
2021-06-10 15:14 ` René Scharfe
2021-06-14 11:07 ` Ævar Arnfjörð Bjarmason
2021-06-14 17:18 ` René Scharfe
2021-06-14 19:08 ` Ævar Arnfjörð Bjarmason
2021-06-15 2:32 ` Junio C Hamano
2021-06-15 15:14 ` René Scharfe
2021-06-15 16:46 ` Ævar Arnfjörð Bjarmason
2021-06-20 12:53 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f336b1b-6cb7-8277-79d5-0f331159b00c@gmail.com \
--to=stolee@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).