From: jaydeepjd.8914@gmail.com
To: Johannes Sixt <j6t@kdbg.org>, git@vger.kernel.org
Subject: Re: [PATCH v5] userdiff: add builtin diff driver for kotlin language.
Date: Thu, 10 Mar 2022 16:22:05 +0530 [thread overview]
Message-ID: <8d411f30-bfe9-ffbe-5ec5-1ae7b5c9588f@gmail.com> (raw)
In-Reply-To: <72aca675-4c65-36bf-1337-34b2d1f40bb4@kdbg.org>
Sorry for the late reply.
On 3/9/22 12:02 AM, Johannes Sixt <j6t@kdbg.org> wrote:
> Am 08.03.22 um 17:54 schrieb jaydeepjd.8914@gmail.com:
> > So, the final regexes are these, right?:
>
> Not quite.
>
> >
> > "[a-zA-Z_][a-zA-Z0-9_]*"
> > /* hexadecimal and binary numbers */
> > "|0[xXbB][0-9a-fA-F_]+[lLuU]*"
> > /* integers and floats */
> > "|[0-9][.]?[0-9_]+([Ee][-+]?[0-9]+)?[fFlLuU]*"
>
> This would not match 12.5 because you allow only a single digit before
> the decimal point. Perhaps
>
> "|[0-9][.0-9_]*([Ee][-+]?[0-9]+)?[fFlLuU]*"
Okay.
> > /* floating point numbers beginning with decimal point */
> > "|[.][0-9][0-9_]*([Ee][-+]?[0-9]+)?[fFlL]?"
> > /* unary and binary operators */
> >
> > "|[-+*/<>%&^|=!]?==?|--|\\+\\+|<<=|>>=|&&|[||]|->|\\.\\*|!!|::|[?:.][.:]"),
>
> [||] does not work as you intend. A new suggestion: do not start with an
> initial optional character in order to reduce the number of
> backtrackings that the regular expression evaluation has to do. I would
> write this line as
>
> "|[-+*/<>%&^|=!]==?|--|\\+\\+|<<=|>>=|&&|\\|\\||->|\\.\\*|!!|::|[?:.][.:]"),
>
> BTW which operators are handled by "[?:.][.:]"? I'm asking because you
> list :: separatly that would also be matched by this sub-expression.
It matches the following operators: `?:`, `?.`, `..` `::`. Although matching `::` is
unnecessary since its matched before.
https://kotlinlang.org/docs/keyword-reference.html#operators-and-special-symbols
next prev parent reply other threads:[~2022-03-10 10:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 7:02 [GSoC][PATCH] userdiff: Add diff driver for Kotlin lang and tests Jaydeep P Das
2022-03-01 7:02 ` [PATCH] " Jaydeep P Das
2022-03-01 9:32 ` Junio C Hamano
2022-03-01 9:37 ` Ævar Arnfjörð Bjarmason
2022-03-01 10:27 ` jaydeepjd.8914
2022-03-01 15:54 ` [PATCH] userdiff: add builtin diff driver for Kotlin language Jaydeep P Das
2022-03-01 17:17 ` Junio C Hamano
2022-03-01 18:09 ` jaydeepjd.8914
2022-03-01 19:59 ` Johannes Sixt
2022-03-01 19:47 ` Johannes Sixt
2022-03-02 6:45 ` [GSoC][PATCHv2] userdiff: add builtin driver for kotlin language Jaydeep P Das
2022-03-02 6:45 ` [PATCH] " Jaydeep P Das
2022-03-02 8:00 ` Johannes Sixt
2022-03-02 9:09 ` jaydeepjd.8914
2022-03-02 9:28 ` jaydeepjd.8914
2022-03-02 14:26 ` [GSoC][PATCHv3] " Jaydeep P Das
2022-03-02 14:26 ` [PATCH] " Jaydeep P Das
2022-03-02 20:18 ` Johannes Sixt
2022-03-03 11:41 ` Jaydeep Das
2022-03-03 16:54 ` Ævar Arnfjörð Bjarmason
2022-03-03 19:47 ` Junio C Hamano
2022-03-03 20:04 ` Johannes Sixt
2022-03-04 12:28 ` Jaydeep Das
2022-03-04 13:59 ` Johannes Sixt
2022-03-03 18:15 ` [PATCH] userdiff: add builtin diff driver for Kotlin language Jaydeep P Das
2022-03-04 2:44 ` Junio C Hamano
2022-03-04 5:16 ` jaydeepjd.8914
2022-03-04 7:25 ` Johannes Sixt
2022-03-05 9:40 ` [PATCH v4] " Jaydeep P Das
2022-03-05 14:17 ` Johannes Sixt
2022-03-05 19:18 ` jaydeepjd.8914
2022-03-05 22:17 ` Johannes Sixt
2022-03-06 11:15 ` [PATCH v5] userdiff: add builtin diff driver for kotlin language Jaydeep P Das
2022-03-07 7:07 ` Johannes Sixt
2022-03-08 16:54 ` jaydeepjd.8914
2022-03-08 18:32 ` Johannes Sixt
2022-03-10 10:52 ` jaydeepjd.8914 [this message]
2022-03-10 16:29 ` Jaydeep Das
2022-03-10 19:11 ` Johannes Sixt
2022-03-11 7:27 ` [PATCH v6] " Jaydeep P Das
2022-03-11 20:07 ` Johannes Sixt
2022-03-12 4:36 ` jaydeepjd.8914
2022-03-12 8:36 ` Johannes Sixt
2022-03-12 4:48 ` [PATCH v7] " Jaydeep P Das
2022-03-12 8:59 ` Johannes Sixt
2022-03-13 17:02 ` jaydeepjd.8914
2022-03-13 17:09 ` jaydeepjd.8914
2022-03-13 21:36 ` Johannes Sixt
[not found] <20220301070226.2477769-1-jaydeepjd.8914>
2022-03-06 11:10 ` Jaydeep P Das
2022-03-06 11:10 ` [PATCH v5] userdiff: add builtin diff driver for kotlin language Jaydeep P Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d411f30-bfe9-ffbe-5ec5-1ae7b5c9588f@gmail.com \
--to=jaydeepjd.8914@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).