From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B121E1F44D for ; Mon, 11 Mar 2024 23:21:36 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=pks.im header.i=@pks.im header.a=rsa-sha256 header.s=fm1 header.b=dW2wRkwt; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=WnM8EjLO; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 24FC71F22483 for ; Mon, 11 Mar 2024 23:21:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89C5058ACF; Mon, 11 Mar 2024 23:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="dW2wRkwt"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="WnM8EjLO" Received: from fout2-smtp.messagingengine.com (fout2-smtp.messagingengine.com [103.168.172.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C0156B99 for ; Mon, 11 Mar 2024 23:20:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.145 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710199257; cv=none; b=m9yEMl/r6MdByVGvNcIrwrfd5IkpZoTO1h4zWEbyhhFx6PoIVEnUwEaobm3qoRwCQoGLPBX5uYW6HxG1/g5m+xBFCkJLtbhpytrn9xSnkkuYYiMEIOXabdZDB+0tOsA+wqJzQ9qpHOL79wAcH9XSRc/MeRmF7rXB9lNYWW55wgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710199257; c=relaxed/simple; bh=wK+qgLqsU+lAK0ZSXk8aSr8+OmTE36zeq26C402sS4o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HxHhPxRx/S53Qmnc22QVQj8PBmbRzXRf4QaaHCh/7Pm08FouZWI2V9vBajd41WiyMmjLJoxrOgctK/nOXdjgjRU4UjA8yCT4HVfj7R/wwzKFyxAxP4EDpTljGKOjPffGDJIF4fWExucpljTau4i35eeMlG40Af7j8V/pHg8b3oM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im; spf=pass smtp.mailfrom=pks.im; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b=dW2wRkwt; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=WnM8EjLO; arc=none smtp.client-ip=103.168.172.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id ECE8E13800C5; Mon, 11 Mar 2024 19:20:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 11 Mar 2024 19:20:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1710199253; x=1710285653; bh=fsgeKa3HJ1 R+XpIyG8X4y/oJkf7k4brZi0CYFnJ2Mrw=; b=dW2wRkwta9qtzpPTMugmVMKu76 rKPgDhDRKfwm9OkU322YJuIlg6n8AS2sCw4VOm3CCBGle8MEzW+1Exh3M0zpJ5uF PGNbcNAa/X+y/EXzhvrIpB5XQZ1JtvN+gxVkDANZQKoy2qW/xy3tqLDokbQ6xbtL mBgJsSJnwN0wIUKGMs+p55LiygOE8O7JBJdog+cR4x53td4f1U+i1wUbkj5Ytkcl 2RQwcjawkznziY3TMXEdZFJ+Um4LqLMoTR3kGHT3Nt580Z5sBfBEDrWigTIDQZI2 rmN8zq7lyprDH+tdz0fmq8NfUFPQvdEegAlxjOjUG9w+H8mJyRmocUfd4cLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1710199253; x=1710285653; bh=fsgeKa3HJ1R+XpIyG8X4y/oJkf7k 4brZi0CYFnJ2Mrw=; b=WnM8EjLOCNvq1bpVCX4MAdRYvsgT31naJw06kpbFib55 /OBd23Vs2luWsoV+Te5NNSqywfLhgOTp0iRjhgutBraLfcM9/JlV/TfjXbxwFVL7 ioddOhX63p23wPDRJBbjICn0CXUzCXK1WSvftOt4WNfaLmfoPqE+pJPuyFsvHxUy jGSdK1B74P81vsNJldCRUzgvaDuiV0bMoXj+Z/pQoJglJTg6jXK48IEia2DulTYO 7eLRL7Her2izngjnSBsJg7albM89K7Dv86TorWq2huhzjlmZ3lbs9qc4H5RAXq0e bXzsdSkKKfRRqkiMDvlfjV0OKwrLUXyTHPK6CN+syw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrjedvgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuh hsvghruchinhculhhinhhkucdliedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehg tderredttddvnecuhfhrohhmpefrrghtrhhitghkucfuthgvihhnhhgrrhguthcuoehpsh esphhkshdrihhmqeenucggtffrrghtthgvrhhnpedugfeltdeutddvhfelhfeffeejgffg jedvhefhkeegveellefhheeiiefftdfgudenucffohhmrghinhepughifhhfrdhnvgifpd hkvghrnhgvlhdrohhrghdpvgigrghmphhlvgdrtghomhdpvgigrghmphhlvgdrohhrghen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpshesph hkshdrihhm X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Mar 2024 19:20:52 -0400 (EDT) Received: by vm-mail (OpenSMTPD) with ESMTPSA id 61ccf11d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 11 Mar 2024 23:16:13 +0000 (UTC) Date: Tue, 12 Mar 2024 00:20:46 +0100 From: Patrick Steinhardt To: git@vger.kernel.org Cc: Kristoffer Haugsbakk , Taylor Blau , =?iso-8859-1?Q?Jean-No=EBl?= AVILA , Eric Sunshine , Junio C Hamano Subject: [PATCH v2 07/13] builtin/config: introduce "get" subcommand Message-ID: <8ceced0fc58e9b4cf1c5e5b678e864f82c1b8c01.1710198711.git.ps@pks.im> References: Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sbclfVtyAbHvwIjV" Content-Disposition: inline In-Reply-To: --sbclfVtyAbHvwIjV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Introduce a new "get" subcommand to git-config(1). Please refer to preceding commits regarding the motivation behind this change. Signed-off-by: Patrick Steinhardt --- Documentation/git-config.txt | 89 +++++++++++++------------ builtin/config.c | 69 ++++++++++++++++--- t/t1300-config.sh | 125 ++++++++++++++++++++++++----------- 3 files changed, 192 insertions(+), 91 deletions(-) diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index 976ba26757..f3d5e3e613 100644 --- a/Documentation/git-config.txt +++ b/Documentation/git-config.txt @@ -10,18 +10,14 @@ SYNOPSIS -------- [verse] 'git config list' [] [] [--includes] +'git config get' [] [] [--includes] [--all] [= --regexp=3D] [--value=3D] [--fixed-value] [--default=3D] 'git config' [] [--type=3D] [--fixed-value] [--show-ori= gin] [--show-scope] [-z|--null] [ []] 'git config' [] [--type=3D] --add 'git config' [] [--type=3D] [--fixed-value] --replace-a= ll [] -'git config' [] [--type=3D] [--show-origin] [--show-sco= pe] [-z|--null] [--fixed-value] --get [] -'git config' [] [--type=3D] [--show-origin] [--show-sco= pe] [-z|--null] [--fixed-value] --get-all [] -'git config' [] [--type=3D] [--show-origin] [--show-sco= pe] [-z|--null] [--fixed-value] [--name-only] --get-regexp [] -'git config' [] [--type=3D] [-z|--null] --get-urlmatch = 'git config' [] [--fixed-value] --unset [] 'git config' [] [--fixed-value] --unset-all [] 'git config' [] --rename-section 'git config' [] --remove-section -'git config' [] --get-color [] 'git config' [] --get-colorbool [] 'git config' [] -e | --edit =20 @@ -80,6 +76,12 @@ COMMANDS list:: List all variables set in config file, along with their values. =20 +get:: + Get value for one or more config options. Values can be filtered by + regexes and URLs.Returns error code 1 if the key was not found and the + last value if multiple key values were found. If `--all` is set, then + all values will be shown. + [[OPTIONS]] OPTIONS ------- @@ -93,22 +95,16 @@ OPTIONS values. This is the same as providing '^$' as the `value-pattern` in `--replace-all`. =20 ---get:: - Get the value for a given key (optionally filtered by a regex - matching the value). Returns error code 1 if the key was not - found and the last value if multiple key values were found. - ---get-all:: - Like get, but returns all values for a multi-valued key. +--all:: + With "get", Return all values for a multi-valued key. =20 ---get-regexp:: - Like --get-all, but interprets the name as a regular expression and - writes out the key names. Regular expression matching is currently - case-sensitive and done against a canonicalized version of the key - in which section and variable names are lowercased, but subsection - names are not. +---regexp:: + With "get", interpret the name as a regular expression. Regular + expression matching is currently case-sensitive and done against a + canonicalized version of the key in which section and variable names + are lowercased, but subsection names are not. =20 ---get-urlmatch :: +--url=3D:: When given a two-part as
., the value for
.. whose part matches the best to the given URL is returned (if no such key exists, the value for @@ -239,7 +235,7 @@ Valid ``'s include: =20 --name-only:: Output only the names of config variables for `list` or - `--get-regexp`. + `get`. =20 --show-origin:: Augment the output of all queried config options with the @@ -263,17 +259,6 @@ Valid ``'s include: When the color setting for `name` is undefined, the command uses `color.ui` as fallback. =20 ---get-color []:: - - Find the color configured for `name` (e.g. `color.diff.new`) and - output it as the ANSI color escape sequence to the standard - output. The optional `default` parameter is used instead, if - there is no color configured for `name`. -+ -`--type=3Dcolor [--default=3D]` is preferred over `--get-color` -(but note that `--get-color` will omit the trailing newline printed by -`--type=3Dcolor`). - -e:: --edit:: Opens an editor to modify the specified config file; either @@ -286,7 +271,7 @@ Valid ``'s include: config files. =20 --default :: - When using `--get`, and the requested variable is not found, behave as if + When using `get`, and the requested variable is not found, behave as if were the value assigned to the that variable. =20 DEPRECATED MODES @@ -295,15 +280,33 @@ DEPRECATED MODES The following modes have been deprecated in favor of subcommands. It is recommended to migrate to the new syntax. =20 +'git config ':: + Replaced by `git config get `. + -l:: --list:: Replaced by `git config list`. =20 +--get []:: + Replaced by `git config get [--value=3D] `. + +--get-all []:: + Replaced by `git config get [--value=3D] --all --show-names `. + +--get-regexp :: + Replaced by `git config get --all --show-names --regexp `. + +--get-urlmatch :: + Replaced by `git config get --all --show-names --url=3D `. + +--get-color []:: + Replaced by `git config get --type=3Dcolor [--default=3D] = `. + CONFIGURATION ------------- `pager.config` is only respected when listing configuration, i.e., when -using `list` or any of the `--get-*` which may return multiple results. -The default is to use a pager. +using `list` or `get` which may return multiple results. The default is to= use +a pager. =20 [[FILES]] FILES @@ -506,25 +509,25 @@ you have to provide a regex matching the value of exa= ctly one line. To query the value for a given key, do =20 ------------ -% git config --get core.filemode +% git config get core.filemode ------------ =20 or =20 ------------ -% git config core.filemode +% git config get core.filemode ------------ =20 or, to query a multivar: =20 ------------ -% git config --get core.gitproxy "for kernel.org$" +% git config get --value=3D"for kernel.org$" core.gitproxy ------------ =20 If you want to know all the values for a multivar, do: =20 ------------ -% git config --get-all core.gitproxy +% git config get --all --show-names core.gitproxy ------------ =20 If you like to live dangerously, you can replace *all* core.gitproxy by a @@ -558,8 +561,8 @@ script: =20 ------------ #!/bin/sh -WS=3D$(git config --get-color color.diff.whitespace "blue reverse") -RESET=3D$(git config --get-color "" "reset") +WS=3D$(git config get --type=3Dcolor --default=3D"blue reverse" color.diff= =2Ewhitespace) +RESET=3D$(git config get --type=3Dcolor --default=3D"reset" "") echo "${WS}your whitespace color or blue reverse${RESET}" ------------ =20 @@ -567,11 +570,11 @@ For URLs in `https://weak.example.com`, `http.sslVeri= fy` is set to false, while it is set to `true` for all others: =20 ------------ -% git config --type=3Dbool --get-urlmatch http.sslverify https://good.exam= ple.com +% git config get --type=3Dbool --url=3Dhttps://good.example.com http.sslve= rify true -% git config --type=3Dbool --get-urlmatch http.sslverify https://weak.exam= ple.com +% git config get --type=3Dbool --url=3Dhttps://weak.example.com http.sslve= rify false -% git config --get-urlmatch http https://weak.example.com +% git config get --url=3Dhttps://weak.example.com http http.cookieFile /tmp/cookie.txt http.sslverify false ------------ diff --git a/builtin/config.c b/builtin/config.c index ee7ac9381e..aaa8b15e86 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -17,7 +17,7 @@ =20 static const char *const builtin_config_usage[] =3D { N_("git config list [] [] [--includes]"), - N_("git config []"), + N_("git config get [] [] [--includes] [--all= ] [--regexp=3D] [--value=3D] [--fixed-value] [--default=3D] "), NULL }; =20 @@ -26,6 +26,11 @@ static const char *const builtin_config_list_usage[] =3D= { NULL }; =20 +static const char *const builtin_config_get_usage[] =3D { + N_("git config get [] [] [--includes] [--all= ] [--regexp=3D] [--value=3D] [--fixed-value] [--default=3D] "), + NULL +}; + static char *key; static regex_t *key_regexp; static const char *value_pattern; @@ -721,6 +726,16 @@ static void handle_nul(void) { OPT_STRING('f', "file", &given_config_source.file, N_("file"), N_("use gi= ven config file")), \ OPT_STRING(0, "blob", &given_config_source.blob, N_("blob-id"), N_("read = config from given blob object")) =20 +#define CONFIG_TYPE_OPTIONS \ + OPT_GROUP(N_("Type")), \ + OPT_CALLBACK('t', "type", &type, N_("type"), N_("value is given this type= "), option_parse_type), \ + OPT_CALLBACK_VALUE(0, "bool", &type, N_("value is \"true\" or \"false\"")= , TYPE_BOOL), \ + OPT_CALLBACK_VALUE(0, "int", &type, N_("value is decimal number"), TYPE_I= NT), \ + OPT_CALLBACK_VALUE(0, "bool-or-int", &type, N_("value is --bool or --int"= ), TYPE_BOOL_OR_INT), \ + OPT_CALLBACK_VALUE(0, "bool-or-str", &type, N_("value is --bool or string= "), TYPE_BOOL_OR_STR), \ + OPT_CALLBACK_VALUE(0, "path", &type, N_("value is a path (file or directo= ry name)"), TYPE_PATH), \ + OPT_CALLBACK_VALUE(0, "expiry-date", &type, N_("value is an expiry date")= , TYPE_EXPIRY_DATE) + #define CONFIG_DISPLAY_OPTIONS \ OPT_GROUP(N_("Display options")), \ OPT_BOOL('z', "null", &end_nul, N_("terminate values with NUL byte")), \ @@ -745,14 +760,7 @@ static struct option builtin_config_options[] =3D { OPT_CMDMODE('e', "edit", &actions, N_("open an editor"), ACTION_EDIT), OPT_CMDMODE(0, "get-color", &actions, N_("find the color configured: slot= []"), ACTION_GET_COLOR), OPT_CMDMODE(0, "get-colorbool", &actions, N_("find the color setting: slo= t []"), ACTION_GET_COLORBOOL), - OPT_GROUP(N_("Type")), - OPT_CALLBACK('t', "type", &type, N_("type"), N_("value is given this type= "), option_parse_type), - OPT_CALLBACK_VALUE(0, "bool", &type, N_("value is \"true\" or \"false\"")= , TYPE_BOOL), - OPT_CALLBACK_VALUE(0, "int", &type, N_("value is decimal number"), TYPE_I= NT), - OPT_CALLBACK_VALUE(0, "bool-or-int", &type, N_("value is --bool or --int"= ), TYPE_BOOL_OR_INT), - OPT_CALLBACK_VALUE(0, "bool-or-str", &type, N_("value is --bool or string= "), TYPE_BOOL_OR_STR), - OPT_CALLBACK_VALUE(0, "path", &type, N_("value is a path (file or directo= ry name)"), TYPE_PATH), - OPT_CALLBACK_VALUE(0, "expiry-date", &type, N_("value is an expiry date")= , TYPE_EXPIRY_DATE), + CONFIG_TYPE_OPTIONS, CONFIG_DISPLAY_OPTIONS, OPT_GROUP(N_("Other")), OPT_STRING(0, "default", &default_value, N_("value"), N_("with --get, use= default value when missing entry")), @@ -797,8 +805,51 @@ static int cmd_config_list(int argc, const char **argv= , const char *prefix) return 0; } =20 +static int cmd_config_get(int argc, const char **argv, const char *prefix) +{ + const char *value_pattern =3D NULL, *url =3D NULL; + int flags =3D 0; + struct option opts[] =3D { + CONFIG_LOCATION_OPTIONS, + CONFIG_TYPE_OPTIONS, + OPT_GROUP(N_("Filter options")), + OPT_BOOL(0, "all", &do_all, N_("return all values for multi-valued confi= g options")), + OPT_BOOL(0, "regexp", &use_key_regexp, N_("interpret the name as a regul= ar expression")), + OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("show config wi= th values matching the pattern")), + OPT_BIT(0, "fixed-value", &flags, N_("use string equality when comparing= values to value pattern"), CONFIG_FLAGS_FIXED_VALUE), + OPT_STRING(0, "url", &url, N_("URL"), N_("show config matching the given= URL")), + CONFIG_DISPLAY_OPTIONS, + OPT_BOOL(0, "show-names", &show_keys, N_("show config keys in addition t= o their values")), + OPT_GROUP(N_("Other")), + OPT_BOOL(0, "includes", &respect_includes_opt, N_("respect include direc= tives on lookup")), + OPT_STRING(0, "default", &default_value, N_("value"), N_("use default va= lue when missing entry")), + OPT_END(), + }; + + argc =3D parse_options(argc, argv, prefix, opts, builtin_config_get_usage, + PARSE_OPT_STOP_AT_NON_OPTION); + check_argc(argc, 1, 1); + + if ((flags & CONFIG_FLAGS_FIXED_VALUE) && !value_pattern) + die(_("--fixed-value only applies with 'value-pattern'")); + if (default_value && (do_all || url)) + die(_("--default=3D cannot be used with --all or --url=3D")); + if (url && (do_all || use_key_regexp || value_pattern)) + die(_("--url=3D cannot be used with --all, --regexp or --value")); + + handle_config_location(prefix); + handle_nul(); + + setup_auto_pager("config", 1); + + if (url) + return get_urlmatch(argv[0], url); + return get_value(argv[0], value_pattern, flags); +} + static struct option builtin_subcommand_options[] =3D { OPT_SUBCOMMAND("list", &subcommand, cmd_config_list), + OPT_SUBCOMMAND("get", &subcommand, cmd_config_get), OPT_END(), }; =20 diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 720f0ee929..7f6746936e 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -17,9 +17,15 @@ do case "$mode" in legacy) mode_prefix=3D"--" + mode_get=3D"" + mode_get_all=3D"--get-all" + mode_get_regexp=3D"--get-regexp" ;; subcommands) mode_prefix=3D"" + mode_get=3D"get" + mode_get_all=3D"get --all" + mode_get_regexp=3D"get --regexp --all --show-names" ;; *) echo "unknown mode $mode" >&2 @@ -289,7 +295,7 @@ test_expect_success 'multi-valued get-all returns all' ' wow wow2 for me EOF - git config --get-all nextsection.nonewline >actual && + git config ${mode_get_all} nextsection.nonewline >actual && test_cmp expect actual ' =20 @@ -391,7 +397,7 @@ nextsection.nonewline wow2 for me EOF =20 test_expect_success '--get-regexp' ' - git config --get-regexp in >output && + git config ${mode_get_regexp} in >output && test_cmp expect output ' =20 @@ -401,7 +407,7 @@ nextsection.nonewline EOF =20 test_expect_success '--name-only --get-regexp' ' - git config --name-only --get-regexp in >output && + git config ${mode_get_regexp} --name-only in >output && test_cmp expect output ' =20 @@ -412,7 +418,7 @@ EOF =20 test_expect_success '--add' ' git config --add nextsection.nonewline "wow4 for you" && - git config --get-all nextsection.nonewline > output && + git config ${mode_get_all} nextsection.nonewline > output && test_cmp expect output ' =20 @@ -434,21 +440,21 @@ test_expect_success 'get variable with empty value' ' echo novalue.variable > expect =20 test_expect_success 'get-regexp variable with no value' ' - git config --get-regexp novalue > output && + git config ${mode_get_regexp} novalue > output && test_cmp expect output ' =20 echo 'novalue.variable true' > expect =20 test_expect_success 'get-regexp --bool variable with no value' ' - git config --bool --get-regexp novalue > output && + git config ${mode_get_regexp} --bool novalue > output && test_cmp expect output ' =20 echo 'emptyvalue.variable ' > expect =20 test_expect_success 'get-regexp variable with empty value' ' - git config --get-regexp emptyvalue > output && + git config ${mode_get_regexp} emptyvalue > output && test_cmp expect output ' =20 @@ -1022,7 +1028,7 @@ test_expect_success 'quoting' ' ' =20 test_expect_success 'key with newline' ' - test_must_fail git config "key.with + test_must_fail git config ${mode_get} "key.with newline" 123' =20 test_expect_success 'value with newline' 'git config key.sub value.with\\\ @@ -1076,7 +1082,7 @@ test_expect_success '--null --list' ' ' =20 test_expect_success '--null --get-regexp' ' - git config --null --get-regexp "val[0-9]" >result.raw && + git config ${mode_get_regexp} --null "val[0-9]" >result.raw && nul_to_q result && echo >>result && test_cmp expect result @@ -1158,11 +1164,11 @@ test_expect_success 'git -c can represent empty str= ing' ' ' =20 test_expect_success 'key sanity-checking' ' - test_must_fail git config foo=3Dbar && - test_must_fail git config foo=3D.bar && - test_must_fail git config foo.ba=3Dr && - test_must_fail git config foo.1bar && - test_must_fail git config foo."ba + test_must_fail git config ${mode_get} foo=3Dbar && + test_must_fail git config ${mode_get} foo=3D.bar && + test_must_fail git config ${mode_get} foo.ba=3Dr && + test_must_fail git config ${mode_get} foo.1bar && + test_must_fail git config ${mode_get} foo."ba z".bar && test_must_fail git config . false && test_must_fail git config .foo false && @@ -1211,7 +1217,7 @@ test_expect_success 'git -c complains about empty key= and value' ' ' =20 test_expect_success 'multiple git -c appends config' ' - test_config alias.x "!git -c x.two=3D2 config --get-regexp ^x\.*" && + test_config alias.x "!git -c x.two=3D2 config ${mode_get_regexp} ^x\.*" && cat >expect <<-\EOF && x.one 1 x.two 2 @@ -1377,7 +1383,7 @@ test_expect_success 'GIT_CONFIG_PARAMETERS handles ol= d-style entries' ' v=3D"${SQ}key.one=3Dfoo${SQ}" && v=3D"$v ${SQ}key.two=3Dbar${SQ}" && v=3D"$v ${SQ}key.ambiguous=3Dsection.whatever=3Dvalue${SQ}" && - GIT_CONFIG_PARAMETERS=3D$v git config --get-regexp "key.*" >actual && + GIT_CONFIG_PARAMETERS=3D$v git config ${mode_get_regexp} "key.*" >actual = && cat >expect <<-EOF && key.one foo key.two bar @@ -1390,7 +1396,7 @@ test_expect_success 'GIT_CONFIG_PARAMETERS handles ne= w-style entries' ' v=3D"${SQ}key.one${SQ}=3D${SQ}foo${SQ}" && v=3D"$v ${SQ}key.two${SQ}=3D${SQ}bar${SQ}" && v=3D"$v ${SQ}key.ambiguous=3Dsection.whatever${SQ}=3D${SQ}value${SQ}" && - GIT_CONFIG_PARAMETERS=3D$v git config --get-regexp "key.*" >actual && + GIT_CONFIG_PARAMETERS=3D$v git config ${mode_get_regexp} "key.*" >actual = && cat >expect <<-EOF && key.one foo key.two bar @@ -1404,7 +1410,7 @@ test_expect_success 'old and new-style entries can mi= x' ' v=3D"$v ${SQ}key.newone${SQ}=3D${SQ}newfoo${SQ}" && v=3D"$v ${SQ}key.oldtwo=3Doldbar${SQ}" && v=3D"$v ${SQ}key.newtwo${SQ}=3D${SQ}newbar${SQ}" && - GIT_CONFIG_PARAMETERS=3D$v git config --get-regexp "key.*" >actual && + GIT_CONFIG_PARAMETERS=3D$v git config ${mode_get_regexp} "key.*" >actual = && cat >expect <<-EOF && key.oldone oldfoo key.newone newfoo @@ -1417,7 +1423,7 @@ test_expect_success 'old and new-style entries can mi= x' ' test_expect_success 'old and new bools with ambiguous subsection' ' v=3D"${SQ}key.with=3Dequals.oldbool${SQ}" && v=3D"$v ${SQ}key.with=3Dequals.newbool${SQ}=3D" && - GIT_CONFIG_PARAMETERS=3D$v git config --get-regexp "key.*" >actual && + GIT_CONFIG_PARAMETERS=3D$v git config ${mode_get_regexp} "key.*" >actual = && cat >expect <<-EOF && key.with equals.oldbool key.with=3Dequals.newbool @@ -1431,7 +1437,7 @@ test_expect_success 'detect bogus GIT_CONFIG_PARAMETE= RS' ' env.two two EOF GIT_CONFIG_PARAMETERS=3D"${SQ}env.one=3Done${SQ} ${SQ}env.two=3Dtwo${SQ}"= \ - git config --get-regexp "env.*" >actual && + git config ${mode_get_regexp} "env.*" >actual && test_cmp expect actual && =20 cat >expect <<-EOF && @@ -1439,12 +1445,12 @@ test_expect_success 'detect bogus GIT_CONFIG_PARAME= TERS' ' env.two two EOF GIT_CONFIG_PARAMETERS=3D"${SQ}env.one=3Done${SQ}\\$SQ$SQ$SQ ${SQ}env.two= =3Dtwo${SQ}" \ - git config --get-regexp "env.*" >actual && + git config ${mode_get_regexp} "env.*" >actual && test_cmp expect actual && =20 test_must_fail env \ GIT_CONFIG_PARAMETERS=3D"${SQ}env.one=3Done${SQ}\\$SQ ${SQ}env.two=3Dtwo= ${SQ}" \ - git config --get-regexp "env.*" + git config ${mode_get_regexp} "env.*" ' =20 test_expect_success 'git --config-env=3Dkey=3Denvvar support' ' @@ -1492,7 +1498,7 @@ test_expect_success 'git -c and --config-env work tog= ether' ' ENVVAR=3Denv-value git \ -c bar.cmd=3Dcmd-value \ --config-env=3Dbar.env=3DENVVAR \ - config --get-regexp "^bar.*" >actual && + config ${mode_get_regexp} "^bar.*" >actual && test_cmp expect actual ' =20 @@ -1520,7 +1526,7 @@ test_expect_success 'git config handles environment c= onfig pairs' ' GIT_CONFIG_COUNT=3D2 \ GIT_CONFIG_KEY_0=3D"pair.one" GIT_CONFIG_VALUE_0=3D"foo" \ GIT_CONFIG_KEY_1=3D"pair.two" GIT_CONFIG_VALUE_1=3D"bar" \ - git config --get-regexp "pair.*" >actual && + git config ${mode_get_regexp} "pair.*" >actual && cat >expect <<-EOF && pair.one foo pair.two bar @@ -1530,7 +1536,7 @@ test_expect_success 'git config handles environment c= onfig pairs' ' =20 test_expect_success 'git config ignores pairs without count' ' test_must_fail env GIT_CONFIG_KEY_0=3D"pair.one" GIT_CONFIG_VALUE_0=3D"va= lue" \ - git config pair.one 2>error && + git config ${mode_get} pair.one 2>error && test_must_be_empty error ' =20 @@ -1538,7 +1544,7 @@ test_expect_success 'git config ignores pairs exceedi= ng count' ' GIT_CONFIG_COUNT=3D1 \ GIT_CONFIG_KEY_0=3D"pair.one" GIT_CONFIG_VALUE_0=3D"value" \ GIT_CONFIG_KEY_1=3D"pair.two" GIT_CONFIG_VALUE_1=3D"value" \ - git config --get-regexp "pair.*" >actual 2>error && + git config ${mode_get_regexp} "pair.*" >actual 2>error && cat >expect <<-EOF && pair.one value EOF @@ -1549,14 +1555,14 @@ test_expect_success 'git config ignores pairs excee= ding count' ' test_expect_success 'git config ignores pairs with zero count' ' test_must_fail env \ GIT_CONFIG_COUNT=3D0 GIT_CONFIG_KEY_0=3D"pair.one" GIT_CONFIG_VALUE_0=3D= "value" \ - git config pair.one 2>error && + git config ${mode_get} pair.one 2>error && test_must_be_empty error ' =20 test_expect_success 'git config ignores pairs with empty count' ' test_must_fail env \ GIT_CONFIG_COUNT=3D GIT_CONFIG_KEY_0=3D"pair.one" GIT_CONFIG_VALUE_0=3D"= value" \ - git config pair.one 2>error && + git config ${mode_get} pair.one 2>error && test_must_be_empty error ' =20 @@ -1595,7 +1601,7 @@ test_expect_success 'environment overrides config fil= e' ' one =3D value EOF GIT_CONFIG_COUNT=3D1 GIT_CONFIG_KEY_0=3Dpair.one GIT_CONFIG_VALUE_0=3Dove= rride \ - git config pair.one >actual && + git config ${mode_get} pair.one >actual && cat >expect <<-EOF && override EOF @@ -1605,7 +1611,7 @@ test_expect_success 'environment overrides config fil= e' ' test_expect_success 'GIT_CONFIG_PARAMETERS overrides environment config' ' GIT_CONFIG_COUNT=3D1 GIT_CONFIG_KEY_0=3Dpair.one GIT_CONFIG_VALUE_0=3Dval= ue \ GIT_CONFIG_PARAMETERS=3D"${SQ}pair.one=3Doverride${SQ}" \ - git config pair.one >actual && + git config ${mode_get} pair.one >actual && cat >expect <<-EOF && override EOF @@ -1680,20 +1686,28 @@ test_expect_success 'urlmatch' ' =20 test_expect_code 1 git config --bool --get-urlmatch doesnt.exist https://= good.example.com >actual && test_must_be_empty actual && + test_expect_code 1 git config get --url=3Dhttps://good.example.com --bool= doesnt.exist >actual && + test_must_be_empty actual && =20 echo true >expect && git config --bool --get-urlmatch http.SSLverify https://good.example.com = >actual && test_cmp expect actual && + git config get --bool --url=3Dhttps://good.example.com http.SSLverify >ac= tual && + test_cmp expect actual && =20 echo false >expect && git config --bool --get-urlmatch http.sslverify https://weak.example.com = >actual && test_cmp expect actual && + git config get --bool --url=3Dhttps://weak.example.com http.sslverify >ac= tual && + test_cmp expect actual && =20 { echo http.cookiefile /tmp/cookie.txt && echo http.sslverify false } >expect && git config --get-urlmatch HTTP https://weak.example.com >actual && + test_cmp expect actual && + git config get --url=3Dhttps://weak.example.com HTTP >actual && test_cmp expect actual ' =20 @@ -1709,6 +1723,8 @@ test_expect_success 'urlmatch with --show-scope' ' local http.sslverify false EOF git config --get-urlmatch --show-scope HTTP https://weak.example.com >act= ual && + test_cmp expect actual && + git config get --url=3Dhttps://weak.example.com --show-scope HTTP >actual= && test_cmp expect actual ' =20 @@ -1741,45 +1757,67 @@ test_expect_success 'urlmatch favors more specific = URLs' ' echo http.cookiefile /tmp/root.txt >expect && git config --get-urlmatch HTTP https://example.com >actual && test_cmp expect actual && + git config get --url=3Dhttps://example.com HTTP >actual && + test_cmp expect actual && =20 echo http.cookiefile /tmp/subdirectory.txt >expect && git config --get-urlmatch HTTP https://example.com/subdirectory >actual && test_cmp expect actual && + git config get --url=3Dhttps://example.com/subdirectory HTTP >actual && + test_cmp expect actual && =20 echo http.cookiefile /tmp/subdirectory.txt >expect && git config --get-urlmatch HTTP https://example.com/subdirectory/nested >a= ctual && test_cmp expect actual && + git config get --url=3Dhttps://example.com/subdirectory/nested HTTP >actu= al && + test_cmp expect actual && =20 echo http.cookiefile /tmp/user.txt >expect && git config --get-urlmatch HTTP https://user@example.com/ >actual && test_cmp expect actual && + git config get --url=3Dhttps://user@example.com/ HTTP >actual && + test_cmp expect actual && =20 echo http.cookiefile /tmp/subdirectory.txt >expect && git config --get-urlmatch HTTP https://averylonguser@example.com/subdirec= tory >actual && test_cmp expect actual && + git config get --url=3Dhttps://averylonguser@example.com/subdirectory HTT= P >actual && + test_cmp expect actual && =20 echo http.cookiefile /tmp/preceding.txt >expect && git config --get-urlmatch HTTP https://preceding.example.com >actual && test_cmp expect actual && + git config get --url=3Dhttps://preceding.example.com HTTP >actual && + test_cmp expect actual && =20 echo http.cookiefile /tmp/wildcard.txt >expect && git config --get-urlmatch HTTP https://wildcard.example.com >actual && test_cmp expect actual && + git config get --url=3Dhttps://wildcard.example.com HTTP >actual && + test_cmp expect actual && =20 echo http.cookiefile /tmp/sub.txt >expect && git config --get-urlmatch HTTP https://sub.example.com/wildcardwithsubdom= ain >actual && test_cmp expect actual && + git config get --url=3Dhttps://sub.example.com/wildcardwithsubdomain HTTP= >actual && + test_cmp expect actual && =20 echo http.cookiefile /tmp/trailing.txt >expect && git config --get-urlmatch HTTP https://trailing.example.com >actual && test_cmp expect actual && + git config get --url=3Dhttps://trailing.example.com HTTP >actual && + test_cmp expect actual && =20 echo http.cookiefile /tmp/sub.txt >expect && git config --get-urlmatch HTTP https://user@sub.example.com >actual && test_cmp expect actual && + git config get --url=3Dhttps://user@sub.example.com HTTP >actual && + test_cmp expect actual && =20 echo http.cookiefile /tmp/multiwildcard.txt >expect && git config --get-urlmatch HTTP https://wildcard.example.org >actual && + test_cmp expect actual && + git config get --url=3Dhttps://wildcard.example.org HTTP >actual && test_cmp expect actual ' =20 @@ -1902,7 +1940,7 @@ test_expect_success '--unset last key removes section= (except if commented)' ' [one] EOF git config --unset two.subsection.key && - test "not [two subsection]" =3D "$(git config one.key)" && + test "not [two subsection]" =3D "$(git config ${mode_get} one.key)" && test_line_count =3D 3 .git/config ' =20 @@ -2025,7 +2063,7 @@ test_expect_success '--show-origin with --get-regexp'= ' file:$HOME/.gitconfig user.global true file:.git/config user.local true EOF - git config --show-origin --get-regexp "user\.[g|l].*" >output && + git config ${mode_get_regexp} --show-origin "user\.[g|l].*" >output && test_cmp expect output ' =20 @@ -2033,7 +2071,7 @@ test_expect_success '--show-origin getting a single k= ey' ' cat >expect <<-\EOF && file:.git/config local EOF - git config --show-origin user.override >output && + git config ${mode_get} --show-origin user.override >output && test_cmp expect output ' =20 @@ -2165,7 +2203,7 @@ test_expect_success '--show-scope getting a single va= lue' ' cat >expect <<-\EOF && local true EOF - git config --show-scope --get user.local >output && + git config ${mode_get} --show-scope user.local >output && test_cmp expect output ' =20 @@ -2434,9 +2472,9 @@ test_expect_success 'refuse --fixed-value for incompa= tible actions' ' # These modes complain when --fixed-value has no value-pattern test_must_fail git config --file=3Dconfig --fixed-value dev.null bogus && test_must_fail git config --file=3Dconfig --fixed-value --replace-all dev= =2Enull bogus && - test_must_fail git config --file=3Dconfig --fixed-value --get dev.null && - test_must_fail git config --file=3Dconfig --fixed-value --get-all dev.nul= l && - test_must_fail git config --file=3Dconfig --fixed-value --get-regexp "dev= =2E*" && + test_must_fail git config ${mode_prefix}get --file=3Dconfig --fixed-value= dev.null && + test_must_fail git config ${mode_get_all} --file=3Dconfig --fixed-value d= ev.null && + test_must_fail git config ${mode_get_regexp} --file=3Dconfig --fixed-valu= e "dev.*" && test_must_fail git config --file=3Dconfig --fixed-value --unset dev.null = && test_must_fail git config --file=3Dconfig --fixed-value --unset-all dev.n= ull ' @@ -2466,12 +2504,12 @@ test_expect_success '--fixed-value uses exact strin= g matching' ' cp initial config && test_must_fail git config --file=3Dconfig --unset fixed.test "$META" && git config --file=3Dconfig --fixed-value --unset fixed.test "$META" && - test_must_fail git config --file=3Dconfig fixed.test && + test_must_fail git config ${mode_get} --file=3Dconfig fixed.test && =20 cp initial config && test_must_fail git config --file=3Dconfig --unset-all fixed.test "$META" = && git config --file=3Dconfig --fixed-value --unset-all fixed.test "$META" && - test_must_fail git config --file=3Dconfig fixed.test && + test_must_fail git config ${mode_get} --file=3Dconfig fixed.test && =20 cp initial config && git config --file=3Dconfig --replace-all fixed.test bogus "$META" && @@ -2498,18 +2536,27 @@ test_expect_success '--get and --get-all with --fix= ed-value' ' git config --file=3Dconfig --add fixed.test "$META" && =20 git config --file=3Dconfig --get fixed.test bogus && + git config get --file=3Dconfig --value=3Dbogus fixed.test && test_must_fail git config --file=3Dconfig --get fixed.test "$META" && + test_must_fail git config get --file=3Dconfig --value=3D"$META" fixed.tes= t && git config --file=3Dconfig --get --fixed-value fixed.test "$META" && + git config get --file=3Dconfig --fixed-value --value=3D"$META" fixed.test= && test_must_fail git config --file=3Dconfig --get --fixed-value fixed.test = non-existent && =20 git config --file=3Dconfig --get-all fixed.test bogus && + git config get --all --file=3Dconfig --value=3Dbogus fixed.test && test_must_fail git config --file=3Dconfig --get-all fixed.test "$META" && + test_must_fail git config get --all --file=3Dconfig --value=3D"$META" fix= ed.test && git config --file=3Dconfig --get-all --fixed-value fixed.test "$META" && + git config get --all --file=3Dconfig --value=3D"$META" --fixed-value fixe= d.test && test_must_fail git config --file=3Dconfig --get-all --fixed-value fixed.t= est non-existent && =20 git config --file=3Dconfig --get-regexp fixed+ bogus && + git config get --regexp --file=3Dconfig --value=3Dbogus fixed+ && test_must_fail git config --file=3Dconfig --get-regexp fixed+ "$META" && + test_must_fail git config get --regexp --file=3Dconfig --value=3D"$META" = fixed+ && git config --file=3Dconfig --get-regexp --fixed-value fixed+ "$META" && + git config get --regexp --file=3Dconfig --fixed-value --value=3D"$META" f= ixed+ && test_must_fail git config --file=3Dconfig --get-regexp --fixed-value fixe= d+ non-existent ' =20 --=20 2.44.0 --sbclfVtyAbHvwIjV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAmXvkc0ACgkQVbJhu7ck PpSp9w//UKBgUS7DVnNWZoCnFLw9b16RZ4VGCxLjSh0Bh51kwb1P6rxLDIYzTpZ9 LzHF1mfasC4/5bqoOISR8QIxcpJRPMnj+7+wdt2mAYOLGXA0I3ADiv/QmENdkO74 F/+HPdAq9UVOSxV6xAzTW4GtMYDj/fBtR3hCerd9GEBM7o2TPQvP3aA6ZmSmsWv0 J03Nns/6WEQbJTZtdzqazuLP9vC/SmOnfXiRWURATmP8AXro0DMIflO5vIvZa8mC rbRjxh22JTpt1zjsyS69FI2omD3eqCMG8ylEfNjZ4/3n3QTajctkFey8kA7Nbbh2 1nne4bMFmKvyR/eeHVsruiRzorxnxmOLiBdQy11rLekxHZ3RkldQFtTZndkOAeCA aSjj2JD/3mTzbV5zf01zWgCsdCZWuEs2tR+mTjfbVDmvJ19+ZeiBwnOf0d8uzLIr l7l7l7AJ8l1fAQ4GVKPbCeIg9nXDGDF8eazth6pnUBmPDiWDpDxp9E8JgUPIIuVr /eqvBSsJHDzgsXSTCr9aKsv2hNZRCh4oYfwfzGU+sXVkNgCTKTS5nbVwNOVWWWQP hAJ/SQuX7YWgnM5s/nFqEmNPQ4TLaUoCGoyInfUCNqxvNM22WtTth+okD3DepiNQ DL2Yox/eJXU+N/TP4ifmc8civC4NiUa35j5rtAn8a0VPcpUN4Qk= =UQor -----END PGP SIGNATURE----- --sbclfVtyAbHvwIjV--