From: "Lars Hjemli" <hjemli@gmail.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] runstatus: restructure visual appearance
Date: Wed, 13 Dec 2006 10:27:37 +0100 [thread overview]
Message-ID: <8c5c35580612130127y1b094dbbq34c06376704b0506@mail.gmail.com> (raw)
In-Reply-To: <7v3b7koc6b.fsf@assigned-by-dhcp.cox.net>
On 12/13/06, Junio C Hamano <junkio@cox.net> wrote:
> "Lars Hjemli" <hjemli@gmail.com> writes:
> > Just wondering if this patch got dropped or simply overlooked...
>
> I looked at the patch, and I was neutral to slightly negative
> (but only slightly. I thought M vs M+ was too subtle and
> cryptic until the user gets used to them).
Hmm, yes, I agree it's a bit subtle. But whenever the '+' or '-' is
added to a state symbol, the big warning that is printed should make
it less so (the warning should also mention git-rm, btw).
And of course the man-page for git-status should be updated to
describe the different state symbols, the meaning of +/-, and how to
'resolve' them.
> I however did not see overwhelming support from the list, so I
> did not further think about it.
The silence was earth shattering
> One thing that was mentioned in the past on the list about the
> output from git-status was that we do not make mode changes
> stand out, and people can mistakenly do something silly to
> change the -x bit and the current git-status would only say:
>
> modified: git-foobar.sh
>
> which would not help them notice the mistake, as a result,
> accidental mode change can get committed.
>
>If we are designing a new format to make git-status output more
>compact and easier to understand, I think it should also attempt
>to address this problem as well.
Excellent point, I'll use it as an excuse to refine and resend the patch.
--
next prev parent reply other threads:[~2006-12-13 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-02 19:37 [RFC/PATCH] runstatus: restructure visual appearance Lars Hjemli
2006-12-12 11:30 ` Lars Hjemli
2006-12-13 0:46 ` Junio C Hamano
2006-12-13 9:27 ` Lars Hjemli [this message]
2006-12-13 16:12 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5c35580612130127y1b094dbbq34c06376704b0506@mail.gmail.com \
--to=hjemli@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).