From: Beat Bolli <dev+git@drbeat.li>
To: Junio C Hamano <gitster@pobox.com>, Denton Liu <liu.denton@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] pretty: allow to override the built-in formats
Date: Mon, 7 Sep 2020 07:36:47 +0200 [thread overview]
Message-ID: <8bb68268-8e4c-749e-b2e0-21b38b70c8bf@drbeat.li> (raw)
In-Reply-To: <xmqqeene36t7.fsf@gitster.c.googlers.com>
On 06.09.20 23:59, Junio C Hamano wrote:
> Denton Liu <liu.denton@gmail.com> writes:
>
>> Hmm, I'm not sure how I feel about being able to override formats other
>> than "reference".
>
> Is the idea to introduce a parallel namespace to pretty.<name>? I
> am not sure why that is a good idea than, say a single variable that
> says "to me, pretty.<name> would override even the built-in names".
>
> I am not sure how I feel about being able to override built-in
> formats in the first place, though.
>
> After all, pretty.<name> were introduced so that user-defined ones
> can be invoked with an equal ease as the built-in ones, but
> overriding common understanding among the users of the tool is a
> different story.
I gave a reason for the reference format, at least.
Would you be fine with a patch that just allows to override the
reference format (for the stated reasons)?
next prev parent reply other threads:[~2020-09-07 5:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 19:24 [PATCH] pretty: allow to override the built-in formats Beat Bolli
2020-09-05 19:52 ` Denton Liu
2020-09-06 21:59 ` Junio C Hamano
2020-09-07 5:36 ` Beat Bolli [this message]
2020-09-07 6:54 ` Junio C Hamano
2020-09-07 7:06 ` Beat Bolli
2020-09-08 13:53 ` Jeff King
2020-09-08 18:12 ` Junio C Hamano
2020-09-09 9:08 ` Jeff King
2020-09-09 18:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bb68268-8e4c-749e-b2e0-21b38b70c8bf@drbeat.li \
--to=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).