From: hukeping <hukeping@huawei.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Git List" <git@vger.kernel.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Zhengjunling (JRing, Task Force)" <zhengjunling@huawei.com>,
zhuangbiaowei <zhuangbiaowei@huawei.com>,
"Patrick Hemmer" <git@stormcloud9.net>,
"Rafael Ascensao" <rafa.almas@gmail.com>,
"René Scharfe" <l.s.r@web.de>, "Jeff King" <peff@peff.net>
Subject: RE: [PATCH v2] format-patch: make output filename configurable
Date: Tue, 10 Nov 2020 04:44:21 +0000 [thread overview]
Message-ID: <8b97c61e983c432aab1063912d6266b9@huawei.com> (raw)
In-Reply-To: <xmqqr1p27x8d.fsf@gitster.c.googlers.com>
>> It would be very hard to remove a config knob rather than add a new
>> one and we already have too many.
>>
>> Does it worth to add a new configuration variable for this or just a
>> hard-coded value is enough?
>
>I personally would say "yes, the current code that limits to 64 is enough", but you,
>as the person who said that you do not like the current hard-coded value, are not
>in the position to ask that question, I would have to say---if it were enough for
>you, you wouldn't have complained about 64 in the first place ;-)
The original motivation is to lengthening the limit because of file name truncated problem,
so update the value to a larger one seems like the simplest way for me.
The v2 patch can fundamentally solve this problem, just a little worry about the more and
more git-config knobs.
next prev parent reply other threads:[~2020-11-10 4:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 20:15 [PATCH] Lengthening FORMAT_PATCH_NAME_MAX to 80 Hu Keping
2020-11-05 15:01 ` Jeff King
2020-11-05 21:16 ` Junio C Hamano
2020-11-06 8:51 ` hukeping
2020-11-06 17:45 ` Junio C Hamano
2020-11-06 20:50 ` Junio C Hamano
2020-11-06 21:56 ` [PATCH] format-patch: make output filename configurable Junio C Hamano
2020-11-06 22:05 ` Eric Sunshine
2020-11-09 19:23 ` [PATCH v2] " Junio C Hamano
2020-11-10 0:23 ` Jeff King
2020-11-10 1:43 ` Junio C Hamano
2020-11-10 2:31 ` hukeping
2020-11-10 2:37 ` Junio C Hamano
2020-11-10 4:44 ` hukeping [this message]
2020-11-10 5:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b97c61e983c432aab1063912d6266b9@huawei.com \
--to=hukeping@huawei.com \
--cc=git@stormcloud9.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=rafa.almas@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=zhengjunling@huawei.com \
--cc=zhuangbiaowei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).