git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>,
	Git Mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] t3200-branch.sh: use "--set-upstream-to" in test
Date: Wed, 6 Jun 2018 21:20:17 +0530	[thread overview]
Message-ID: <8af183f2-7ca5-86ba-b189-6b6885158453@gmail.com> (raw)
In-Reply-To: <20180605112446.17016-1-szeder.dev@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1546 bytes --]

On Tuesday 05 June 2018 04:54 PM, SZEDER Gábor wrote:
> 
> Though arguably the test name could be more descriptive and tell why
> it should fail.
> 

That's arguable, indeed. I was about to send a patch that gives a better
description for the test. I didn't do it as I started wondering, Is it
even worth testing whether a removed option fails? Is this done for
other options that have been removed in the past? Should we just remove
the test completely?

-- 
Sivaraam

QUOTE:

“The three principal virtues of a programmer are Laziness, Impatience,
and Hubris.”

	- Camel book

Sivaraam?

You possibly might have noticed that my signature recently changed from
'Kaartic' to 'Sivaraam' both of which are parts of my name. I find the
new signature to be better for several reasons one of which is that the
former signature has a lot of ambiguities in the place I live as it is a
common name (NOTE: it's not a common spelling, just a common name). So,
I switched signatures before it's too late.

That said, I won't mind you calling me 'Kaartic' if you like it [of
course ;-)]. You can always call me using either of the names.


KIND NOTE TO THE NATIVE ENGLISH SPEAKER:

As I'm not a native English speaker myself, there might be mistaeks in
my usage of English. I apologise for any mistakes that I make.

It would be "helpful" if you take the time to point out the mistakes.

It would be "super helpful" if you could provide suggestions about how
to correct those mistakes.

Thanks in advance!


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2018-06-06 15:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 11:14 [PATCH] t3200-branch.sh: use "--set-upstream-to" in test Robert P. J. Day
2018-06-05 11:24 ` SZEDER Gábor
2018-06-05 11:34   ` Robert P. J. Day
2018-06-06 15:50   ` Kaartic Sivaraam [this message]
2018-06-14 14:06   ` [PATCH] t3200: clarify description of --set-upstream test Kaartic Sivaraam
2018-06-14 17:43     ` Junio C Hamano
2018-06-17  8:53       ` Kaartic Sivaraam
2018-06-17 11:56       ` [PATCH v2] " Kaartic Sivaraam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8af183f2-7ca5-86ba-b189-6b6885158453@gmail.com \
    --to=kaarticsivaraam91196@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=rpjday@crashcourse.ca \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).